If comment out WaitSyncTokenCHROMIUM add since this CL:https://chromium-review.googlesource.com/c/chromium/src/+/1242080/9/cc/raster/gpu_raster_buffer_provider.cc#143, then load a page, the test page looks incorrect.
If comment out WaitSyncTokenCHROMIUM in below two unit tests, the unit tests pass:
diff --git a/cc/paint/oop_pixeltest.cc b/cc/paint/oop_pixeltest.cc
index f86a674a3813..3946ffe7dcbb 100644
--- a/cc/paint/oop_pixeltest.cc
+++ b/cc/paint/oop_pixeltest.cc
@@ -176,8 +176,8 @@ class OopPixelTest : public testing::Test,
viz::ResourceFormat::RGBA_8888, gfx::Size(width, height),
options.color_space, flags);
EXPECT_TRUE(mailbox.Verify());
- raster_implementation->WaitSyncTokenCHROMIUM(
- sii->GenUnverifiedSyncToken().GetConstData());
+ //raster_implementation->WaitSyncTokenCHROMIUM(
+ //sii->GenUnverifiedSyncToken().GetConstData());
RasterColorSpace color_space(options.color_space, ++color_space_id_);
diff --git a/gpu/ipc/client/raster_in_process_context_tests.cc b/gpu/ipc/client/raster_in_process_context_tests.cc
index 712d5768136a..1e18e0efa9c0 100644
--- a/gpu/ipc/client/raster_in_process_context_tests.cc
+++ b/gpu/ipc/client/raster_in_process_context_tests.cc
@@ -103,7 +103,7 @@ TEST_F(RasterInProcessCommandBufferTest,
gpu::SHARED_IMAGE_USAGE_OOP_RASTERIZATION;
gpu::Mailbox mailbox =
sii->CreateSharedImage(kResourceFormat, kBufferSize, color_space, flags);
- ri_->WaitSyncTokenCHROMIUM(sii->GenUnverifiedSyncToken().GetConstData());
+ //ri_->WaitSyncTokenCHROMIUM(sii->GenUnverifiedSyncToken().GetConstData());
// Call BeginRasterCHROMIUM.
cc::RasterColorSpace raster_color_space(color_space, 0);
So I think we'd better have a case to verify that WaitSyncTokenCHROMIUM is necessary.
Comment 1 by xing...@intel.com
, Dec 13