New issue
Advanced search Search tips

Issue 914709 link

Starred by 5 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 20
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : Focus doesn't traverse to next option on pressing 'Tab' key at first instance in chrome://settings/fonts

Reported by rp...@virtusa.com, Dec 13

Issue description

Chrome Version: 73.0.3638.0 (Official Build) Revision c6d06cddb87285ab9e8d92e07af7918bb728ea67-refs/branch-heads/3638@{#1}(32/64-bit)
OS: Windows (7,8,8.1,10),Mac OS X(10.14.2,10.13.1,10.13.6)
             
Steps to reproduce:
1. Launch chrome, navigate to chrome://settings page
2. Now go to customize fonts and bring focus on 'Font size' slider.
3. Now press 'Tab' key once to move focus ahead and observe

Actual Result: Focus gets lost on pressing 'Tab' key once
Expected Result: Focus should be seen on 'Minimum font size' slider on pressing 'Tab' key

This is a regression issue, broken in 'M-73', and will soon update other info :
Good Build:73.0.3637.0 (Revision:615357)
Bad Build: 73.0.3638.0 (Revision:615716)

 
Actual_video.mov
2.8 MB View Download
Expected_video.mov
1.9 MB View Download
Labels: hasbisect-per-revision OS-Linux
Owner: aee@chromium.org
Status: Assigned (was: Unconfirmed)
Summary: Regression : Focus doesn't traverse to next option on pressing 'Tab' key at first instance in chrome://settings/fonts (was: REgression : Focus gets lost on pressing 'Tab' key in chrome://settings/fonts.)
Correction in Actual result :

Actual result : Focus doesn't traverse to next option ('Minimum font size' slider) on pressing 'Tab' key at first instance.

You are probably looking for a change made after 615622 (known good), but no later than 615623 (first known bad).

CHANGELOG URL:

The script might not always return single CL as suspect as some perf builds might get missing due to failure.

https://chromium.googlesource.com/chromium/src/+log/bc520eee80b99a4edf8c5072434cf988d96e63de..a2e98d8b5fd647a3f1c59fff562dd450ddae9bd1

Suspecting: https://chromium.googlesource.com/chromium/src/+/a2e98d8b5fd647a3f1c59fff562dd450ddae9bd1

@aee: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.	

Kindly refer the attached screen cast.

Thank You!
Status: Started (was: Assigned)
Cc: aee@chromium.org ajha@chromium.org
 Issue 915622  has been merged into this issue.
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4cba947c665e6ee78fae6384094485b55d7d6a15

commit 4cba947c665e6ee78fae6384094485b55d7d6a15
Author: Esmael El-Moslimany <aee@chromium.org>
Date: Thu Dec 20 00:49:18 2018

WebUI: cr-slider, forward focus to knob and back to host for tab and shift+tab

Bug:  914709 
Change-Id: Ide38ff7e7f6686433eb96b3b71628b35154fc0e5
Reviewed-on: https://chromium-review.googlesource.com/c/1382900
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618045}
[modify] https://crrev.com/4cba947c665e6ee78fae6384094485b55d7d6a15/ui/webui/resources/cr_elements/cr_slider/cr_slider.html
[modify] https://crrev.com/4cba947c665e6ee78fae6384094485b55d7d6a15/ui/webui/resources/cr_elements/cr_slider/cr_slider.js

Status: Fixed (was: Started)
Labels: TE-Verified-M73 TE-Verified-73.0.3646.0
Update :
Rechecked the above issue on Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.13.1,10.13.6,10.14.2) using latest Canary build : 73.0.3646.0 and the issue is Fixed.Hence adding TE Verified Labels.

Kindly refer the attached screen cast.

Thank you..!!
Fixed_video.mov
2.3 MB View Download
Cc: yawano@chromium.org slangley@chromium.org sa...@chromium.org weifangsun@chromium.org nohe@chromium.org
 Issue 918495  has been merged into this issue.

Sign in to add a comment