New issue
Advanced search Search tips

Issue 914690 link

Starred by 1 user
Status: Assigned
Owner:
hirosh...@chromium.org
Cc:
japhet@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Replace "Document's DocumentLoader's ResourceFetcher" with Document::Fetcher()

Project Member Reported by hirosh...@chromium.org, Dec 13 
In many places we get ResourceFetcher via DocumentLoader::Fetcher() after Documet is created (e.g. as "Document's DocumentLoader's ResourceFetcher", "Document's Frame's FrameLoader's DocumentLoader's ResourceFetcher"), but after the Document is created, it should be the same as Document::Fetcher().

Removing such indirections via DocumentLoader::Fetcher() will make DocumentLoader::Fetcher() navigation-only and thus clarify its usage.
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 14 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/248d648ee3b74db19f2a5f8b5eb77b589177b4e4

commit 248d648ee3b74db19f2a5f8b5eb77b589177b4e4
Author: Hiroshige Hayashizaki <hiroshige@chromium.org>
Date: Fri Dec 14 00:07:58 2018

Remove HTMLResourcePreloader::CountPreloads() and GetDocument()

Simply not used.

Bug: 914690
Change-Id: I80779c7d7b2d4e8e8de410d451a78183931807a0
Reviewed-on: https://chromium-review.googlesource.com/c/1361946
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616511}
[modify] https://crrev.com/248d648ee3b74db19f2a5f8b5eb77b589177b4e4/third_party/blink/renderer/core/html/parser/html_resource_preloader.cc
[modify] https://crrev.com/248d648ee3b74db19f2a5f8b5eb77b589177b4e4/third_party/blink/renderer/core/html/parser/html_resource_preloader.h
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 19 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8b37775cd7343d23f71f9b6d065fdd699a1eb97e

commit 8b37775cd7343d23f71f9b6d065fdd699a1eb97e
Author: Hiroshige Hayashizaki <hiroshige@chromium.org>
Date: Wed Dec 19 02:16:15 2018

Remove dependency to DocumentLoader::Fetcher() from StartPreload()

This CL moves StartPreload() from DocumentLoader to LinkLoader
and use Document::Fetcher() instead of Document::Loader()->Fetcher()
(which should be the same ResourceFetcher).

LinkLoader already has methods for preloading used from
<link rel="preload"> and preloading by HTTP response headers, so
probably it is a good place for StartPreload().

Bug: 914690
Change-Id: I6962c6774a48b503a60b47f87c05d3565e9feb49
Reviewed-on: https://chromium-review.googlesource.com/c/1362006
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Nate Chapin <japhet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617713}
[modify] https://crrev.com/8b37775cd7343d23f71f9b6d065fdd699a1eb97e/third_party/blink/renderer/core/html/parser/preload_request.cc
[modify] https://crrev.com/8b37775cd7343d23f71f9b6d065fdd699a1eb97e/third_party/blink/renderer/core/loader/document_loader.cc
[modify] https://crrev.com/8b37775cd7343d23f71f9b6d065fdd699a1eb97e/third_party/blink/renderer/core/loader/document_loader.h
[modify] https://crrev.com/8b37775cd7343d23f71f9b6d065fdd699a1eb97e/third_party/blink/renderer/core/loader/link_loader.cc
[modify] https://crrev.com/8b37775cd7343d23f71f9b6d065fdd699a1eb97e/third_party/blink/renderer/core/loader/link_loader.h
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 20 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dc6b34095035e15ab48c88d73bac44b4bf59a711

commit dc6b34095035e15ab48c88d73bac44b4bf59a711
Author: Hiroshige Hayashizaki <hiroshige@chromium.org>
Date: Thu Dec 20 05:53:47 2018

Introduce PreloadHelper

This CL creates PreloadHelper that contains common logic for
preload/prefetch/preconnect/etc. by both <link> elements and
preloading by HTTP response headers,
which was previously placed in LinkLoader.

After this CL, LinkLoader is purely for <link> elements.

Bug: 914690
Change-Id: I919918016de2a100d56eb7e749c3f6db2dfbe863
Reviewed-on: https://chromium-review.googlesource.com/c/1382689
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Nate Chapin <japhet@chromium.org>
Reviewed-by: Yoav Weiss <yoav@yoav.ws>
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618124}
[modify] https://crrev.com/dc6b34095035e15ab48c88d73bac44b4bf59a711/third_party/blink/renderer/core/html/html_link_element.cc
[modify] https://crrev.com/dc6b34095035e15ab48c88d73bac44b4bf59a711/third_party/blink/renderer/core/html/html_link_element.h
[modify] https://crrev.com/dc6b34095035e15ab48c88d73bac44b4bf59a711/third_party/blink/renderer/core/html/link_style.cc
[modify] https://crrev.com/dc6b34095035e15ab48c88d73bac44b4bf59a711/third_party/blink/renderer/core/html/parser/html_document_parser.cc
[modify] https://crrev.com/dc6b34095035e15ab48c88d73bac44b4bf59a711/third_party/blink/renderer/core/html/parser/html_preload_scanner.cc
[modify] https://crrev.com/dc6b34095035e15ab48c88d73bac44b4bf59a711/third_party/blink/renderer/core/html/parser/preload_request.cc
[modify] https://crrev.com/dc6b34095035e15ab48c88d73bac44b4bf59a711/third_party/blink/renderer/core/loader/BUILD.gn
[modify] https://crrev.com/dc6b34095035e15ab48c88d73bac44b4bf59a711/third_party/blink/renderer/core/loader/document_loader.cc
[modify] https://crrev.com/dc6b34095035e15ab48c88d73bac44b4bf59a711/third_party/blink/renderer/core/loader/document_loader.h
[modify] https://crrev.com/dc6b34095035e15ab48c88d73bac44b4bf59a711/third_party/blink/renderer/core/loader/frame_fetch_context.cc
[modify] https://crrev.com/dc6b34095035e15ab48c88d73bac44b4bf59a711/third_party/blink/renderer/core/loader/frame_loader.cc
[add] https://crrev.com/dc6b34095035e15ab48c88d73bac44b4bf59a711/third_party/blink/renderer/core/loader/link_load_parameters.cc
[add] https://crrev.com/dc6b34095035e15ab48c88d73bac44b4bf59a711/third_party/blink/renderer/core/loader/link_load_parameters.h
[modify] https://crrev.com/dc6b34095035e15ab48c88d73bac44b4bf59a711/third_party/blink/renderer/core/loader/link_loader.cc
[modify] https://crrev.com/dc6b34095035e15ab48c88d73bac44b4bf59a711/third_party/blink/renderer/core/loader/link_loader.h
[add] https://crrev.com/dc6b34095035e15ab48c88d73bac44b4bf59a711/third_party/blink/renderer/core/loader/preload_helper.cc
[add] https://crrev.com/dc6b34095035e15ab48c88d73bac44b4bf59a711/third_party/blink/renderer/core/loader/preload_helper.h
►

Sign in to add a comment