New issue
Advanced search Search tips

Issue 914665 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 14
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression
Team-Accessibility



Sign in to add a comment

Chromevox reads the wrong item in dropdowns

Project Member Reported by leberly@chromium.org, Dec 13

Issue description

Google Chrome	72.0.3626.8 (Official Build) dev (64-bit) 
Firmware Version	Google_Eve.9584.174.0 


Steps: 
# Enable ChromeVox with ctrl + alt + z
# Go to ANY dropdown in the UI or on a webpage, I used ChromeVox options page via Settings > Manage Accessibility Features 
# Navigate to and expand the dropdown, I used the one for the braille table. Applies to both dropdowns: the one that appears for Select an 8-dot braille table and the one that appears for Select a 6-dot braille table. Therefore, do this step twice, one for each of those options that appear after toggling the button below the dropdown. 
# Navigate through the expanded dropdown
Expected: ChromeVox reads the item that is currently highlighted visually
Actual: ChromeVox reads the item that is either above or below the highlighted item depending on if you are navigating up or down. After reading the wrong item name and index, it then says the correct item name at the end. 
 
I need to check this for regressions, not related to the brand new Bluetooth Braille Display UI. 
This also repros in other ChromeVox options, such as the select voice dropdown.
Labels: BrailleCrOS
Owner: dtseng@chromium.org
Summary: Chromevox reads the wrong item in the dropdowns for ChromeVox settings (was: Chromevox reads the wrong item in the dropdown for braille table dropdown)
+dtseng this looks worse than before
Summary: Chromevox reads the wrong item in dropdowns (was: Chromevox reads the wrong item in the dropdowns for ChromeVox settings)
Version 73.0.3640.0 (Official Build) canary (64-bit)
Google_Cave.7820.384.0
Additional testing shows this issue repros outside ChromeVox options. I was able to repro in settings dropdowns as well as on a web page.
Leo's webpage was http://www.audiogames.net/ where he could repro the bug on the dropdown on the page. 
Description: Show this description
Does not repro on Chrome 70.0.3538.110 (Official Build)(64-bit), checking Beta now.
Labels: -Type-Bug -BrailleCrOS ReleaseBlock-Stable Type-Bug-Regression
Does not repro in stable or beta, this is a regression introduced in M72 and is a ship-stopper. 

71.0.3578.85 (Official Build) beta (64-bit)
70.0.3538.110 (Official Build)(64-bit)

Tested on Settings page, Font Size Combo Box. In both channels, the selection and what ChromeVox reads is the same. 

Marking as Stable ship stopper. 

Project Member

Comment 10 by bugdroid1@chromium.org, Dec 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7ad6601cebdb0f70493ffc0cfdc8d993836c3a91

commit 7ad6601cebdb0f70493ffc0cfdc8d993836c3a91
Author: David Tseng <dtseng@chromium.org>
Date: Wed Dec 19 17:50:17 2018

Only report attribute changes for menu list option when it is selected

Bug:  914665 
Change-Id: I5e817024925603e2a146ce7d881b3d0f7ffdc1f0
Reviewed-on: https://chromium-review.googlesource.com/c/1377378
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617871}
[modify] https://crrev.com/7ad6601cebdb0f70493ffc0cfdc8d993836c3a91/chrome/browser/resources/chromeos/chromevox/cvox2/background/desktop_automation_handler.js

Scheduled to be checked into 73.0.3646.0. 
Labels: Merge-Request-72
Project Member

Comment 13 by sheriffbot@chromium.org, Dec 20

Labels: -Merge-Request-72 Merge-Review-72 Hotlist-Merge-Review
This bug requires manual review: M72 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Hotlist-Merge-Review -Merge-Review-72 Merge-Approved-72
Project Member

Comment 15 by sheriffbot@chromium.org, Dec 24

Cc: dtseng@google.com dgagnon@google.com
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 16 by sheriffbot@chromium.org, Dec 28

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
@dtseng, please let us know which build this fix can be merged into, the merge is apparently already approved 

If you'd like any testing, please let us know. 
Project Member

Comment 18 by bugdroid1@chromium.org, Jan 14

Labels: -merge-approved-72 merge-merged-3626
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a6eae03de12e76cfdf1bb7d575146f7002d81297

commit a6eae03de12e76cfdf1bb7d575146f7002d81297
Author: David Tseng <dtseng@chromium.org>
Date: Mon Jan 14 18:34:13 2019

Merge to m72: Only report attribute changes for menu list option when it is selected

TBR=dtseng@chromium.org

Bug:  914665 
Change-Id: I5e817024925603e2a146ce7d881b3d0f7ffdc1f0
Reviewed-on: https://chromium-review.googlesource.com/c/1377378
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#617871}(cherry picked from commit 7ad6601cebdb0f70493ffc0cfdc8d993836c3a91)
Reviewed-on: https://chromium-review.googlesource.com/c/1409352
Reviewed-by: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#669}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
[modify] https://crrev.com/a6eae03de12e76cfdf1bb7d575146f7002d81297/chrome/browser/resources/chromeos/chromevox/cvox2/background/desktop_automation_handler.js

Status: Fixed (was: Available)
Labels: CommitLog-Audit-Violation Merge-Without-Approval M-72
Here's a summary of the rules that were executed: 
 - OnlyMergeApprovedChange: Rule Failed -- Revision a6eae03de12e76cfdf1bb7d575146f7002d81297 was merged to refs/branch-heads/3626 branch with no merge approval from a TPM! 
Please explain why this change was merged to the branch!
 - AcknowledgeMerge: Notification Required -- 
Labels: Merge-Merged-72-3626
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/a6eae03de12e76cfdf1bb7d575146f7002d81297

Commit: a6eae03de12e76cfdf1bb7d575146f7002d81297
Author: dtseng@chromium.org
Commiter: dtseng@chromium.org
Date: 2019-01-14 18:34:13 +0000 UTC

Merge to m72: Only report attribute changes for menu list option when it is selected

TBR=dtseng@chromium.org

Bug:  914665 
Change-Id: I5e817024925603e2a146ce7d881b3d0f7ffdc1f0
Reviewed-on: https://chromium-review.googlesource.com/c/1377378
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#617871}(cherry picked from commit 7ad6601cebdb0f70493ffc0cfdc8d993836c3a91)
Reviewed-on: https://chromium-review.googlesource.com/c/1409352
Reviewed-by: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#669}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}

Comment 22 by dtseng@chromium.org, Today (9 hours ago)

 Issue 923559  has been merged into this issue.

Sign in to add a comment