New issue
Advanced search Search tips

Issue 914651 link

Starred by 1 user

Issue metadata

Status: Available
Owner:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----



Sign in to add a comment

base_unittests failing on multiple builders

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Dec 13

Issue description

Project Member

Comment 1 by bugdroid1@chromium.org, Dec 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5be1cd882f73600125f113a448ca471965b2d1f0

commit 5be1cd882f73600125f113a448ca471965b2d1f0
Author: Hitoshi Yoshida <peria@chromium.org>
Date: Thu Dec 13 03:01:44 2018

Revert "Make sure TypeId works with components"

This reverts commit ac076988a89fe54e2101c05c9f0dac05677796d8.

Reason for revert: base_unittests failing on Win 7/10

Original change's description:
> Make sure TypeId works with components
> 
> Make the dummy_var globally visible so that we only have one instance
> across all shared libraries, executables etc.
> 
> Bug: 906125
> Change-Id: I0aba75171ea3f55aa5440eb73a11713ed952f5bb
> Reviewed-on: https://chromium-review.googlesource.com/c/1367671
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Gabriel Charette <gab@chromium.org>
> Reviewed-by: Alex Clarke <alexclarke@chromium.org>
> Commit-Queue: Carlos Caballero <carlscab@google.com>
> Cr-Commit-Position: refs/heads/master@{#616120}

TBR=dcheng@chromium.org,gab@chromium.org,alexclarke@chromium.org,carlscab@google.com

Change-Id: I83f9b8d8c14b81317112d531cdd57b507149d324
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 906125, 914651
Reviewed-on: https://chromium-review.googlesource.com/c/1375293
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Commit-Queue: Hitoshi Yoshida <peria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616186}
[modify] https://crrev.com/5be1cd882f73600125f113a448ca471965b2d1f0/base/BUILD.gn
[modify] https://crrev.com/5be1cd882f73600125f113a448ca471965b2d1f0/base/test/BUILD.gn
[modify] https://crrev.com/5be1cd882f73600125f113a448ca471965b2d1f0/base/test/type_id_test_support_a.cc
[modify] https://crrev.com/5be1cd882f73600125f113a448ca471965b2d1f0/base/test/type_id_test_support_a.h
[modify] https://crrev.com/5be1cd882f73600125f113a448ca471965b2d1f0/base/test/type_id_test_support_b.cc
[modify] https://crrev.com/5be1cd882f73600125f113a448ca471965b2d1f0/base/test/type_id_test_support_b.h
[modify] https://crrev.com/5be1cd882f73600125f113a448ca471965b2d1f0/base/type_id.cc
[modify] https://crrev.com/5be1cd882f73600125f113a448ca471965b2d1f0/base/type_id.h
[modify] https://crrev.com/5be1cd882f73600125f113a448ca471965b2d1f0/base/type_id_unittest.cc

Owner: carlscab@google.com
https://chromium-review.googlesource.com/c/chromium/src/+/1367671 looks triggered this.
Labels: -Sheriff-Chromium
The issue is assigned and being worked on. Removing sheriff label.
Cc: -peria@chromium.org

Sign in to add a comment