New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 914642 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jan 8
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux , Chrome , Mac
Pri: 1
Type: ----



Sign in to add a comment

cc_unittests failing on multiple builders

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Dec 13

Issue description

Project Member

Comment 1 by bugdroid1@chromium.org, Dec 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f0ce3da3c67857a07008ba2155c14b5d47ac53ce

commit f0ce3da3c67857a07008ba2155c14b5d47ac53ce
Author: Hitoshi Yoshida <peria@chromium.org>
Date: Thu Dec 13 02:44:48 2018

Revert "viz: Do not send hit-test data unless it has been updated."

This reverts commit 5d1a299da673ba215bb76cb9cb116c0d46f05df0.

Reason for revert: cc_unittests failing on multiple builders

Original change's description:
> viz: Do not send hit-test data unless it has been updated.
> 
> Aggregation only occurs when new hit-test data has been
> submitted.
> 
> R=​rjkroege@chromium.org
> 
> Bug: 762251
> Change-Id: I589461c5928eaa00b028fc504e1e3590e1843796
> Reviewed-on: https://chromium-review.googlesource.com/c/1294838
> Commit-Queue: Alexander Shah <zandershah@google.com>
> Reviewed-by: Mitsuru Oshima (gardener - slow) <oshima@chromium.org>
> Reviewed-by: Avi Drissman <avi@chromium.org>
> Reviewed-by: danakj <danakj@chromium.org>
> Reviewed-by: Tom Sepez <tsepez@chromium.org>
> Reviewed-by: Ria Jiang <riajiang@chromium.org>
> Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#616135}

TBR=avi@chromium.org,rjkroege@chromium.org,danakj@chromium.org,oshima@chromium.org,tsepez@chromium.org,riajiang@chromium.org,zandershah@google.com

Change-Id: Icad5086a846890552af8734e315eeaa382923a8e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 762251,  914642 
Reviewed-on: https://chromium-review.googlesource.com/c/1375291
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Commit-Queue: Hitoshi Yoshida <peria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616178}
[modify] https://crrev.com/f0ce3da3c67857a07008ba2155c14b5d47ac53ce/ash/components/fast_ink/fast_ink_view.cc
[modify] https://crrev.com/f0ce3da3c67857a07008ba2155c14b5d47ac53ce/cc/mojo_embedder/async_layer_tree_frame_sink.cc
[modify] https://crrev.com/f0ce3da3c67857a07008ba2155c14b5d47ac53ce/cc/mojo_embedder/async_layer_tree_frame_sink.h
[modify] https://crrev.com/f0ce3da3c67857a07008ba2155c14b5d47ac53ce/cc/mojo_embedder/async_layer_tree_frame_sink_unittest.cc
[modify] https://crrev.com/f0ce3da3c67857a07008ba2155c14b5d47ac53ce/cc/test/fake_layer_tree_frame_sink.cc
[modify] https://crrev.com/f0ce3da3c67857a07008ba2155c14b5d47ac53ce/cc/test/fake_layer_tree_frame_sink.h
[modify] https://crrev.com/f0ce3da3c67857a07008ba2155c14b5d47ac53ce/cc/test/layer_tree_test.cc
[modify] https://crrev.com/f0ce3da3c67857a07008ba2155c14b5d47ac53ce/cc/trees/layer_tree_frame_sink.h
[modify] https://crrev.com/f0ce3da3c67857a07008ba2155c14b5d47ac53ce/cc/trees/layer_tree_frame_sink_unittest.cc
[modify] https://crrev.com/f0ce3da3c67857a07008ba2155c14b5d47ac53ce/cc/trees/layer_tree_host_impl.cc
[modify] https://crrev.com/f0ce3da3c67857a07008ba2155c14b5d47ac53ce/components/exo/layer_tree_frame_sink_holder.cc
[modify] https://crrev.com/f0ce3da3c67857a07008ba2155c14b5d47ac53ce/components/viz/common/hit_test/hit_test_region_list.cc
[modify] https://crrev.com/f0ce3da3c67857a07008ba2155c14b5d47ac53ce/components/viz/common/hit_test/hit_test_region_list.h
[modify] https://crrev.com/f0ce3da3c67857a07008ba2155c14b5d47ac53ce/components/viz/service/frame_sinks/direct_layer_tree_frame_sink.cc
[modify] https://crrev.com/f0ce3da3c67857a07008ba2155c14b5d47ac53ce/components/viz/service/frame_sinks/direct_layer_tree_frame_sink.h
[modify] https://crrev.com/f0ce3da3c67857a07008ba2155c14b5d47ac53ce/components/viz/service/frame_sinks/direct_layer_tree_frame_sink_unittest.cc
[modify] https://crrev.com/f0ce3da3c67857a07008ba2155c14b5d47ac53ce/components/viz/service/hit_test/hit_test_aggregator.cc
[modify] https://crrev.com/f0ce3da3c67857a07008ba2155c14b5d47ac53ce/components/viz/service/hit_test/hit_test_aggregator.h
[modify] https://crrev.com/f0ce3da3c67857a07008ba2155c14b5d47ac53ce/components/viz/service/hit_test/hit_test_aggregator_unittest.cc
[modify] https://crrev.com/f0ce3da3c67857a07008ba2155c14b5d47ac53ce/components/viz/service/hit_test/hit_test_manager.cc
[modify] https://crrev.com/f0ce3da3c67857a07008ba2155c14b5d47ac53ce/components/viz/service/hit_test/hit_test_manager.h
[modify] https://crrev.com/f0ce3da3c67857a07008ba2155c14b5d47ac53ce/components/viz/test/test_layer_tree_frame_sink.cc
[modify] https://crrev.com/f0ce3da3c67857a07008ba2155c14b5d47ac53ce/components/viz/test/test_layer_tree_frame_sink.h
[modify] https://crrev.com/f0ce3da3c67857a07008ba2155c14b5d47ac53ce/content/renderer/android/synchronous_layer_tree_frame_sink.cc
[modify] https://crrev.com/f0ce3da3c67857a07008ba2155c14b5d47ac53ce/content/renderer/android/synchronous_layer_tree_frame_sink.h
[modify] https://crrev.com/f0ce3da3c67857a07008ba2155c14b5d47ac53ce/services/viz/public/interfaces/compositing/compositor_frame_sink.mojom

Labels: OS-Chrome OS-Linux OS-Mac
Owner: zandershah@google.com
Revert https://chromium-review.googlesource.com/c/chromium/src/+/1294838 and assign Alex as an owner.
Labels: -Sheriff-Chromium
It has an owner and the offending patch was reverted. I am removing sheriff label.
Status: Fixed (was: Available)

Sign in to add a comment