Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of peria@chromium.org cc_unittests failing on multiple builders Builders failed on: - chromeos-amd64-generic-rel: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/chromeos-amd64-generic-rel - linux-chromeos-rel: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-rel - linux-xenial-rel: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-xenial-rel - Mac10.10 Tests: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.10%20Tests - Mac10.11 Tests: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.11%20Tests - Mac10.13 Tests: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.13%20Tests - Linux TSan Tests: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20TSan%20Tests
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f0ce3da3c67857a07008ba2155c14b5d47ac53ce commit f0ce3da3c67857a07008ba2155c14b5d47ac53ce Author: Hitoshi Yoshida <peria@chromium.org> Date: Thu Dec 13 02:44:48 2018 Revert "viz: Do not send hit-test data unless it has been updated." This reverts commit 5d1a299da673ba215bb76cb9cb116c0d46f05df0. Reason for revert: cc_unittests failing on multiple builders Original change's description: > viz: Do not send hit-test data unless it has been updated. > > Aggregation only occurs when new hit-test data has been > submitted. > > R=rjkroege@chromium.org > > Bug: 762251 > Change-Id: I589461c5928eaa00b028fc504e1e3590e1843796 > Reviewed-on: https://chromium-review.googlesource.com/c/1294838 > Commit-Queue: Alexander Shah <zandershah@google.com> > Reviewed-by: Mitsuru Oshima (gardener - slow) <oshima@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: danakj <danakj@chromium.org> > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Reviewed-by: Ria Jiang <riajiang@chromium.org> > Reviewed-by: Robert Kroeger <rjkroege@chromium.org> > Cr-Commit-Position: refs/heads/master@{#616135} TBR=avi@chromium.org,rjkroege@chromium.org,danakj@chromium.org,oshima@chromium.org,tsepez@chromium.org,riajiang@chromium.org,zandershah@google.com Change-Id: Icad5086a846890552af8734e315eeaa382923a8e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 762251, 914642 Reviewed-on: https://chromium-review.googlesource.com/c/1375291 Reviewed-by: Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#616178} [modify] https://crrev.com/f0ce3da3c67857a07008ba2155c14b5d47ac53ce/ash/components/fast_ink/fast_ink_view.cc [modify] https://crrev.com/f0ce3da3c67857a07008ba2155c14b5d47ac53ce/cc/mojo_embedder/async_layer_tree_frame_sink.cc [modify] https://crrev.com/f0ce3da3c67857a07008ba2155c14b5d47ac53ce/cc/mojo_embedder/async_layer_tree_frame_sink.h [modify] https://crrev.com/f0ce3da3c67857a07008ba2155c14b5d47ac53ce/cc/mojo_embedder/async_layer_tree_frame_sink_unittest.cc [modify] https://crrev.com/f0ce3da3c67857a07008ba2155c14b5d47ac53ce/cc/test/fake_layer_tree_frame_sink.cc [modify] https://crrev.com/f0ce3da3c67857a07008ba2155c14b5d47ac53ce/cc/test/fake_layer_tree_frame_sink.h [modify] https://crrev.com/f0ce3da3c67857a07008ba2155c14b5d47ac53ce/cc/test/layer_tree_test.cc [modify] https://crrev.com/f0ce3da3c67857a07008ba2155c14b5d47ac53ce/cc/trees/layer_tree_frame_sink.h [modify] https://crrev.com/f0ce3da3c67857a07008ba2155c14b5d47ac53ce/cc/trees/layer_tree_frame_sink_unittest.cc [modify] https://crrev.com/f0ce3da3c67857a07008ba2155c14b5d47ac53ce/cc/trees/layer_tree_host_impl.cc [modify] https://crrev.com/f0ce3da3c67857a07008ba2155c14b5d47ac53ce/components/exo/layer_tree_frame_sink_holder.cc [modify] https://crrev.com/f0ce3da3c67857a07008ba2155c14b5d47ac53ce/components/viz/common/hit_test/hit_test_region_list.cc [modify] https://crrev.com/f0ce3da3c67857a07008ba2155c14b5d47ac53ce/components/viz/common/hit_test/hit_test_region_list.h [modify] https://crrev.com/f0ce3da3c67857a07008ba2155c14b5d47ac53ce/components/viz/service/frame_sinks/direct_layer_tree_frame_sink.cc [modify] https://crrev.com/f0ce3da3c67857a07008ba2155c14b5d47ac53ce/components/viz/service/frame_sinks/direct_layer_tree_frame_sink.h [modify] https://crrev.com/f0ce3da3c67857a07008ba2155c14b5d47ac53ce/components/viz/service/frame_sinks/direct_layer_tree_frame_sink_unittest.cc [modify] https://crrev.com/f0ce3da3c67857a07008ba2155c14b5d47ac53ce/components/viz/service/hit_test/hit_test_aggregator.cc [modify] https://crrev.com/f0ce3da3c67857a07008ba2155c14b5d47ac53ce/components/viz/service/hit_test/hit_test_aggregator.h [modify] https://crrev.com/f0ce3da3c67857a07008ba2155c14b5d47ac53ce/components/viz/service/hit_test/hit_test_aggregator_unittest.cc [modify] https://crrev.com/f0ce3da3c67857a07008ba2155c14b5d47ac53ce/components/viz/service/hit_test/hit_test_manager.cc [modify] https://crrev.com/f0ce3da3c67857a07008ba2155c14b5d47ac53ce/components/viz/service/hit_test/hit_test_manager.h [modify] https://crrev.com/f0ce3da3c67857a07008ba2155c14b5d47ac53ce/components/viz/test/test_layer_tree_frame_sink.cc [modify] https://crrev.com/f0ce3da3c67857a07008ba2155c14b5d47ac53ce/components/viz/test/test_layer_tree_frame_sink.h [modify] https://crrev.com/f0ce3da3c67857a07008ba2155c14b5d47ac53ce/content/renderer/android/synchronous_layer_tree_frame_sink.cc [modify] https://crrev.com/f0ce3da3c67857a07008ba2155c14b5d47ac53ce/content/renderer/android/synchronous_layer_tree_frame_sink.h [modify] https://crrev.com/f0ce3da3c67857a07008ba2155c14b5d47ac53ce/services/viz/public/interfaces/compositing/compositor_frame_sink.mojom
Revert https://chromium-review.googlesource.com/c/chromium/src/+/1294838 and assign Alex as an owner.
It has an owner and the offending patch was reverted. I am removing sheriff label.
Comment 1 by bugdroid1@chromium.org
, Dec 13