sizes failing on chromium.chrome/Google Chrome Linux x64 |
|||||||||||||
Issue descriptionFiled by sheriff-o-matic@appspot.gserviceaccount.com on behalf of peria@chromium.org sizes failing on chromium.chrome/Google Chrome Linux x64 Builders failed on: - Google Chrome Linux x64: https://ci.chromium.org/buildbot/chromium.chrome/Google%20Chrome%20Linux%20x64 since build 38623 https://ci.chromium.org/buildbot/chromium.chrome/Google%20Chrome%20Linux%20x64/38623
,
Dec 13
Seems forbidden come from perf dashboard. dpranke, who is current owner of perf dashboard?
,
Dec 13
,
Dec 13
Good question, I'm not sure who we'd consider the owner of this at the moment. +jparent, thoughts? Regardless, I have the ability to update the IP whitelist, so I've added this machine to that and hopefully that'll green up now (or at least we'll be on to the next issue ;).
,
Dec 13
+benjhayden is the owner of perf dashboard, part of +seanmccullough's team.
,
Dec 13
Hm, the machine should be whitelisted, but we're still getting 403s, I'm not sure why. @benjhayden, over to you, I guess?
,
Dec 13
_SendResultsJson posts to /add_point. 192.168.110.178 is the ip for build47-m1. I don't see any logs containing that ip. Which ip should I be looking for? +bsheedy who is working on getting sizes to work on luci with add_histograms and who understands sizes better than I.
,
Dec 13
It looks like build47-m1 is in the Golo, so I'm guessing 192.168.110.178 is its internal IP within that. I assume the external IP is what should be whitelisted, although I'm not sure where to find that. AFAIK this shouldn't be directly related to sizes, rather it's a general issue with trying to upload to the perf dashboard from this bot.
,
Dec 13
Thanks, bsheedy! tikuta: what is the external ip for that golo? I'd be happy to whitelist it.
,
Dec 13
+labs folk, do you know external ip address of build47-m1?
,
Dec 13
I'm told it doesn't have one because it runs in the golo, and that it wouldn't be a good idea to add the golo's external IP to the whitelist because lots of people can run arbitrary code in the golo, but I can add it temporarily if somebody can find it for me. bsheedy is working on getting sizes to run on luci and upload using add_histograms with oauth instead of add_point with the ip whitelist.
,
Dec 13
I'm still confused why this is happening in the first place. If the Golo isn't/shouldn't be whitelisted, what was whitelisted to make this work before? The internal IP hasn't changed - there's only been one change to the dhcpd settings recently, and it didn't touch the bot in question https://chrome-internal.googlesource.com/chrome-golo/chrome-golo/+/b0da524f8c7dc1572c0405efd605179e4cff0c7d
,
Dec 14
AFAIK, we also have lots of other machines in the golo talking to the perf dashboard (or at least we used to), so I'm not sure what would be special about this particular address.
,
Dec 14
+iannucci suggested offline that the sizes step had been chronically silently failing and might have just started surfacing its failure? There are lots of add_point 403s in the logs so I don't know which entries might be related to this issue without knowing the golo's external IP. If we want to get creative, maybe somebody could ssh into the bot and manually post an empty request to /add_point?debug=914639 to make it easier to find in the logs? I need to sign off for the day now.
,
Dec 14
,
Dec 14
Theres been a new IP added into our NAT IP pool this week to address timeouts due to too many connections. A PSA was sent back in November to update your whitelists to prevent such issues: https://groups.google.com/a/google.com/d/msg/chrome-infrastructure-announce/rWdgVAGEC7k/2rUeBaywAwAJ
,
Dec 14
Thanks! I'll add those IPs to the whitelist now.
,
Dec 14
Done. |
|||||||||||||
►
Sign in to add a comment |
|||||||||||||
Comment 1 by peria@chromium.org
, Dec 13Owner: tikuta@chromium.org
Status: Assigned (was: Available)