New issue
Advanced search Search tips

Issue 914630 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 14
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 909848



Sign in to add a comment

Remove unused 'depend_on' functionality from recipe engine

Project Member Reported by iannu...@google.com, Dec 13

Issue description

This will also interfere with build.proto/parallel steps implementation (it would need to be updated to accommodate build.proto, but it's easier to just remove it for now)
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 14

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/recipes-py/+/a42e8c4de53e8dd05042bac03f24a86e87abe4a3

commit a42e8c4de53e8dd05042bac03f24a86e87abe4a3
Author: Robert Iannucci <iannucci@chromium.org>
Date: Fri Dec 14 23:29:42 2018

[depend_on] Remove "depend_on" functionality.

This wasn't ever used (:'C), so it's best to remove to unclutter things
before build.proto integration.

R=jchinlee@chromium.org, martiniss@chromium.org, nodir@chromium.org

Bug:  914630 
Change-Id: Iac444f9c9821cbde238d8e99c00541b16f26514e
Reviewed-on: https://chromium-review.googlesource.com/c/1375071
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Reviewed-by: Jao-ke Chin-Lee <jchinlee@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>

[delete] https://crrev.com/f1230fc4dd13e325a540bd70afba35674e605100/recipes/engine_tests/depend_on/top.py
[delete] https://crrev.com/f1230fc4dd13e325a540bd70afba35674e605100/recipes/engine_tests/depend_on/dont_need_properties.expected/basic.json
[delete] https://crrev.com/f1230fc4dd13e325a540bd70afba35674e605100/recipes/engine_tests/depend_on/dont_need_properties_helper.expected/basic.json
[delete] https://crrev.com/f1230fc4dd13e325a540bd70afba35674e605100/recipes/engine_tests/depend_on/bad_properties.py
[delete] https://crrev.com/f1230fc4dd13e325a540bd70afba35674e605100/recipes/engine_tests/depend_on/no_return.py
[delete] https://crrev.com/f1230fc4dd13e325a540bd70afba35674e605100/recipes/engine_tests/depend_on/need_return_schema.py
[delete] https://crrev.com/f1230fc4dd13e325a540bd70afba35674e605100/recipes/engine_tests/depend_on/need_return_schema_helper.expected/basic.json
[modify] https://crrev.com/a42e8c4de53e8dd05042bac03f24a86e87abe4a3/README.recipes.md
[modify] https://crrev.com/a42e8c4de53e8dd05042bac03f24a86e87abe4a3/recipe_engine/step_runner.py
[modify] https://crrev.com/a42e8c4de53e8dd05042bac03f24a86e87abe4a3/recipe_engine/recipe_test_api.py
[delete] https://crrev.com/f1230fc4dd13e325a540bd70afba35674e605100/recipes/engine_tests/depend_on/no_return.expected/basic.json
[modify] https://crrev.com/a42e8c4de53e8dd05042bac03f24a86e87abe4a3/recipe_engine/unittests/run_test.py
[delete] https://crrev.com/f1230fc4dd13e325a540bd70afba35674e605100/recipes/engine_tests/depend_on/bottom.expected/basic.json
[delete] https://crrev.com/f1230fc4dd13e325a540bd70afba35674e605100/recipes/engine_tests/depend_on/top.expected/basic.json
[delete] https://crrev.com/f1230fc4dd13e325a540bd70afba35674e605100/recipes/engine_tests/depend_on/need_return_schema_helper.py
[delete] https://crrev.com/f1230fc4dd13e325a540bd70afba35674e605100/recipes/engine_tests/depend_on/bad_properties.expected/basic.json
[modify] https://crrev.com/a42e8c4de53e8dd05042bac03f24a86e87abe4a3/recipe_engine/run.py
[delete] https://crrev.com/f1230fc4dd13e325a540bd70afba35674e605100/recipes/engine_tests/depend_on/need_return_schema.expected/basic.json
[delete] https://crrev.com/f1230fc4dd13e325a540bd70afba35674e605100/recipes/engine_tests/depend_on/dont_need_properties.py
[delete] https://crrev.com/f1230fc4dd13e325a540bd70afba35674e605100/recipes/engine_tests/depend_on/bottom.py
[delete] https://crrev.com/f1230fc4dd13e325a540bd70afba35674e605100/recipes/engine_tests/depend_on/dont_need_properties_helper.py
[modify] https://crrev.com/a42e8c4de53e8dd05042bac03f24a86e87abe4a3/recipe_engine/recipe_api.py

Status: Fixed (was: Untriaged)

Sign in to add a comment