New issue
Advanced search Search tips

Issue 914629 link

Starred by 0 users
Status: Fixed
Owner:
iannu...@google.com
Closed: Dec 14
Cc:
iannu...@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 909848



Sign in to add a comment

Remove ancient annotation.proto support from recipe engine

Project Member Reported by iannu...@google.com, Dec 13 
This was an aborted attempt to have the recipe engine stream annotation.proto, but it never took off. The code is unfortunately not usable for the build.proto support (as it is intrinsically tied to the @@@annotation@@@ protocol, just with a different face).

Comment 1 by iannu...@google.com, Dec 13

Owner: iannu...@google.com
Status: Assigned (was: Untriaged)

Comment 2 by iannu...@google.com, Dec 13

Components: Infra>Platform>Recipes
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 14 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/recipes-py/+/f1230fc4dd13e325a540bd70afba35674e605100

commit f1230fc4dd13e325a540bd70afba35674e605100
Author: Robert Iannucci <iannucci@chromium.org>
Date: Fri Dec 14 22:51:51 2018

[stream_logdog] Remove old unused annotations.proto support.

R=jchinlee@chromium.org, martiniss@chromium.org, nodir@chromium.org

Bug:  914629 
Change-Id: I95e2b2ce4a6b075cf2dc25770579ca52fe37c6c8
Reviewed-on: https://chromium-review.googlesource.com/c/1375014
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Reviewed-by: Jao-ke Chin-Lee <jchinlee@chromium.org>

[modify] https://crrev.com/f1230fc4dd13e325a540bd70afba35674e605100/recipe_engine/arguments.proto
[delete] https://crrev.com/0cbbe4a2a8b0a309f08b5a5459292885e8e1ce07/recipe_engine/third_party/annotations_pb2.py
[delete] https://crrev.com/0cbbe4a2a8b0a309f08b5a5459292885e8e1ce07/recipe_engine/unittests/stream_logdog_test.py
[delete] https://crrev.com/0cbbe4a2a8b0a309f08b5a5459292885e8e1ce07/recipe_engine/stream_logdog.py
[modify] https://crrev.com/f1230fc4dd13e325a540bd70afba35674e605100/recipe_engine/run.py
[modify] https://crrev.com/f1230fc4dd13e325a540bd70afba35674e605100/recipe_engine/unittests/stream_test.py
[modify] https://crrev.com/f1230fc4dd13e325a540bd70afba35674e605100/recipe_engine/stream.py
[delete] https://crrev.com/0cbbe4a2a8b0a309f08b5a5459292885e8e1ce07/recipe_engine/annotations_pb2.py
[delete] https://crrev.com/0cbbe4a2a8b0a309f08b5a5459292885e8e1ce07/recipe_engine/annotations.proto

Comment 4 by iannu...@google.com, Dec 14

Status: Fixed (was: Assigned)
►

Sign in to add a comment