New issue
Advanced search Search tips

Issue 914616 link

Starred by 3 users
Status: Fixed
Owner:
nverne@chromium.org
Closed: Jan 8
Cc:
joelhockey@chromium.org
smbar...@chromium.org
tbuck...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 878324



Sign in to add a comment

Chrome: use async for StartLxdContainer method

Project Member Reported by smbar...@chromium.org, Dec 13 
Issue 911333 tracks transitioning cicerone and tremplin to call StartLxdContainer asynchronously.

New API is here: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/1375091

Chrome should pass in true for the async flag in StartLxdContainerRequest. The two new interesting return statuses from this method are:

STARTING - the container is starting. It will be ready for SetUpUser after LxdContainerStartingSignal(Status=STARTED) is received.

REMAPPING - the container is starting but must remap its rootfs ids. This can take a long time, maybe minutes on slow devices or devices with a lot of Crostini state. We'll need to put up a dialog or something while this happens. The container will be ready for SetUpUser when LxdContainerStartingSignal(Status=STARTED) is received.


Initially assigning to Nick to find an owner.
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 7 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5e75c4b3211ce0f7964fd7b1b1d603db1853c940

commit 5e75c4b3211ce0f7964fd7b1b1d603db1853c940
Author: Nicholas Verne <nverne@chromium.org>
Date: Mon Jan 07 11:24:55 2019

Supports the new async StartLxdContainer flow.

Because container startup can now be delayed by long-running process such as
file uid remapping, we may need to wait for the new LxdContainerStarting signal.

Bug:  914616 
Change-Id: I27c4feace692a494dc9a14a2fdbe501a99b492f5
Reviewed-on: https://chromium-review.googlesource.com/c/1396013
Reviewed-by: Timothy Loh <timloh@chromium.org>
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Commit-Queue: Nicholas Verne <nverne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#620289}
[modify] https://crrev.com/5e75c4b3211ce0f7964fd7b1b1d603db1853c940/chrome/browser/chromeos/crostini/crostini_manager.cc
[modify] https://crrev.com/5e75c4b3211ce0f7964fd7b1b1d603db1853c940/chrome/browser/chromeos/crostini/crostini_manager.h
[modify] https://crrev.com/5e75c4b3211ce0f7964fd7b1b1d603db1853c940/chromeos/dbus/cicerone_client.cc
[modify] https://crrev.com/5e75c4b3211ce0f7964fd7b1b1d603db1853c940/chromeos/dbus/cicerone_client.h
[modify] https://crrev.com/5e75c4b3211ce0f7964fd7b1b1d603db1853c940/chromeos/dbus/fake_cicerone_client.cc
[modify] https://crrev.com/5e75c4b3211ce0f7964fd7b1b1d603db1853c940/chromeos/dbus/fake_cicerone_client.h

Comment 2 by nverne@chromium.org, Jan 8

Status: Fixed (was: Assigned)
►

Sign in to add a comment