Findit identified the culprit r616039 as introducing flaky test(s) summarized in https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vMmRjMDg4M2RiNmY0NDgzMTNjZGRmNmI5MjVlMDJiYTFjZWQwNjAyMAw Please revert the culprit, or disable the test(s) and find the appropriate owner to fix or delete. If the culprit above is wrong, please file a bug using this link: https://bugs.chromium.org/p/chromium/issues/entry?status=Unconfirmed&labels=Pri-1,Test-Findit-Wrong&components=Tools%3ETest%3EFindit%3EFlakiness&summary=%5BFindit%5D%20Flake%20Analyzer%20-%20Wrong%20culprit%20r616039&comment=Link%20to%20Culprit%3A%20https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vMmRjMDg4M2RiNmY0NDgzMTNjZGRmNmI5MjVlMDJiYTFjZWQwNjAyMAw Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N).
Seems to me that simply too aggressive test timeouts have been picked.
What's the plan for this issue? Should we revert the patch?
Issue 914657 has been merged into this issue.
I am merging two other flakes to this one. They are caused by the same CL.
Reverted by: https://chromium-review.googlesource.com/c/chromium/src/+/1376097 Removing sheriff label.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/df0c29b1fc457224e68af2085835334470da264a commit df0c29b1fc457224e68af2085835334470da264a Author: Nicolas Ouellet-payeur <nicolaso@chromium.org> Date: Mon Dec 17 17:24:23 2018 Reland "[BrowserSwitcher] Add BrowserSwitcherExternalSitelistUrl policy" This is a reland of 2dc0883db6f448313cddf6b925e02ba1ced06020 Original change's description: > [BrowserSwitcher] Add BrowserSwitcherExternalSitelistUrl policy > > This policy behaves a lot like BrowserSwitcherUseIeSitelist, except it > can point to a different URL than the one IE uses. > > Bug: 846316 > Change-Id: I52f91019aabcdd9b20163198195770fb52183e98 > Reviewed-on: https://chromium-review.googlesource.com/c/1361327 > Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> > Reviewed-by: Ramin Halavati <rhalavati@chromium.org> > Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org> > Cr-Commit-Position: refs/heads/master@{#616039} TBR=rhalavati@chromium.org Bug: 846316 , 914611 Change-Id: If8421e620c95eb2bdb4ab2d5d9d1a3a71c2390eb Reviewed-on: https://chromium-review.googlesource.com/c/1377135 Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#617146} [modify] https://crrev.com/df0c29b1fc457224e68af2085835334470da264a/chrome/browser/browser_switcher/browser_switcher_prefs.cc [modify] https://crrev.com/df0c29b1fc457224e68af2085835334470da264a/chrome/browser/browser_switcher/browser_switcher_prefs.h [modify] https://crrev.com/df0c29b1fc457224e68af2085835334470da264a/chrome/browser/browser_switcher/browser_switcher_service.cc [modify] https://crrev.com/df0c29b1fc457224e68af2085835334470da264a/chrome/browser/browser_switcher/browser_switcher_service.h [modify] https://crrev.com/df0c29b1fc457224e68af2085835334470da264a/chrome/browser/browser_switcher/browser_switcher_service_browsertest.cc [modify] https://crrev.com/df0c29b1fc457224e68af2085835334470da264a/chrome/browser/policy/configuration_policy_handler_list_factory.cc [modify] https://crrev.com/df0c29b1fc457224e68af2085835334470da264a/chrome/test/BUILD.gn [modify] https://crrev.com/df0c29b1fc457224e68af2085835334470da264a/chrome/test/data/policy/policy_test_cases.json [modify] https://crrev.com/df0c29b1fc457224e68af2085835334470da264a/components/policy/resources/policy_templates.json [modify] https://crrev.com/df0c29b1fc457224e68af2085835334470da264a/tools/metrics/histograms/enums.xml [modify] https://crrev.com/df0c29b1fc457224e68af2085835334470da264a/tools/traffic_annotation/summary/annotations.xml
Comment 1 by pastarmovj@chromium.org
, Dec 13Owner: nicolaso@chromium.org