[Autofill Sync] Dropdown disappears after opt-in |
|||||||
Issue descriptionAfter the fix made for crbug.com/914065 , a small UI error persists. Specifically, the dropdown disappears upon clicking the opt-in prompt. Instead, the dropdown should remain, and should be populated with the values of the cards which are now eligible for display.
,
Dec 17
,
Dec 17
Verified this in Canary this AM. Requesting merge to M-72. This concludes the implementation of UI elements in the Autofill dropdown for Sync Transport, which accommodate recent concerns by privacy reviewers about consent/disclosure, and which respond to action items on the same topic in a recent postmortem. In terms of risk, the CL is straightforward; it introduces one new method and a small branch to call that method at the end of our event handler instead of closing the dropdown, under very narrow conditions that are tied to the Sync Transport launch/flag.
,
Dec 17
This bug requires manual review: M72 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 17
,
Dec 17
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/53c0b9af9c301450a8f2e4078197323b3d2aabcb commit 53c0b9af9c301450a8f2e4078197323b3d2aabcb Author: Tommy Martino <tmartino@chromium.org> Date: Mon Dec 17 18:53:04 2018 [Merge 72][Autofill Sync] Make dropdown reappear after opt-in Currently, the dropdown disappears upon selecting the new opt-in row. Instead of hiding as we do with other suggestion types, we will now fetch credit card suggestions again and re-show the dropdown. TBR=sebsg@chromium.org Bug: 914609 Change-Id: I032c5a062a5251d442ad25ea85a99da41b3f9a77 Reviewed-on: https://chromium-review.googlesource.com/c/1374464 Commit-Queue: Tommy Martino <tmartino@chromium.org> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#616439}(cherry picked from commit c7c24143ee1e6ed190eb6095f7e89951e8932452) Reviewed-on: https://chromium-review.googlesource.com/c/1380573 Reviewed-by: Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#394} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} [modify] https://crrev.com/53c0b9af9c301450a8f2e4078197323b3d2aabcb/components/autofill/core/browser/autofill_external_delegate.cc [modify] https://crrev.com/53c0b9af9c301450a8f2e4078197323b3d2aabcb/components/autofill/core/browser/autofill_manager.cc [modify] https://crrev.com/53c0b9af9c301450a8f2e4078197323b3d2aabcb/components/autofill/core/browser/autofill_manager.h
,
Dec 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/53c0b9af9c301450a8f2e4078197323b3d2aabcb Commit: 53c0b9af9c301450a8f2e4078197323b3d2aabcb Author: tmartino@chromium.org Commiter: tmartino@chromium.org Date: 2018-12-17 18:53:04 +0000 UTC [Merge 72][Autofill Sync] Make dropdown reappear after opt-in Currently, the dropdown disappears upon selecting the new opt-in row. Instead of hiding as we do with other suggestion types, we will now fetch credit card suggestions again and re-show the dropdown. TBR=sebsg@chromium.org Bug: 914609 Change-Id: I032c5a062a5251d442ad25ea85a99da41b3f9a77 Reviewed-on: https://chromium-review.googlesource.com/c/1374464 Commit-Queue: Tommy Martino <tmartino@chromium.org> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#616439}(cherry picked from commit c7c24143ee1e6ed190eb6095f7e89951e8932452) Reviewed-on: https://chromium-review.googlesource.com/c/1380573 Reviewed-by: Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#394} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by bugdroid1@chromium.org
, Dec 13