New issue
Advanced search Search tips

Issue 914599 link

Starred by 1 user
Status: Fixed
Owner:
bsheedy@chromium.org
Closed: Dec 17
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug
Proj-VR
Proj-XR



Sign in to add a comment

Change how XR browser tests are conditionally run

Project Member Reported by bsheedy@chromium.org, Dec 13 
Most of the XR browser tests have hardware requirements that prevent them from running on most Windows machines that are available on swarming. To get around this, most of the tests are currently marked as disabled and we pass --gtest_also_run_disabled_tests and a specific test filter when we want to run them.

This has caused confusion for multiple people that aren't familiar with the tests, and it also prevents results from showing up on the flakiness dashboard since results for disabled tests aren't reported.

Instead, we should look into some other solution for skipping the tests conditionally, or at the very least, having them pass immediately on unsupported hardware configurations.
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 17 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2c32a37413cd94a16273ba4777638101156efe1b

commit 2c32a37413cd94a16273ba4777638101156efe1b
Author: bsheedy <bsheedy@chromium.org>
Date: Mon Dec 17 22:10:06 2018

Split XR browser tests

Splits the XR browser tests out from the main browser_tests target into
its own test target. This removes the need to disable the tests by
default and use --gtest_also_run_disabled_tests in order to ensure that
the tests only run on machines that meet the hardware requirements.

Bug:  914599 
Change-Id: I03d339519d8ef13992e2ee308c109c3880399bd9
Reviewed-on: https://chromium-review.googlesource.com/c/1375095
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Bill Orr <billorr@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617248}
[modify] https://crrev.com/2c32a37413cd94a16273ba4777638101156efe1b/chrome/browser/vr/BUILD.gn
[modify] https://crrev.com/2c32a37413cd94a16273ba4777638101156efe1b/chrome/browser/vr/test/xr_browser_test.h
[modify] https://crrev.com/2c32a37413cd94a16273ba4777638101156efe1b/chrome/browser/vr/test/xr_browser_tests.md
[modify] https://crrev.com/2c32a37413cd94a16273ba4777638101156efe1b/chrome/browser/vr/webxr_vr_frame_pose_browser_test.cc
[modify] https://crrev.com/2c32a37413cd94a16273ba4777638101156efe1b/chrome/browser/vr/webxr_vr_input_browser_test.cc
[modify] https://crrev.com/2c32a37413cd94a16273ba4777638101156efe1b/chrome/browser/vr/webxr_vr_pixel_browser_test.cc
[modify] https://crrev.com/2c32a37413cd94a16273ba4777638101156efe1b/chrome/browser/vr/webxr_vr_tab_browser_test.cc
[modify] https://crrev.com/2c32a37413cd94a16273ba4777638101156efe1b/chrome/browser/vr/webxr_vr_transition_browser_test.cc
[modify] https://crrev.com/2c32a37413cd94a16273ba4777638101156efe1b/chrome/test/BUILD.gn
[modify] https://crrev.com/2c32a37413cd94a16273ba4777638101156efe1b/testing/buildbot/chromium.gpu.fyi.json
[modify] https://crrev.com/2c32a37413cd94a16273ba4777638101156efe1b/testing/buildbot/chromium.gpu.json
[modify] https://crrev.com/2c32a37413cd94a16273ba4777638101156efe1b/testing/buildbot/gn_isolate_map.pyl
[modify] https://crrev.com/2c32a37413cd94a16273ba4777638101156efe1b/testing/buildbot/test_suites.pyl

Comment 2 by bsheedy@chromium.org, Dec 17

Status: Fixed (was: Assigned)
►

Sign in to add a comment