New issue
Advanced search Search tips

Issue 914587 link

Starred by 2 users

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug

Blocked on:
issue 922318

Blocking:
issue 804504



Sign in to add a comment

Get rid of NavigationScheduler, maybe.

Project Member Reported by japhet@chromium.org, Dec 13

Issue description

NavigationScheduler exists to start navigations asynchronously. This mattered a lot when blink was managing all the navigation start locally. Now that PlzNavigate is shipped, most of these cases could get shipped off to the browser process synchronously.

This probably requires adding a different way to make about:blank navigations async, since currently DocumentLoader handles them synchronously and we don't send them to the browser process. Resolving that has the added benefit of removing the loophole that clicking a link to about:blank doesn't go through NavigationScheduler, and therefore can happen entirely synchronously.

We may need to leave something in place for meta redirects and refersh headers, but that's at least a much smaller set of cases than the current model of needing NavgationScheduler for any content-initiated navigation.
 
Does this have a conflicted goal with 638435?
re #c2: I don't think these two conflict.

Issue 638435 wants to make more navigations async.

This issue says that we already navigate mostly async, and additional scheduling in NavigationScheduler is not needed most of the time. Ideally, we should make everything async and using the same mechanism.
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a10f3d55afe4e7e0c105aa12f030bc010d0e69a0

commit a10f3d55afe4e7e0c105aa12f030bc010d0e69a0
Author: Nate Chapin <japhet@chromium.org>
Date: Mon Dec 17 20:05:26 2018

Make empty documents load async (for the most part)

This exempts two cases:
1. The initial empty document (because everything assumes that it's
   sync, and it's not supposed to be web-observable anyway)
2. A navigation from the initial empty document to a regular empty
   document (because this was the case that was the vast majority of
   test breakages, and it's not clear how much benefit we get from
   making that case async)

Bug: 914587
Change-Id: Ic99e9a3adc99640a47308036ff3a3d04e2d30795
Reviewed-on: https://chromium-review.googlesource.com/c/1372277
Commit-Queue: Nate Chapin <japhet@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617198}
[modify] https://crrev.com/a10f3d55afe4e7e0c105aa12f030bc010d0e69a0/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/a10f3d55afe4e7e0c105aa12f030bc010d0e69a0/content/renderer/render_frame_impl.h
[modify] https://crrev.com/a10f3d55afe4e7e0c105aa12f030bc010d0e69a0/content/renderer/render_view_browsertest.cc
[modify] https://crrev.com/a10f3d55afe4e7e0c105aa12f030bc010d0e69a0/third_party/blink/public/web/web_document_loader.h
[modify] https://crrev.com/a10f3d55afe4e7e0c105aa12f030bc010d0e69a0/third_party/blink/public/web/web_navigation_control.h
[modify] https://crrev.com/a10f3d55afe4e7e0c105aa12f030bc010d0e69a0/third_party/blink/renderer/core/exported/web_document_loader_impl.cc
[modify] https://crrev.com/a10f3d55afe4e7e0c105aa12f030bc010d0e69a0/third_party/blink/renderer/core/frame/web_local_frame_impl.cc
[modify] https://crrev.com/a10f3d55afe4e7e0c105aa12f030bc010d0e69a0/third_party/blink/renderer/core/frame/web_local_frame_impl.h
[modify] https://crrev.com/a10f3d55afe4e7e0c105aa12f030bc010d0e69a0/third_party/blink/renderer/core/loader/document_loader.cc
[modify] https://crrev.com/a10f3d55afe4e7e0c105aa12f030bc010d0e69a0/third_party/blink/renderer/core/loader/document_loader.h
[modify] https://crrev.com/a10f3d55afe4e7e0c105aa12f030bc010d0e69a0/third_party/blink/renderer/core/loader/frame_loader.cc
[modify] https://crrev.com/a10f3d55afe4e7e0c105aa12f030bc010d0e69a0/third_party/blink/renderer/core/loader/frame_loader.h
[delete] https://crrev.com/8e01f6a4bfe0171b14b6036550fc41d7c18b2e97/third_party/blink/web_tests/external/wpt/html/webappapis/scripting/events/compile-event-handler-settings-objects-expected.txt
[modify] https://crrev.com/a10f3d55afe4e7e0c105aa12f030bc010d0e69a0/third_party/blink/web_tests/http/tests/security/synchronous-frame-load-in-javascript-url-inherits-correct-origin.html
[modify] https://crrev.com/a10f3d55afe4e7e0c105aa12f030bc010d0e69a0/third_party/blink/web_tests/inspector-protocol/runtime/runtime-console-log-handle-navigate-expected.txt
[modify] https://crrev.com/a10f3d55afe4e7e0c105aa12f030bc010d0e69a0/third_party/blink/web_tests/inspector-protocol/runtime/runtime-console-log-handle-navigate.js

Project Member

Comment 5 by bugdroid1@chromium.org, Dec 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/48edb46b3aa0e066384d45ca8f21fec313144b72

commit 48edb46b3aa0e066384d45ca8f21fec313144b72
Author: Nate Chapin <japhet@chromium.org>
Date: Mon Dec 17 23:22:21 2018

Remove NavigationScheduler::ScheduleReload

Now that PlzNavigate is shipped, reload is limited to what it can do
synchronously. It's probably safe to go straight to StartNavigation().

Bug: 914587
Change-Id: I81bd699862576743091b8765f69b20968a28d14f
Reviewed-on: https://chromium-review.googlesource.com/c/1366771
Commit-Queue: Nate Chapin <japhet@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617277}
[modify] https://crrev.com/48edb46b3aa0e066384d45ca8f21fec313144b72/content/browser/site_per_process_browsertest.cc
[modify] https://crrev.com/48edb46b3aa0e066384d45ca8f21fec313144b72/third_party/blink/renderer/core/frame/local_frame.cc
[modify] https://crrev.com/48edb46b3aa0e066384d45ca8f21fec313144b72/third_party/blink/renderer/core/loader/navigation_scheduler.cc
[modify] https://crrev.com/48edb46b3aa0e066384d45ca8f21fec313144b72/third_party/blink/renderer/core/loader/navigation_scheduler.h
[modify] https://crrev.com/48edb46b3aa0e066384d45ca8f21fec313144b72/third_party/blink/web_tests/bindings/blink-in-js-asan-crash-expected.txt
[modify] https://crrev.com/48edb46b3aa0e066384d45ca8f21fec313144b72/third_party/blink/web_tests/fast/css/reload-non-styled-element-crash.html
[modify] https://crrev.com/48edb46b3aa0e066384d45ca8f21fec313144b72/third_party/blink/web_tests/fast/css/resources/counter-crash-frame-src.html
[modify] https://crrev.com/48edb46b3aa0e066384d45ca8f21fec313144b72/third_party/blink/web_tests/fast/forms/form-associated-element-crash2.html
[add] https://crrev.com/48edb46b3aa0e066384d45ca8f21fec313144b72/third_party/blink/web_tests/fast/loader/about-blank-reload.html
[modify] https://crrev.com/48edb46b3aa0e066384d45ca8f21fec313144b72/third_party/blink/web_tests/http/tests/cache/reload-main-resource.php
[modify] https://crrev.com/48edb46b3aa0e066384d45ca8f21fec313144b72/third_party/blink/web_tests/http/tests/inspector-protocol/page/frameScheduledNavigation-expected.txt
[modify] https://crrev.com/48edb46b3aa0e066384d45ca8f21fec313144b72/third_party/blink/web_tests/http/tests/inspector-protocol/page/frameScheduledNavigation.js
[modify] https://crrev.com/48edb46b3aa0e066384d45ca8f21fec313144b72/third_party/blink/web_tests/http/tests/inspector-protocol/page/resources/navigation-chain3.pl

Project Member

Comment 6 by bugdroid1@chromium.org, Dec 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/28462581f60f8df172b5859aa3468c447b37f777

commit 28462581f60f8df172b5859aa3468c447b37f777
Author: Nate Chapin <japhet@chromium.org>
Date: Tue Dec 18 22:15:00 2018

Make probe::frameScheduledNavigation not depend on ScheduledNavigation

I'm in the process of removing ScheduledNavigation, but we still need this
probe.

Also, add back in the probe for reloads, which no longer go through
ScheduledNavigation.

Bug: 914587
Change-Id: Ie0c128a4f692bcfe05a62df6f214226260d45dfd
Reviewed-on: https://chromium-review.googlesource.com/c/1383141
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Nate Chapin <japhet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617652}
[modify] https://crrev.com/28462581f60f8df172b5859aa3468c447b37f777/third_party/blink/renderer/core/frame/local_frame.cc
[modify] https://crrev.com/28462581f60f8df172b5859aa3468c447b37f777/third_party/blink/renderer/core/inspector/inspector_network_agent.cc
[modify] https://crrev.com/28462581f60f8df172b5859aa3468c447b37f777/third_party/blink/renderer/core/inspector/inspector_network_agent.h
[modify] https://crrev.com/28462581f60f8df172b5859aa3468c447b37f777/third_party/blink/renderer/core/inspector/inspector_page_agent.cc
[modify] https://crrev.com/28462581f60f8df172b5859aa3468c447b37f777/third_party/blink/renderer/core/inspector/inspector_page_agent.h
[modify] https://crrev.com/28462581f60f8df172b5859aa3468c447b37f777/third_party/blink/renderer/core/loader/frame_loader_types.h
[modify] https://crrev.com/28462581f60f8df172b5859aa3468c447b37f777/third_party/blink/renderer/core/loader/navigation_scheduler.cc
[modify] https://crrev.com/28462581f60f8df172b5859aa3468c447b37f777/third_party/blink/renderer/core/loader/scheduled_navigation.cc
[modify] https://crrev.com/28462581f60f8df172b5859aa3468c447b37f777/third_party/blink/renderer/core/loader/scheduled_navigation.h
[modify] https://crrev.com/28462581f60f8df172b5859aa3468c447b37f777/third_party/blink/renderer/core/probe/core_probes.json5
[modify] https://crrev.com/28462581f60f8df172b5859aa3468c447b37f777/third_party/blink/renderer/core/probe/core_probes.pidl
[modify] https://crrev.com/28462581f60f8df172b5859aa3468c447b37f777/third_party/blink/web_tests/http/tests/inspector-protocol/page/frameScheduledNavigation-expected.txt
[modify] https://crrev.com/28462581f60f8df172b5859aa3468c447b37f777/third_party/blink/web_tests/http/tests/inspector-protocol/page/frameScheduledNavigation.js
[modify] https://crrev.com/28462581f60f8df172b5859aa3468c447b37f777/third_party/blink/web_tests/http/tests/inspector-protocol/page/resources/navigation-chain3.pl

Project Member

Comment 7 by bugdroid1@chromium.org, Dec 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d86b336f22131fdd8d65e57cd09178ae26ababa4

commit d86b336f22131fdd8d65e57cd09178ae26ababa4
Author: Nate Chapin <japhet@chromium.org>
Date: Tue Dec 18 22:40:59 2018

Skip NavigationScheduler for form submission

Bug: 914587
Change-Id: I272044a02e9180defd7201198a5909d4ea302eb6
Reviewed-on: https://chromium-review.googlesource.com/c/1371071
Commit-Queue: Nate Chapin <japhet@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617657}
[modify] https://crrev.com/d86b336f22131fdd8d65e57cd09178ae26ababa4/third_party/blink/renderer/core/frame/frame.h
[modify] https://crrev.com/d86b336f22131fdd8d65e57cd09178ae26ababa4/third_party/blink/renderer/core/frame/local_frame.cc
[modify] https://crrev.com/d86b336f22131fdd8d65e57cd09178ae26ababa4/third_party/blink/renderer/core/frame/local_frame.h
[modify] https://crrev.com/d86b336f22131fdd8d65e57cd09178ae26ababa4/third_party/blink/renderer/core/frame/remote_frame.cc
[modify] https://crrev.com/d86b336f22131fdd8d65e57cd09178ae26ababa4/third_party/blink/renderer/core/frame/remote_frame.h
[modify] https://crrev.com/d86b336f22131fdd8d65e57cd09178ae26ababa4/third_party/blink/renderer/core/html/forms/html_form_element.cc
[modify] https://crrev.com/d86b336f22131fdd8d65e57cd09178ae26ababa4/third_party/blink/renderer/core/loader/navigation_scheduler.cc
[modify] https://crrev.com/d86b336f22131fdd8d65e57cd09178ae26ababa4/third_party/blink/renderer/core/loader/navigation_scheduler.h
[modify] https://crrev.com/d86b336f22131fdd8d65e57cd09178ae26ababa4/third_party/blink/web_tests/dom/legacy_dom_conformance/xhtml/level2/html/HTMLFormElement10.js
[modify] https://crrev.com/d86b336f22131fdd8d65e57cd09178ae26ababa4/third_party/blink/web_tests/fast/events/popup-blocked-to-post-blank-expected.txt
[modify] https://crrev.com/d86b336f22131fdd8d65e57cd09178ae26ababa4/third_party/blink/web_tests/fast/forms/form-submission-create-crash.xhtml
[modify] https://crrev.com/d86b336f22131fdd8d65e57cd09178ae26ababa4/third_party/blink/web_tests/fast/forms/select/select-empty-optgroup-crash.html
[modify] https://crrev.com/d86b336f22131fdd8d65e57cd09178ae26ababa4/third_party/blink/web_tests/fast/forms/submit-add-remove-element.html
[modify] https://crrev.com/d86b336f22131fdd8d65e57cd09178ae26ababa4/third_party/blink/web_tests/http/tests/loading/307-after-303-after-post-expected.txt
[modify] https://crrev.com/d86b336f22131fdd8d65e57cd09178ae26ababa4/third_party/blink/web_tests/http/tests/loading/redirect-methods-expected.txt
[modify] https://crrev.com/d86b336f22131fdd8d65e57cd09178ae26ababa4/third_party/blink/web_tests/http/tests/security/contentSecurityPolicy/1.1/form-action-src-get-blocked-with-redirect-expected.txt
[modify] https://crrev.com/d86b336f22131fdd8d65e57cd09178ae26ababa4/third_party/blink/web_tests/http/tests/security/contentSecurityPolicy/1.1/form-action-src-redirect-blocked-expected.txt
[modify] https://crrev.com/d86b336f22131fdd8d65e57cd09178ae26ababa4/third_party/blink/web_tests/virtual/mouseevent_fractional/fast/events/popup-blocked-to-post-blank-expected.txt
[modify] https://crrev.com/d86b336f22131fdd8d65e57cd09178ae26ababa4/third_party/blink/web_tests/virtual/user-activation-v2/fast/events/popup-blocked-to-post-blank-expected.txt

Project Member

Comment 8 by bugdroid1@chromium.org, Dec 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8953b6f7ba5eb917a5d75d5571b128586b5a4be8

commit 8953b6f7ba5eb917a5d75d5571b128586b5a4be8
Author: Lutz Justen <ljusten@chromium.org>
Date: Wed Dec 19 10:22:19 2018

[Sheriff] Revert "Skip NavigationScheduler for form submission"

This reverts commit d86b336f22131fdd8d65e57cd09178ae26ababa4.

Reason for revert: Probably responsible for flakiness in PasswordManagerBrowserTest.DeleteFrameBeforeSubmit test.

BUG=chromium:916413

Original change's description:
> Skip NavigationScheduler for form submission
> 
> Bug: 914587
> Change-Id: I272044a02e9180defd7201198a5909d4ea302eb6
> Reviewed-on: https://chromium-review.googlesource.com/c/1371071
> Commit-Queue: Nate Chapin <japhet@chromium.org>
> Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#617657}

TBR=dgozman@chromium.org,dcheng@chromium.org,japhet@chromium.org

Change-Id: Ib50d642d3df7e8e87c06a618c5f32a4ebc6641ee
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 914587
Reviewed-on: https://chromium-review.googlesource.com/c/1384065
Reviewed-by: Lutz Justen <ljusten@chromium.org>
Commit-Queue: Lutz Justen <ljusten@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617784}
[modify] https://crrev.com/8953b6f7ba5eb917a5d75d5571b128586b5a4be8/third_party/blink/renderer/core/frame/frame.h
[modify] https://crrev.com/8953b6f7ba5eb917a5d75d5571b128586b5a4be8/third_party/blink/renderer/core/frame/local_frame.cc
[modify] https://crrev.com/8953b6f7ba5eb917a5d75d5571b128586b5a4be8/third_party/blink/renderer/core/frame/local_frame.h
[modify] https://crrev.com/8953b6f7ba5eb917a5d75d5571b128586b5a4be8/third_party/blink/renderer/core/frame/remote_frame.cc
[modify] https://crrev.com/8953b6f7ba5eb917a5d75d5571b128586b5a4be8/third_party/blink/renderer/core/frame/remote_frame.h
[modify] https://crrev.com/8953b6f7ba5eb917a5d75d5571b128586b5a4be8/third_party/blink/renderer/core/html/forms/html_form_element.cc
[modify] https://crrev.com/8953b6f7ba5eb917a5d75d5571b128586b5a4be8/third_party/blink/renderer/core/loader/navigation_scheduler.cc
[modify] https://crrev.com/8953b6f7ba5eb917a5d75d5571b128586b5a4be8/third_party/blink/renderer/core/loader/navigation_scheduler.h
[modify] https://crrev.com/8953b6f7ba5eb917a5d75d5571b128586b5a4be8/third_party/blink/web_tests/dom/legacy_dom_conformance/xhtml/level2/html/HTMLFormElement10.js
[modify] https://crrev.com/8953b6f7ba5eb917a5d75d5571b128586b5a4be8/third_party/blink/web_tests/fast/events/popup-blocked-to-post-blank-expected.txt
[modify] https://crrev.com/8953b6f7ba5eb917a5d75d5571b128586b5a4be8/third_party/blink/web_tests/fast/forms/form-submission-create-crash.xhtml
[modify] https://crrev.com/8953b6f7ba5eb917a5d75d5571b128586b5a4be8/third_party/blink/web_tests/fast/forms/select/select-empty-optgroup-crash.html
[modify] https://crrev.com/8953b6f7ba5eb917a5d75d5571b128586b5a4be8/third_party/blink/web_tests/fast/forms/submit-add-remove-element.html
[modify] https://crrev.com/8953b6f7ba5eb917a5d75d5571b128586b5a4be8/third_party/blink/web_tests/http/tests/loading/307-after-303-after-post-expected.txt
[modify] https://crrev.com/8953b6f7ba5eb917a5d75d5571b128586b5a4be8/third_party/blink/web_tests/http/tests/loading/redirect-methods-expected.txt
[modify] https://crrev.com/8953b6f7ba5eb917a5d75d5571b128586b5a4be8/third_party/blink/web_tests/http/tests/security/contentSecurityPolicy/1.1/form-action-src-get-blocked-with-redirect-expected.txt
[modify] https://crrev.com/8953b6f7ba5eb917a5d75d5571b128586b5a4be8/third_party/blink/web_tests/http/tests/security/contentSecurityPolicy/1.1/form-action-src-redirect-blocked-expected.txt
[modify] https://crrev.com/8953b6f7ba5eb917a5d75d5571b128586b5a4be8/third_party/blink/web_tests/virtual/mouseevent_fractional/fast/events/popup-blocked-to-post-blank-expected.txt
[modify] https://crrev.com/8953b6f7ba5eb917a5d75d5571b128586b5a4be8/third_party/blink/web_tests/virtual/user-activation-v2/fast/events/popup-blocked-to-post-blank-expected.txt

Project Member

Comment 9 by bugdroid1@chromium.org, Dec 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/222c56b88ac44edae1d1bc57ae2a49e1949f5bd1

commit 222c56b88ac44edae1d1bc57ae2a49e1949f5bd1
Author: Dmitry Gozman <dgozman@chromium.org>
Date: Wed Dec 19 19:11:13 2018

Commit all non-empty non-first-load documents asynchronously

This makes almost all navigations asynchronous, and allows
to handle them similarly no matter whether they issue
a network request or not.

Also added CreatePlaceholderDocumentLoader call which ensures
that frame is marked as loading immediately, before committing
asynchronously.

Bug: 914587
Change-Id: I41639daa3ac8f4a1d239c479c9382ac3ddb5b113
Reviewed-on: https://chromium-review.googlesource.com/c/1380552
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Nate Chapin <japhet@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617901}
[modify] https://crrev.com/222c56b88ac44edae1d1bc57ae2a49e1949f5bd1/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/222c56b88ac44edae1d1bc57ae2a49e1949f5bd1/content/renderer/render_frame_impl.h

Blocking: 804504
Project Member

Comment 11 by bugdroid1@chromium.org, Jan 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5d3c7566f8d3004d7860850d770abd65a61d5dbd

commit 5d3c7566f8d3004d7860850d770abd65a61d5dbd
Author: Max Morin <maxmorin@chromium.org>
Date: Fri Jan 04 12:15:16 2019

Disable flaky MimeHandlerViewCrossProcessTest.NavigationRaceFromEmbedder

Tbr: fsamuel
Bug: 914587, 918784
Change-Id: I7d6dbde2c72048d493c1f2e5ca14bfe803f2b91c
Reviewed-on: https://chromium-review.googlesource.com/c/1396022
Reviewed-by: Max Morin <maxmorin@chromium.org>
Commit-Queue: Max Morin <maxmorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619918}
[modify] https://crrev.com/5d3c7566f8d3004d7860850d770abd65a61d5dbd/extensions/browser/guest_view/mime_handler_view/mime_handler_view_browsertest.cc

Project Member

Comment 12 by bugdroid1@chromium.org, Jan 15

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0a5cbbbed80059e1a0dd3e684db88987f9b4234a

commit 0a5cbbbed80059e1a0dd3e684db88987f9b4234a
Author: Nate Chapin <japhet@chromium.org>
Date: Tue Jan 15 23:48:39 2019

Run Javascript urls through the document.

Put them on a timer and have them block the load event. This guarantees
that JS urls will always run asynchronously, improving spec compliance.
It also will allow us to depend far less on NavigationScheduler for
our async navigation needs, hopefully allow us to delete that class
someday soon.

Bug: 638435, 914587
Change-Id: I01ab08640fc22a84f19ef096021c654ef0b96301
Reviewed-on: https://chromium-review.googlesource.com/c/1387448
Commit-Queue: Nate Chapin <japhet@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622873}
[delete] https://crrev.com/8ee8373ae9828abad9ed511dff1fddaac7479955/chrome/test/data/extensions/api_test/content_scripts/about_blank_iframes/end.js
[modify] https://crrev.com/0a5cbbbed80059e1a0dd3e684db88987f9b4234a/chrome/test/data/extensions/api_test/content_scripts/about_blank_iframes/manifest.json
[delete] https://crrev.com/8ee8373ae9828abad9ed511dff1fddaac7479955/chrome/test/data/extensions/api_test/content_scripts/about_blank_iframes/start.js
[modify] https://crrev.com/0a5cbbbed80059e1a0dd3e684db88987f9b4234a/chrome/test/data/extensions/api_test/content_scripts/about_blank_iframes/test.js
[modify] https://crrev.com/0a5cbbbed80059e1a0dd3e684db88987f9b4234a/third_party/blink/renderer/bindings/core/v8/script_controller.cc
[modify] https://crrev.com/0a5cbbbed80059e1a0dd3e684db88987f9b4234a/third_party/blink/renderer/core/dom/document.cc
[modify] https://crrev.com/0a5cbbbed80059e1a0dd3e684db88987f9b4234a/third_party/blink/renderer/core/dom/document.h
[modify] https://crrev.com/0a5cbbbed80059e1a0dd3e684db88987f9b4234a/third_party/blink/renderer/core/exported/web_view_test.cc
[modify] https://crrev.com/0a5cbbbed80059e1a0dd3e684db88987f9b4234a/third_party/blink/renderer/core/html/forms/html_form_element.cc
[modify] https://crrev.com/0a5cbbbed80059e1a0dd3e684db88987f9b4234a/third_party/blink/renderer/core/html/html_frame_owner_element.cc
[modify] https://crrev.com/0a5cbbbed80059e1a0dd3e684db88987f9b4234a/third_party/blink/renderer/core/html/lazy_load_frame_observer_test.cc
[modify] https://crrev.com/0a5cbbbed80059e1a0dd3e684db88987f9b4234a/third_party/blink/renderer/core/loader/frame_loader.cc
[modify] https://crrev.com/0a5cbbbed80059e1a0dd3e684db88987f9b4234a/third_party/blink/renderer/core/loader/navigation_scheduler.cc
[modify] https://crrev.com/0a5cbbbed80059e1a0dd3e684db88987f9b4234a/third_party/blink/web_tests/TestExpectations
[modify] https://crrev.com/0a5cbbbed80059e1a0dd3e684db88987f9b4234a/third_party/blink/web_tests/editing/inserting/insert-with-javascript-protocol-crash-expected.txt
[delete] https://crrev.com/8ee8373ae9828abad9ed511dff1fddaac7479955/third_party/blink/web_tests/external/wpt/dom/nodes/Document-contentType/contentType/contenttype_javascripturi-expected.txt
[delete] https://crrev.com/8ee8373ae9828abad9ed511dff1fddaac7479955/third_party/blink/web_tests/external/wpt/html/browsers/browsing-the-web/navigating-across-documents/013-expected.txt
[delete] https://crrev.com/8ee8373ae9828abad9ed511dff1fddaac7479955/third_party/blink/web_tests/external/wpt/html/browsers/browsing-the-web/navigating-across-documents/014-expected.txt
[delete] https://crrev.com/8ee8373ae9828abad9ed511dff1fddaac7479955/third_party/blink/web_tests/external/wpt/html/browsers/browsing-the-web/navigating-across-documents/015-expected.txt
[delete] https://crrev.com/8ee8373ae9828abad9ed511dff1fddaac7479955/third_party/blink/web_tests/external/wpt/html/browsers/browsing-the-web/navigating-across-documents/javascript-url-abort/javascript-url-abort-return-value-string.tentative-expected.txt
[delete] https://crrev.com/8ee8373ae9828abad9ed511dff1fddaac7479955/third_party/blink/web_tests/external/wpt/html/semantics/scripting-1/the-script-element/execution-timing/029-expected.txt
[delete] https://crrev.com/8ee8373ae9828abad9ed511dff1fddaac7479955/third_party/blink/web_tests/external/wpt/html/semantics/scripting-1/the-script-element/execution-timing/030-expected.txt
[delete] https://crrev.com/8ee8373ae9828abad9ed511dff1fddaac7479955/third_party/blink/web_tests/external/wpt/html/semantics/scripting-1/the-script-element/execution-timing/040-expected.txt
[delete] https://crrev.com/8ee8373ae9828abad9ed511dff1fddaac7479955/third_party/blink/web_tests/external/wpt/html/semantics/scripting-1/the-script-element/execution-timing/080-expected.txt
[delete] https://crrev.com/8ee8373ae9828abad9ed511dff1fddaac7479955/third_party/blink/web_tests/external/wpt/html/semantics/scripting-1/the-script-element/execution-timing/108-expected.txt
[delete] https://crrev.com/8ee8373ae9828abad9ed511dff1fddaac7479955/third_party/blink/web_tests/external/wpt/html/semantics/scripting-1/the-script-element/execution-timing/109-expected.txt
[modify] https://crrev.com/0a5cbbbed80059e1a0dd3e684db88987f9b4234a/third_party/blink/web_tests/fast/dom/Element/id-in-frameset-expected.txt
[modify] https://crrev.com/0a5cbbbed80059e1a0dd3e684db88987f9b4234a/third_party/blink/web_tests/fast/dom/insertedIntoDocument-iframe.html
[delete] https://crrev.com/8ee8373ae9828abad9ed511dff1fddaac7479955/third_party/blink/web_tests/fast/dom/javascript-url-exception-isolation-expected.txt
[delete] https://crrev.com/8ee8373ae9828abad9ed511dff1fddaac7479955/third_party/blink/web_tests/fast/dom/javascript-url-exception-isolation.html
[modify] https://crrev.com/0a5cbbbed80059e1a0dd3e684db88987f9b4234a/third_party/blink/web_tests/fast/dom/replaced-image-map.html
[modify] https://crrev.com/0a5cbbbed80059e1a0dd3e684db88987f9b4234a/third_party/blink/web_tests/fast/dom/resources/javascript-url-crash-function-iframe.html
[modify] https://crrev.com/0a5cbbbed80059e1a0dd3e684db88987f9b4234a/third_party/blink/web_tests/fast/events/access-key-self-destruct.html
[modify] https://crrev.com/0a5cbbbed80059e1a0dd3e684db88987f9b4234a/third_party/blink/web_tests/fast/events/click-anchor-blur-refocus-window-expected.html
[modify] https://crrev.com/0a5cbbbed80059e1a0dd3e684db88987f9b4234a/third_party/blink/web_tests/fast/events/click-anchor-refocus-window-expected.html
[modify] https://crrev.com/0a5cbbbed80059e1a0dd3e684db88987f9b4234a/third_party/blink/web_tests/fast/events/click-svganchor-blur-refocus-window-expected.html
[modify] https://crrev.com/0a5cbbbed80059e1a0dd3e684db88987f9b4234a/third_party/blink/web_tests/fast/events/click-svganchor-refocus-window-expected.html
[modify] https://crrev.com/0a5cbbbed80059e1a0dd3e684db88987f9b4234a/third_party/blink/web_tests/fast/events/domactivate-sets-underlying-click-event-as-handled-expected.txt
[modify] https://crrev.com/0a5cbbbed80059e1a0dd3e684db88987f9b4234a/third_party/blink/web_tests/fast/events/domactivate-sets-underlying-click-event-as-handled.html
[modify] https://crrev.com/0a5cbbbed80059e1a0dd3e684db88987f9b4234a/third_party/blink/web_tests/fast/forms/formaction-attribute.html
[modify] https://crrev.com/0a5cbbbed80059e1a0dd3e684db88987f9b4234a/third_party/blink/web_tests/fast/frames/adopt-from-created-document.html
[modify] https://crrev.com/0a5cbbbed80059e1a0dd3e684db88987f9b4234a/third_party/blink/web_tests/fast/frames/javascript-url-for-deleted-frame-expected.txt
[modify] https://crrev.com/0a5cbbbed80059e1a0dd3e684db88987f9b4234a/third_party/blink/web_tests/fast/frames/navigation-in-pagehide.html
[modify] https://crrev.com/0a5cbbbed80059e1a0dd3e684db88987f9b4234a/third_party/blink/web_tests/fast/frames/out-of-document-iframe-has-child-frame.html
[modify] https://crrev.com/0a5cbbbed80059e1a0dd3e684db88987f9b4234a/third_party/blink/web_tests/fast/loader/detach-iframe-while-loading-javascript-url-expected.txt
[modify] https://crrev.com/0a5cbbbed80059e1a0dd3e684db88987f9b4234a/third_party/blink/web_tests/fast/replaced/image-map-bug16782.html
[modify] https://crrev.com/0a5cbbbed80059e1a0dd3e684db88987f9b4234a/third_party/blink/web_tests/fast/replaced/image-map.html
[modify] https://crrev.com/0a5cbbbed80059e1a0dd3e684db88987f9b4234a/third_party/blink/web_tests/http/tests/navigation/lockedhistory-iframe-expected.txt
[modify] https://crrev.com/0a5cbbbed80059e1a0dd3e684db88987f9b4234a/third_party/blink/web_tests/http/tests/navigation/lockedhistory-iframe.html
[modify] https://crrev.com/0a5cbbbed80059e1a0dd3e684db88987f9b4234a/third_party/blink/web_tests/http/tests/security/javascriptURL/xss-ALLOWED-from-javascript-url-sub-frame.html
[modify] https://crrev.com/0a5cbbbed80059e1a0dd3e684db88987f9b4234a/third_party/blink/web_tests/http/tests/security/popup-allowed-by-sandbox-is-sandboxed-control.html
[modify] https://crrev.com/0a5cbbbed80059e1a0dd3e684db88987f9b4234a/third_party/blink/web_tests/http/tests/security/xssAuditor/resources/javascript-link-safe.php
[modify] https://crrev.com/0a5cbbbed80059e1a0dd3e684db88987f9b4234a/third_party/blink/web_tests/paint/invalidation/scroll/repaint-during-scroll-with-zoom.html

Project Member

Comment 13 by bugdroid1@chromium.org, Jan 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/98b0b75172690b363de3975c5540b94ea666ba07

commit 98b0b75172690b363de3975c5540b94ea666ba07
Author: Kevin Marshall <kmarshall@chromium.org>
Date: Wed Jan 16 02:09:30 2019

Revert "Run Javascript urls through the document."

This reverts commit 0a5cbbbed80059e1a0dd3e684db88987f9b4234a.

Reason for revert: Breaks many test suites, see https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Release%20%28NVIDIA%29/149774 for an example.

Error log is:
[1:1:0115/160946.626469:FATAL:document.h(465)] Check failed: style_engine_.Get().

Original change's description:
> Run Javascript urls through the document.
>
> Put them on a timer and have them block the load event. This guarantees
> that JS urls will always run asynchronously, improving spec compliance.
> It also will allow us to depend far less on NavigationScheduler for
> our async navigation needs, hopefully allow us to delete that class
> someday soon.
>
> Bug: 638435, 914587
> Change-Id: I01ab08640fc22a84f19ef096021c654ef0b96301
> Reviewed-on: https://chromium-review.googlesource.com/c/1387448
> Commit-Queue: Nate Chapin <japhet@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#622873}

TBR=dgozman@chromium.org,dcheng@chromium.org,japhet@chromium.org,acomminos@fb.com

Change-Id: I224e717aecf5f8f2c8a71ff72bf47c9fdce20a16
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 638435, 914587
Reviewed-on: https://chromium-review.googlesource.com/c/1413894
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623033}
[add] https://crrev.com/98b0b75172690b363de3975c5540b94ea666ba07/chrome/test/data/extensions/api_test/content_scripts/about_blank_iframes/end.js
[modify] https://crrev.com/98b0b75172690b363de3975c5540b94ea666ba07/chrome/test/data/extensions/api_test/content_scripts/about_blank_iframes/manifest.json
[add] https://crrev.com/98b0b75172690b363de3975c5540b94ea666ba07/chrome/test/data/extensions/api_test/content_scripts/about_blank_iframes/start.js
[modify] https://crrev.com/98b0b75172690b363de3975c5540b94ea666ba07/chrome/test/data/extensions/api_test/content_scripts/about_blank_iframes/test.js
[modify] https://crrev.com/98b0b75172690b363de3975c5540b94ea666ba07/third_party/blink/renderer/bindings/core/v8/script_controller.cc
[modify] https://crrev.com/98b0b75172690b363de3975c5540b94ea666ba07/third_party/blink/renderer/core/dom/document.cc
[modify] https://crrev.com/98b0b75172690b363de3975c5540b94ea666ba07/third_party/blink/renderer/core/dom/document.h
[modify] https://crrev.com/98b0b75172690b363de3975c5540b94ea666ba07/third_party/blink/renderer/core/exported/web_view_test.cc
[modify] https://crrev.com/98b0b75172690b363de3975c5540b94ea666ba07/third_party/blink/renderer/core/html/forms/html_form_element.cc
[modify] https://crrev.com/98b0b75172690b363de3975c5540b94ea666ba07/third_party/blink/renderer/core/html/html_frame_owner_element.cc
[modify] https://crrev.com/98b0b75172690b363de3975c5540b94ea666ba07/third_party/blink/renderer/core/html/lazy_load_frame_observer_test.cc
[modify] https://crrev.com/98b0b75172690b363de3975c5540b94ea666ba07/third_party/blink/renderer/core/loader/frame_loader.cc
[modify] https://crrev.com/98b0b75172690b363de3975c5540b94ea666ba07/third_party/blink/renderer/core/loader/navigation_scheduler.cc
[modify] https://crrev.com/98b0b75172690b363de3975c5540b94ea666ba07/third_party/blink/web_tests/TestExpectations
[modify] https://crrev.com/98b0b75172690b363de3975c5540b94ea666ba07/third_party/blink/web_tests/editing/inserting/insert-with-javascript-protocol-crash-expected.txt
[add] https://crrev.com/98b0b75172690b363de3975c5540b94ea666ba07/third_party/blink/web_tests/external/wpt/dom/nodes/Document-contentType/contentType/contenttype_javascripturi-expected.txt
[add] https://crrev.com/98b0b75172690b363de3975c5540b94ea666ba07/third_party/blink/web_tests/external/wpt/html/browsers/browsing-the-web/navigating-across-documents/013-expected.txt
[add] https://crrev.com/98b0b75172690b363de3975c5540b94ea666ba07/third_party/blink/web_tests/external/wpt/html/browsers/browsing-the-web/navigating-across-documents/014-expected.txt
[add] https://crrev.com/98b0b75172690b363de3975c5540b94ea666ba07/third_party/blink/web_tests/external/wpt/html/browsers/browsing-the-web/navigating-across-documents/015-expected.txt
[add] https://crrev.com/98b0b75172690b363de3975c5540b94ea666ba07/third_party/blink/web_tests/external/wpt/html/browsers/browsing-the-web/navigating-across-documents/javascript-url-abort/javascript-url-abort-return-value-string.tentative-expected.txt
[add] https://crrev.com/98b0b75172690b363de3975c5540b94ea666ba07/third_party/blink/web_tests/external/wpt/html/semantics/scripting-1/the-script-element/execution-timing/029-expected.txt
[add] https://crrev.com/98b0b75172690b363de3975c5540b94ea666ba07/third_party/blink/web_tests/external/wpt/html/semantics/scripting-1/the-script-element/execution-timing/030-expected.txt
[add] https://crrev.com/98b0b75172690b363de3975c5540b94ea666ba07/third_party/blink/web_tests/external/wpt/html/semantics/scripting-1/the-script-element/execution-timing/040-expected.txt
[add] https://crrev.com/98b0b75172690b363de3975c5540b94ea666ba07/third_party/blink/web_tests/external/wpt/html/semantics/scripting-1/the-script-element/execution-timing/080-expected.txt
[add] https://crrev.com/98b0b75172690b363de3975c5540b94ea666ba07/third_party/blink/web_tests/external/wpt/html/semantics/scripting-1/the-script-element/execution-timing/108-expected.txt
[add] https://crrev.com/98b0b75172690b363de3975c5540b94ea666ba07/third_party/blink/web_tests/external/wpt/html/semantics/scripting-1/the-script-element/execution-timing/109-expected.txt
[modify] https://crrev.com/98b0b75172690b363de3975c5540b94ea666ba07/third_party/blink/web_tests/fast/dom/Element/id-in-frameset-expected.txt
[modify] https://crrev.com/98b0b75172690b363de3975c5540b94ea666ba07/third_party/blink/web_tests/fast/dom/insertedIntoDocument-iframe.html
[add] https://crrev.com/98b0b75172690b363de3975c5540b94ea666ba07/third_party/blink/web_tests/fast/dom/javascript-url-exception-isolation-expected.txt
[add] https://crrev.com/98b0b75172690b363de3975c5540b94ea666ba07/third_party/blink/web_tests/fast/dom/javascript-url-exception-isolation.html
[modify] https://crrev.com/98b0b75172690b363de3975c5540b94ea666ba07/third_party/blink/web_tests/fast/dom/replaced-image-map.html
[modify] https://crrev.com/98b0b75172690b363de3975c5540b94ea666ba07/third_party/blink/web_tests/fast/dom/resources/javascript-url-crash-function-iframe.html
[modify] https://crrev.com/98b0b75172690b363de3975c5540b94ea666ba07/third_party/blink/web_tests/fast/events/access-key-self-destruct.html
[modify] https://crrev.com/98b0b75172690b363de3975c5540b94ea666ba07/third_party/blink/web_tests/fast/events/click-anchor-blur-refocus-window-expected.html
[modify] https://crrev.com/98b0b75172690b363de3975c5540b94ea666ba07/third_party/blink/web_tests/fast/events/click-anchor-refocus-window-expected.html
[modify] https://crrev.com/98b0b75172690b363de3975c5540b94ea666ba07/third_party/blink/web_tests/fast/events/click-svganchor-blur-refocus-window-expected.html
[modify] https://crrev.com/98b0b75172690b363de3975c5540b94ea666ba07/third_party/blink/web_tests/fast/events/click-svganchor-refocus-window-expected.html
[modify] https://crrev.com/98b0b75172690b363de3975c5540b94ea666ba07/third_party/blink/web_tests/fast/events/domactivate-sets-underlying-click-event-as-handled-expected.txt
[modify] https://crrev.com/98b0b75172690b363de3975c5540b94ea666ba07/third_party/blink/web_tests/fast/events/domactivate-sets-underlying-click-event-as-handled.html
[modify] https://crrev.com/98b0b75172690b363de3975c5540b94ea666ba07/third_party/blink/web_tests/fast/forms/formaction-attribute.html
[modify] https://crrev.com/98b0b75172690b363de3975c5540b94ea666ba07/third_party/blink/web_tests/fast/frames/adopt-from-created-document.html
[modify] https://crrev.com/98b0b75172690b363de3975c5540b94ea666ba07/third_party/blink/web_tests/fast/frames/javascript-url-for-deleted-frame-expected.txt
[modify] https://crrev.com/98b0b75172690b363de3975c5540b94ea666ba07/third_party/blink/web_tests/fast/frames/navigation-in-pagehide.html
[modify] https://crrev.com/98b0b75172690b363de3975c5540b94ea666ba07/third_party/blink/web_tests/fast/frames/out-of-document-iframe-has-child-frame.html
[modify] https://crrev.com/98b0b75172690b363de3975c5540b94ea666ba07/third_party/blink/web_tests/fast/loader/detach-iframe-while-loading-javascript-url-expected.txt
[modify] https://crrev.com/98b0b75172690b363de3975c5540b94ea666ba07/third_party/blink/web_tests/fast/replaced/image-map-bug16782.html
[modify] https://crrev.com/98b0b75172690b363de3975c5540b94ea666ba07/third_party/blink/web_tests/fast/replaced/image-map.html
[modify] https://crrev.com/98b0b75172690b363de3975c5540b94ea666ba07/third_party/blink/web_tests/http/tests/navigation/lockedhistory-iframe-expected.txt
[modify] https://crrev.com/98b0b75172690b363de3975c5540b94ea666ba07/third_party/blink/web_tests/http/tests/navigation/lockedhistory-iframe.html
[modify] https://crrev.com/98b0b75172690b363de3975c5540b94ea666ba07/third_party/blink/web_tests/http/tests/security/javascriptURL/xss-ALLOWED-from-javascript-url-sub-frame.html
[modify] https://crrev.com/98b0b75172690b363de3975c5540b94ea666ba07/third_party/blink/web_tests/http/tests/security/popup-allowed-by-sandbox-is-sandboxed-control.html
[modify] https://crrev.com/98b0b75172690b363de3975c5540b94ea666ba07/third_party/blink/web_tests/http/tests/security/xssAuditor/resources/javascript-link-safe.php
[modify] https://crrev.com/98b0b75172690b363de3975c5540b94ea666ba07/third_party/blink/web_tests/paint/invalidation/scroll/repaint-during-scroll-with-zoom.html

Blockedon: 922318
Project Member

Comment 15 by bugdroid1@chromium.org, Jan 18 (4 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ebbcef1f17bc37f5380bd7e87a17016defd1fdd0

commit ebbcef1f17bc37f5380bd7e87a17016defd1fdd0
Author: Nate Chapin <japhet@chromium.org>
Date: Fri Jan 18 08:21:24 2019

Run Javascript urls through the document, attempt #2

Put them on a timer and have them block the load event. This guarantees
that JS urls will always run asynchronously, improving spec compliance.
It also will allow us to depend far less on NavigationScheduler for
our async navigation needs, hopefully allow us to delete that class
someday soon.

Bug: 638435, 914587,  922318 ,  922330 

Change-Id: I9b72af88009115a55167afa42e7206d54bb5c2c1
Reviewed-on: https://chromium-review.googlesource.com/c/1415312
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Auto-Submit: Nate Chapin <japhet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624035}
[delete] https://crrev.com/06d7a5b8113780d08793bff5f157e6228f9f002c/chrome/test/data/extensions/api_test/content_scripts/about_blank_iframes/end.js
[modify] https://crrev.com/ebbcef1f17bc37f5380bd7e87a17016defd1fdd0/chrome/test/data/extensions/api_test/content_scripts/about_blank_iframes/manifest.json
[delete] https://crrev.com/06d7a5b8113780d08793bff5f157e6228f9f002c/chrome/test/data/extensions/api_test/content_scripts/about_blank_iframes/start.js
[modify] https://crrev.com/ebbcef1f17bc37f5380bd7e87a17016defd1fdd0/chrome/test/data/extensions/api_test/content_scripts/about_blank_iframes/test.js
[modify] https://crrev.com/ebbcef1f17bc37f5380bd7e87a17016defd1fdd0/third_party/blink/renderer/bindings/core/v8/script_controller.cc
[modify] https://crrev.com/ebbcef1f17bc37f5380bd7e87a17016defd1fdd0/third_party/blink/renderer/core/dom/document.cc
[modify] https://crrev.com/ebbcef1f17bc37f5380bd7e87a17016defd1fdd0/third_party/blink/renderer/core/dom/document.h
[modify] https://crrev.com/ebbcef1f17bc37f5380bd7e87a17016defd1fdd0/third_party/blink/renderer/core/exported/web_view_test.cc
[modify] https://crrev.com/ebbcef1f17bc37f5380bd7e87a17016defd1fdd0/third_party/blink/renderer/core/html/forms/html_form_element.cc
[modify] https://crrev.com/ebbcef1f17bc37f5380bd7e87a17016defd1fdd0/third_party/blink/renderer/core/html/html_frame_owner_element.cc
[modify] https://crrev.com/ebbcef1f17bc37f5380bd7e87a17016defd1fdd0/third_party/blink/renderer/core/html/lazy_load_frame_observer_test.cc
[modify] https://crrev.com/ebbcef1f17bc37f5380bd7e87a17016defd1fdd0/third_party/blink/renderer/core/loader/frame_loader.cc
[modify] https://crrev.com/ebbcef1f17bc37f5380bd7e87a17016defd1fdd0/third_party/blink/renderer/core/loader/navigation_scheduler.cc
[modify] https://crrev.com/ebbcef1f17bc37f5380bd7e87a17016defd1fdd0/third_party/blink/web_tests/TestExpectations
[modify] https://crrev.com/ebbcef1f17bc37f5380bd7e87a17016defd1fdd0/third_party/blink/web_tests/editing/inserting/insert-with-javascript-protocol-crash-expected.txt
[delete] https://crrev.com/06d7a5b8113780d08793bff5f157e6228f9f002c/third_party/blink/web_tests/external/wpt/dom/nodes/Document-contentType/contentType/contenttype_javascripturi-expected.txt
[delete] https://crrev.com/06d7a5b8113780d08793bff5f157e6228f9f002c/third_party/blink/web_tests/external/wpt/html/browsers/browsing-the-web/navigating-across-documents/013-expected.txt
[delete] https://crrev.com/06d7a5b8113780d08793bff5f157e6228f9f002c/third_party/blink/web_tests/external/wpt/html/browsers/browsing-the-web/navigating-across-documents/014-expected.txt
[delete] https://crrev.com/06d7a5b8113780d08793bff5f157e6228f9f002c/third_party/blink/web_tests/external/wpt/html/browsers/browsing-the-web/navigating-across-documents/015-expected.txt
[delete] https://crrev.com/06d7a5b8113780d08793bff5f157e6228f9f002c/third_party/blink/web_tests/external/wpt/html/browsers/browsing-the-web/navigating-across-documents/javascript-url-abort/javascript-url-abort-return-value-string.tentative-expected.txt
[delete] https://crrev.com/06d7a5b8113780d08793bff5f157e6228f9f002c/third_party/blink/web_tests/external/wpt/html/semantics/scripting-1/the-script-element/execution-timing/029-expected.txt
[delete] https://crrev.com/06d7a5b8113780d08793bff5f157e6228f9f002c/third_party/blink/web_tests/external/wpt/html/semantics/scripting-1/the-script-element/execution-timing/030-expected.txt
[delete] https://crrev.com/06d7a5b8113780d08793bff5f157e6228f9f002c/third_party/blink/web_tests/external/wpt/html/semantics/scripting-1/the-script-element/execution-timing/040-expected.txt
[delete] https://crrev.com/06d7a5b8113780d08793bff5f157e6228f9f002c/third_party/blink/web_tests/external/wpt/html/semantics/scripting-1/the-script-element/execution-timing/080-expected.txt
[delete] https://crrev.com/06d7a5b8113780d08793bff5f157e6228f9f002c/third_party/blink/web_tests/external/wpt/html/semantics/scripting-1/the-script-element/execution-timing/108-expected.txt
[delete] https://crrev.com/06d7a5b8113780d08793bff5f157e6228f9f002c/third_party/blink/web_tests/external/wpt/html/semantics/scripting-1/the-script-element/execution-timing/109-expected.txt
[modify] https://crrev.com/ebbcef1f17bc37f5380bd7e87a17016defd1fdd0/third_party/blink/web_tests/fast/dom/Element/id-in-frameset-expected.txt
[modify] https://crrev.com/ebbcef1f17bc37f5380bd7e87a17016defd1fdd0/third_party/blink/web_tests/fast/dom/insertedIntoDocument-iframe.html
[delete] https://crrev.com/06d7a5b8113780d08793bff5f157e6228f9f002c/third_party/blink/web_tests/fast/dom/javascript-url-crash-function-expected.txt
[delete] https://crrev.com/06d7a5b8113780d08793bff5f157e6228f9f002c/third_party/blink/web_tests/fast/dom/javascript-url-crash-function.html
[delete] https://crrev.com/06d7a5b8113780d08793bff5f157e6228f9f002c/third_party/blink/web_tests/fast/dom/javascript-url-exception-isolation-expected.txt
[delete] https://crrev.com/06d7a5b8113780d08793bff5f157e6228f9f002c/third_party/blink/web_tests/fast/dom/javascript-url-exception-isolation.html
[modify] https://crrev.com/ebbcef1f17bc37f5380bd7e87a17016defd1fdd0/third_party/blink/web_tests/fast/dom/replaced-image-map.html
[delete] https://crrev.com/06d7a5b8113780d08793bff5f157e6228f9f002c/third_party/blink/web_tests/fast/dom/resources/javascript-url-crash-function-iframe.html
[modify] https://crrev.com/ebbcef1f17bc37f5380bd7e87a17016defd1fdd0/third_party/blink/web_tests/fast/events/access-key-self-destruct.html
[modify] https://crrev.com/ebbcef1f17bc37f5380bd7e87a17016defd1fdd0/third_party/blink/web_tests/fast/events/click-anchor-blur-refocus-window-expected.html
[modify] https://crrev.com/ebbcef1f17bc37f5380bd7e87a17016defd1fdd0/third_party/blink/web_tests/fast/events/click-anchor-refocus-window-expected.html
[modify] https://crrev.com/ebbcef1f17bc37f5380bd7e87a17016defd1fdd0/third_party/blink/web_tests/fast/events/click-svganchor-blur-refocus-window-expected.html
[modify] https://crrev.com/ebbcef1f17bc37f5380bd7e87a17016defd1fdd0/third_party/blink/web_tests/fast/events/click-svganchor-refocus-window-expected.html
[modify] https://crrev.com/ebbcef1f17bc37f5380bd7e87a17016defd1fdd0/third_party/blink/web_tests/fast/events/domactivate-sets-underlying-click-event-as-handled-expected.txt
[modify] https://crrev.com/ebbcef1f17bc37f5380bd7e87a17016defd1fdd0/third_party/blink/web_tests/fast/events/domactivate-sets-underlying-click-event-as-handled.html
[modify] https://crrev.com/ebbcef1f17bc37f5380bd7e87a17016defd1fdd0/third_party/blink/web_tests/fast/forms/formaction-attribute.html
[modify] https://crrev.com/ebbcef1f17bc37f5380bd7e87a17016defd1fdd0/third_party/blink/web_tests/fast/frames/adopt-from-created-document.html
[modify] https://crrev.com/ebbcef1f17bc37f5380bd7e87a17016defd1fdd0/third_party/blink/web_tests/fast/frames/navigation-in-pagehide.html
[modify] https://crrev.com/ebbcef1f17bc37f5380bd7e87a17016defd1fdd0/third_party/blink/web_tests/fast/frames/out-of-document-iframe-has-child-frame.html
[modify] https://crrev.com/ebbcef1f17bc37f5380bd7e87a17016defd1fdd0/third_party/blink/web_tests/fast/loader/detach-iframe-while-loading-javascript-url-expected.txt
[modify] https://crrev.com/ebbcef1f17bc37f5380bd7e87a17016defd1fdd0/third_party/blink/web_tests/fast/loader/detach-iframe-while-loading-javascript-url.html
[modify] https://crrev.com/ebbcef1f17bc37f5380bd7e87a17016defd1fdd0/third_party/blink/web_tests/fast/loader/detach-while-printing-expected.txt
[modify] https://crrev.com/ebbcef1f17bc37f5380bd7e87a17016defd1fdd0/third_party/blink/web_tests/fast/loader/detach-while-printing.html
[modify] https://crrev.com/ebbcef1f17bc37f5380bd7e87a17016defd1fdd0/third_party/blink/web_tests/fast/loader/document-open-iframe-then-detach-expected.txt
[modify] https://crrev.com/ebbcef1f17bc37f5380bd7e87a17016defd1fdd0/third_party/blink/web_tests/fast/loader/document-open-iframe-then-detach.html
[modify] https://crrev.com/ebbcef1f17bc37f5380bd7e87a17016defd1fdd0/third_party/blink/web_tests/fast/parser/xml-error-adopted.xml
[modify] https://crrev.com/ebbcef1f17bc37f5380bd7e87a17016defd1fdd0/third_party/blink/web_tests/fast/replaced/image-map-bug16782.html
[modify] https://crrev.com/ebbcef1f17bc37f5380bd7e87a17016defd1fdd0/third_party/blink/web_tests/fast/replaced/image-map.html
[modify] https://crrev.com/ebbcef1f17bc37f5380bd7e87a17016defd1fdd0/third_party/blink/web_tests/http/tests/navigation/lockedhistory-iframe-expected.txt
[modify] https://crrev.com/ebbcef1f17bc37f5380bd7e87a17016defd1fdd0/third_party/blink/web_tests/http/tests/navigation/lockedhistory-iframe.html
[modify] https://crrev.com/ebbcef1f17bc37f5380bd7e87a17016defd1fdd0/third_party/blink/web_tests/http/tests/security/javascriptURL/xss-ALLOWED-from-javascript-url-sub-frame.html
[modify] https://crrev.com/ebbcef1f17bc37f5380bd7e87a17016defd1fdd0/third_party/blink/web_tests/http/tests/security/popup-allowed-by-sandbox-is-sandboxed-control.html
[modify] https://crrev.com/ebbcef1f17bc37f5380bd7e87a17016defd1fdd0/third_party/blink/web_tests/http/tests/security/xssAuditor/resources/javascript-link-safe.php
[modify] https://crrev.com/ebbcef1f17bc37f5380bd7e87a17016defd1fdd0/third_party/blink/web_tests/paint/invalidation/scroll/repaint-during-scroll-with-zoom.html

Comment 16 by pnoland@chromium.org, Jan 18 (4 days ago)

I just saw javascript-url-for-deleted-frame.html and detach-iframe-while-loading-javascript-url.html fail on a Mac trybot:
https://ci.chromium.org/p/chromium/builders/luci.chromium.try/mac_chromium_rel_ng/229595

Could the failures be related to this change?

Comment 17 by japhet@chromium.org, Jan 18 (4 days ago)

Yeah, it's plausible this CL made them flaky, I'll investigate.
Project Member

Comment 18 by bugdroid1@chromium.org, Jan 19 (4 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/418052e6c2658fa90b0ce08e465bd604fa1fe588

commit 418052e6c2658fa90b0ce08e465bd604fa1fe588
Author: Nate Chapin <japhet@chromium.org>
Date: Sat Jan 19 01:47:01 2019

Fix flaky tests caused by async javascript url execution

These tests have variable test completion timing now, so enforce it with
waitUntilDone/notifyDone

Bug: 914587
Change-Id: I42cde20c6422839ab26bf89adf6bcb9f845d6280
Reviewed-on: https://chromium-review.googlesource.com/c/1422746
Commit-Queue: Nate Chapin <japhet@chromium.org>
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Auto-Submit: Nate Chapin <japhet@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624407}
[modify] https://crrev.com/418052e6c2658fa90b0ce08e465bd604fa1fe588/third_party/blink/web_tests/fast/frames/javascript-url-for-deleted-frame.html
[modify] https://crrev.com/418052e6c2658fa90b0ce08e465bd604fa1fe588/third_party/blink/web_tests/fast/loader/detach-iframe-while-loading-javascript-url.html

Sign in to add a comment