New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 914577 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Offline Previews should not attempt to read offline pages database while blocking navigation.

Project Member Reported by ryansturm@chromium.org, Dec 12

Issue description

Offline Previews should not attempt to read offline pages database while blocking navigation. Currently, when navigating on android under poor network conditions, we may attempt to serve an Offline Preview by blocking the ongoing navigation to see if there is a copy of the page offline already stored for the user. This has a hit rate of about 2.5% and when it fails, it causes a delay before navigating to the page. This was negligible when only serving Slow2G users, but when serving 2G users, there is a slight regression in non-previews metrics.

An approach would be to store a set of hashed URLs in memory/pref and only attempt offline previews when we highly suspect the page is already stored when it matches a hash.

This solution could also be generalized to offline pages in general (i.e., for session restore, etc.) if there is a desire to serve offline pages when a page might not exist for users that are currently connected.
 
Components: UI>Browser>Offline
dimich, let me know if there is any reason to consider having this logic be within the offline pages code (i.e., if session restore tabs should not block navigations). I assume the hit rate of having the page is much higher for any offline pages served in session restore.

Otherwise, I may need to introduce a query to get a list of URLs that were saved within the past 7 days that would run at start-up, after the user clears history, etc.
Labels: -M-73 M-74

Sign in to add a comment