Fix performance metrics appearance |
|||||||||||
Issue description1. OL abbreviation for load event is not common. 2. Tweak colors to match material palette.
,
Dec 12
,
Dec 12
,
Dec 17
@alph can you add a screenshot? :)
,
Dec 17
Why the change to the Loaded color?
,
Dec 17
Julia, can you please give Pavel the details about color change.
,
Dec 17
looks good, thanks
,
Dec 17
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5e90846c2c0149b1cc4b4f916bdcc2605ff55ff3 commit 5e90846c2c0149b1cc4b4f916bdcc2605ff55ff3 Author: Alexei Filippov <alph@chromium.org> Date: Mon Dec 17 21:32:30 2018 DevTools: Fix the page metric events appearance. Plugged in new colors for events. Changes abbreviation of OL to L for load event. BUG= 914573 Change-Id: I68d85cbd72702a9c1e4d30ed1eea321db77f81d3 Reviewed-on: https://chromium-review.googlesource.com/c/1379047 Commit-Queue: Alexei Filippov <alph@chromium.org> Reviewed-by: Paul Irish <paulirish@chromium.org> Cr-Commit-Position: refs/heads/master@{#617237} [modify] https://crrev.com/5e90846c2c0149b1cc4b4f916bdcc2605ff55ff3/third_party/blink/renderer/devtools/front_end/network/NetworkLogView.js [modify] https://crrev.com/5e90846c2c0149b1cc4b4f916bdcc2605ff55ff3/third_party/blink/renderer/devtools/front_end/network/NetworkLogViewColumns.js [modify] https://crrev.com/5e90846c2c0149b1cc4b4f916bdcc2605ff55ff3/third_party/blink/renderer/devtools/front_end/network/NetworkOverview.js [modify] https://crrev.com/5e90846c2c0149b1cc4b4f916bdcc2605ff55ff3/third_party/blink/renderer/devtools/front_end/network/networkLogView.css [modify] https://crrev.com/5e90846c2c0149b1cc4b4f916bdcc2605ff55ff3/third_party/blink/renderer/devtools/front_end/timeline/TimelineUIUtils.js
,
Dec 17
,
Dec 17
,
Dec 18
Approved for M72, branch: 3626.
,
Dec 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/186d1a64ba5a1375a88ac2ea2d9bedd9cbd9cce0 commit 186d1a64ba5a1375a88ac2ea2d9bedd9cbd9cce0 Author: Alexei Filippov <alph@chromium.org> Date: Wed Dec 19 00:13:48 2018 DevTools: Fix the page metric events appearance. Plugged in new colors for events. Changes abbreviation of OL to L for load event. BUG= 914573 TBR=alph@chromium.org (cherry picked from commit 5e90846c2c0149b1cc4b4f916bdcc2605ff55ff3) Change-Id: I68d85cbd72702a9c1e4d30ed1eea321db77f81d3 Reviewed-on: https://chromium-review.googlesource.com/c/1379047 Commit-Queue: Alexei Filippov <alph@chromium.org> Reviewed-by: Paul Irish <paulirish@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#617237} Reviewed-on: https://chromium-review.googlesource.com/c/1383399 Reviewed-by: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#458} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} [modify] https://crrev.com/186d1a64ba5a1375a88ac2ea2d9bedd9cbd9cce0/third_party/blink/renderer/devtools/front_end/network/NetworkLogView.js [modify] https://crrev.com/186d1a64ba5a1375a88ac2ea2d9bedd9cbd9cce0/third_party/blink/renderer/devtools/front_end/network/NetworkLogViewColumns.js [modify] https://crrev.com/186d1a64ba5a1375a88ac2ea2d9bedd9cbd9cce0/third_party/blink/renderer/devtools/front_end/network/NetworkOverview.js [modify] https://crrev.com/186d1a64ba5a1375a88ac2ea2d9bedd9cbd9cce0/third_party/blink/renderer/devtools/front_end/network/networkLogView.css [modify] https://crrev.com/186d1a64ba5a1375a88ac2ea2d9bedd9cbd9cce0/third_party/blink/renderer/devtools/front_end/timeline/TimelineUIUtils.js
,
Dec 19
Here's a summary of the rules that were executed: - OnlyMergeApprovedChange: Rule Failed -- Revision 186d1a64ba5a1375a88ac2ea2d9bedd9cbd9cce0 was merged to refs/branch-heads/3626 branch with no merge approval from a TPM! Please explain why this change was merged to the branch! - AcknowledgeMerge: Notification Required --
,
Dec 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/186d1a64ba5a1375a88ac2ea2d9bedd9cbd9cce0 Commit: 186d1a64ba5a1375a88ac2ea2d9bedd9cbd9cce0 Author: alph@chromium.org Commiter: alph@chromium.org Date: 2018-12-19 00:13:48 +0000 UTC DevTools: Fix the page metric events appearance. Plugged in new colors for events. Changes abbreviation of OL to L for load event. BUG= 914573 TBR=alph@chromium.org (cherry picked from commit 5e90846c2c0149b1cc4b4f916bdcc2605ff55ff3) Change-Id: I68d85cbd72702a9c1e4d30ed1eea321db77f81d3 Reviewed-on: https://chromium-review.googlesource.com/c/1379047 Commit-Queue: Alexei Filippov <alph@chromium.org> Reviewed-by: Paul Irish <paulirish@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#617237} Reviewed-on: https://chromium-review.googlesource.com/c/1383399 Reviewed-by: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#458} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
,
Dec 19
|
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by alph@chromium.org
, Dec 12