New issue
Advanced search Search tips

Issue 914569 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 9
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Remove orphaned apmanager from platform2

Project Member Reported by benchan@google.com, Dec 12

Issue description

apmanager was created for Brillo and is no longer used/maintained. We don't have a use case for it on Chrome OS.
 
Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/74f5c5e520ea761313b5479f8095cbf8b5c6529b

commit 74f5c5e520ea761313b5479f8095cbf8b5c6529b
Author: Ben Chan <benchan@chromium.org>
Date: Tue Dec 18 08:42:39 2018

system_api: drop apmanager headers

apmanager is no longer used or actively maintained.

BUG= chromium:914569 
TEST=Remote trybot runs.

Change-Id: Iaab0657d567647c53e20f12c2054f36307010542
Reviewed-on: https://chromium-review.googlesource.com/1338495
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/74f5c5e520ea761313b5479f8095cbf8b5c6529b/chromeos-base/system_api/system_api-9999.ebuild

Project Member

Comment 3 by bugdroid1@chromium.org, Dec 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/7fdcc82d566019fae03e74ee4bb46057fc9b2c5a

commit 7fdcc82d566019fae03e74ee4bb46057fc9b2c5a
Author: Ben Chan <benchan@chromium.org>
Date: Tue Dec 18 08:42:40 2018

system_api: drop apmanager headers

apmanager is no longer used or actively maintained.

BUG= chromium:914569 
CQ-DEPEND=CL:1338495
TEST=Remote trybot runs.

Change-Id: Ib947953af909496ad433c33c9f813efa1dfc786d
Reviewed-on: https://chromium-review.googlesource.com/1338212
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[delete] https://crrev.com/38f569ad164bedc1c1c3c2acc5f51cce5afc5505/system_api/dbus/apmanager/dbus-constants.h
[modify] https://crrev.com/7fdcc82d566019fae03e74ee4bb46057fc9b2c5a/system_api/dbus/service_constants.h

Project Member

Comment 5 by bugdroid1@chromium.org, Jan 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/dceb27b8d25c63cd99723824a1d98c2a2d9923d2

commit dceb27b8d25c63cd99723824a1d98c2a2d9923d2
Author: Ben Chan <benchan@chromium.org>
Date: Tue Jan 08 03:40:58 2019

apmanager: drop project

apmanager is no longer used or actively maintained.

BUG= chromium:914569 
CQ-DEPEND=CL:1338496
TEST=Remote trybot runs.

Change-Id: I0a5427cd0c2207ff3a130f0a3ab62e259c208960
Reviewed-on: https://chromium-review.googlesource.com/1338213
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Ben Chan <benchan@chromium.org>

[delete] https://crrev.com/afb59ae4c00d9f45b0b4210c4867e0d7173ef655/apmanager/firewall_manager.cc
[delete] https://crrev.com/afb59ae4c00d9f45b0b4210c4867e0d7173ef655/apmanager/init/apmanager.conf
[delete] https://crrev.com/afb59ae4c00d9f45b0b4210c4867e0d7173ef655/apmanager/dbus_bindings/org.chromium.apmanager.Manager.dbus-xml
[delete] https://crrev.com/afb59ae4c00d9f45b0b4210c4867e0d7173ef655/apmanager/init/apmanager-seccomp-mips.policy
[delete] https://crrev.com/afb59ae4c00d9f45b0b4210c4867e0d7173ef655/apmanager/hostapd_monitor.cc
[delete] https://crrev.com/afb59ae4c00d9f45b0b4210c4867e0d7173ef655/apmanager/libapmanager-client-test.pc.in
[delete] https://crrev.com/afb59ae4c00d9f45b0b4210c4867e0d7173ef655/apmanager/device_info.h
[delete] https://crrev.com/afb59ae4c00d9f45b0b4210c4867e0d7173ef655/apmanager/shill_stub_proxy.cc
[delete] https://crrev.com/afb59ae4c00d9f45b0b4210c4867e0d7173ef655/apmanager/daemon.h
[delete] https://crrev.com/afb59ae4c00d9f45b0b4210c4867e0d7173ef655/apmanager/dbus/device_dbus_adaptor.cc
[delete] https://crrev.com/afb59ae4c00d9f45b0b4210c4867e0d7173ef655/apmanager/dbus/manager_dbus_adaptor.h
[delete] https://crrev.com/afb59ae4c00d9f45b0b4210c4867e0d7173ef655/apmanager/mock_service_adaptor.h
[delete] https://crrev.com/afb59ae4c00d9f45b0b4210c4867e0d7173ef655/apmanager/shill_manager.h
[delete] https://crrev.com/afb59ae4c00d9f45b0b4210c4867e0d7173ef655/apmanager/dbus/permission_broker_dbus_proxy.cc
[delete] https://crrev.com/afb59ae4c00d9f45b0b4210c4867e0d7173ef655/apmanager/mock_process_factory.h
[delete] https://crrev.com/afb59ae4c00d9f45b0b4210c4867e0d7173ef655/apmanager/dbus/config_dbus_adaptor.cc
[delete] https://crrev.com/afb59ae4c00d9f45b0b4210c4867e0d7173ef655/apmanager/dbus_bindings/org.chromium.apmanager.Config.dbus-xml
[delete] https://crrev.com/afb59ae4c00d9f45b0b4210c4867e0d7173ef655/apmanager/manager_adaptor_interface.h
[delete] https://crrev.com/afb59ae4c00d9f45b0b4210c4867e0d7173ef655/apmanager/device_test.cc
[delete] https://crrev.com/afb59ae4c00d9f45b0b4210c4867e0d7173ef655/apmanager/mock_hostapd_monitor.cc
[delete] https://crrev.com/afb59ae4c00d9f45b0b4210c4867e0d7173ef655/apmanager/shill_stub_proxy.h
[delete] https://crrev.com/afb59ae4c00d9f45b0b4210c4867e0d7173ef655/apmanager/dbus/permission_broker_dbus_proxy.h
[delete] https://crrev.com/afb59ae4c00d9f45b0b4210c4867e0d7173ef655/apmanager/dbus_permissions/org.chromium.apmanager.conf
[delete] https://crrev.com/afb59ae4c00d9f45b0b4210c4867e0d7173ef655/apmanager/dbus/shill_dbus_proxy.h
[delete] https://crrev.com/afb59ae4c00d9f45b0b4210c4867e0d7173ef655/apmanager/daemon.cc
[delete] https://crrev.com/afb59ae4c00d9f45b0b4210c4867e0d7173ef655/apmanager/fake_config_adaptor.cc
[delete] https://crrev.com/afb59ae4c00d9f45b0b4210c4867e0d7173ef655/apmanager/rpc_interface.h
[delete] https://crrev.com/afb59ae4c00d9f45b0b4210c4867e0d7173ef655/apmanager/process_factory.cc
[delete] https://crrev.com/afb59ae4c00d9f45b0b4210c4867e0d7173ef655/apmanager/mock_dhcp_server_factory.h
[delete] https://crrev.com/afb59ae4c00d9f45b0b4210c4867e0d7173ef655/apmanager/mock_file_writer.h
[delete] https://crrev.com/afb59ae4c00d9f45b0b4210c4867e0d7173ef655/apmanager/mock_dhcp_server_factory.cc
[delete] https://crrev.com/afb59ae4c00d9f45b0b4210c4867e0d7173ef655/apmanager/dbus_bindings/dbus-service-config.json
[delete] https://crrev.com/afb59ae4c00d9f45b0b4210c4867e0d7173ef655/apmanager/file_writer.cc
[delete] https://crrev.com/afb59ae4c00d9f45b0b4210c4867e0d7173ef655/apmanager/device_info.cc
[delete] https://crrev.com/afb59ae4c00d9f45b0b4210c4867e0d7173ef655/apmanager/OWNERS
[delete] https://crrev.com/afb59ae4c00d9f45b0b4210c4867e0d7173ef655/apmanager/device.h
[delete] https://crrev.com/afb59ae4c00d9f45b0b4210c4867e0d7173ef655/apmanager/manager.h
[delete] https://crrev.com/afb59ae4c00d9f45b0b4210c4867e0d7173ef655/apmanager/error.h
[delete] https://crrev.com/afb59ae4c00d9f45b0b4210c4867e0d7173ef655/apmanager/dhcp_server_factory.h
[delete] https://crrev.com/afb59ae4c00d9f45b0b4210c4867e0d7173ef655/apmanager/service.h
[delete] https://crrev.com/afb59ae4c00d9f45b0b4210c4867e0d7173ef655/apmanager/init/apmanager-seccomp-x86.policy
[delete] https://crrev.com/afb59ae4c00d9f45b0b4210c4867e0d7173ef655/apmanager/mock_hostapd_monitor.h
[delete] https://crrev.com/afb59ae4c00d9f45b0b4210c4867e0d7173ef655/apmanager/service_test.cc
[delete] https://crrev.com/afb59ae4c00d9f45b0b4210c4867e0d7173ef655/apmanager/dhcp_server.h
[delete] https://crrev.com/afb59ae4c00d9f45b0b4210c4867e0d7173ef655/apmanager/mock_device.cc
[delete] https://crrev.com/afb59ae4c00d9f45b0b4210c4867e0d7173ef655/apmanager/mock_process_factory.cc
[delete] https://crrev.com/afb59ae4c00d9f45b0b4210c4867e0d7173ef655/apmanager/device_adaptor_interface.h
[delete] https://crrev.com/afb59ae4c00d9f45b0b4210c4867e0d7173ef655/apmanager/firewall_manager.h
[delete] https://crrev.com/afb59ae4c00d9f45b0b4210c4867e0d7173ef655/apmanager/BUILD.gn
[delete] https://crrev.com/afb59ae4c00d9f45b0b4210c4867e0d7173ef655/apmanager/fake_device_adaptor.h
[delete] https://crrev.com/afb59ae4c00d9f45b0b4210c4867e0d7173ef655/apmanager/service.cc
[delete] https://crrev.com/afb59ae4c00d9f45b0b4210c4867e0d7173ef655/apmanager/dbus/firewalld_dbus_proxy.h
[delete] https://crrev.com/afb59ae4c00d9f45b0b4210c4867e0d7173ef655/apmanager/dhcp_server_test.cc
[delete] https://crrev.com/afb59ae4c00d9f45b0b4210c4867e0d7173ef655/apmanager/mock_config.h
[delete] https://crrev.com/afb59ae4c00d9f45b0b4210c4867e0d7173ef655/apmanager/fake_config_adaptor.h
[delete] https://crrev.com/afb59ae4c00d9f45b0b4210c4867e0d7173ef655/apmanager/mock_dhcp_server.cc
[delete] https://crrev.com/afb59ae4c00d9f45b0b4210c4867e0d7173ef655/apmanager/shill_manager.cc
[delete] https://crrev.com/afb59ae4c00d9f45b0b4210c4867e0d7173ef655/apmanager/fake_device_adaptor.cc
[delete] https://crrev.com/afb59ae4c00d9f45b0b4210c4867e0d7173ef655/apmanager/manager_test.cc
[delete] https://crrev.com/afb59ae4c00d9f45b0b4210c4867e0d7173ef655/apmanager/dbus_bindings/org.chromium.apmanager.Service.dbus-xml
[delete] https://crrev.com/afb59ae4c00d9f45b0b4210c4867e0d7173ef655/apmanager/hostapd_monitor.h
[delete] https://crrev.com/afb59ae4c00d9f45b0b4210c4867e0d7173ef655/apmanager/manager.cc
[delete] https://crrev.com/afb59ae4c00d9f45b0b4210c4867e0d7173ef655/apmanager/config_test.cc
[delete] https://crrev.com/afb59ae4c00d9f45b0b4210c4867e0d7173ef655/apmanager/dbus/manager_dbus_adaptor.cc
[delete] https://crrev.com/afb59ae4c00d9f45b0b4210c4867e0d7173ef655/apmanager/main.cc
[delete] https://crrev.com/afb59ae4c00d9f45b0b4210c4867e0d7173ef655/apmanager/service_adaptor_interface.h
[delete] https://crrev.com/afb59ae4c00d9f45b0b4210c4867e0d7173ef655/apmanager/dbus_bindings/org.chromium.apmanager.Device.dbus-xml
[delete] https://crrev.com/afb59ae4c00d9f45b0b4210c4867e0d7173ef655/apmanager/dbus/config_dbus_adaptor.h
[delete] https://crrev.com/afb59ae4c00d9f45b0b4210c4867e0d7173ef655/apmanager/config.h
[delete] https://crrev.com/afb59ae4c00d9f45b0b4210c4867e0d7173ef655/apmanager/mock_service.h
[delete] https://crrev.com/afb59ae4c00d9f45b0b4210c4867e0d7173ef655/apmanager/error_test.cc
[delete] https://crrev.com/afb59ae4c00d9f45b0b4210c4867e0d7173ef655/apmanager/process_factory.h
[modify] https://crrev.com/dceb27b8d25c63cd99723824a1d98c2a2d9923d2/README.md
[delete] https://crrev.com/afb59ae4c00d9f45b0b4210c4867e0d7173ef655/apmanager/libapmanager-client.pc.in
[delete] https://crrev.com/afb59ae4c00d9f45b0b4210c4867e0d7173ef655/apmanager/mock_config.cc
[delete] https://crrev.com/afb59ae4c00d9f45b0b4210c4867e0d7173ef655/apmanager/dbus/dbus_control.h
[delete] https://crrev.com/afb59ae4c00d9f45b0b4210c4867e0d7173ef655/apmanager/device.cc
[modify] https://crrev.com/dceb27b8d25c63cd99723824a1d98c2a2d9923d2/common-mk/check-readme.py
[delete] https://crrev.com/afb59ae4c00d9f45b0b4210c4867e0d7173ef655/apmanager/event_dispatcher.cc
[delete] https://crrev.com/afb59ae4c00d9f45b0b4210c4867e0d7173ef655/apmanager/mock_control.h
[delete] https://crrev.com/afb59ae4c00d9f45b0b4210c4867e0d7173ef655/apmanager/dbus/device_dbus_adaptor.h
[delete] https://crrev.com/afb59ae4c00d9f45b0b4210c4867e0d7173ef655/apmanager/mock_manager.cc
[delete] https://crrev.com/afb59ae4c00d9f45b0b4210c4867e0d7173ef655/apmanager/shill_proxy_interface.h
[delete] https://crrev.com/afb59ae4c00d9f45b0b4210c4867e0d7173ef655/apmanager/dbus/service_dbus_adaptor.cc
[delete] https://crrev.com/afb59ae4c00d9f45b0b4210c4867e0d7173ef655/apmanager/mock_event_dispatcher.cc
[delete] https://crrev.com/afb59ae4c00d9f45b0b4210c4867e0d7173ef655/apmanager/dbus/firewalld_dbus_proxy.cc
[delete] https://crrev.com/afb59ae4c00d9f45b0b4210c4867e0d7173ef655/apmanager/event_dispatcher.h
[delete] https://crrev.com/afb59ae4c00d9f45b0b4210c4867e0d7173ef655/apmanager/mock_manager.h
[delete] https://crrev.com/afb59ae4c00d9f45b0b4210c4867e0d7173ef655/apmanager/firewall_proxy_interface.h
[delete] https://crrev.com/afb59ae4c00d9f45b0b4210c4867e0d7173ef655/apmanager/mock_file_writer.cc
[delete] https://crrev.com/afb59ae4c00d9f45b0b4210c4867e0d7173ef655/apmanager/config.cc
[delete] https://crrev.com/afb59ae4c00d9f45b0b4210c4867e0d7173ef655/apmanager/dbus/service_dbus_adaptor.h
[delete] https://crrev.com/afb59ae4c00d9f45b0b4210c4867e0d7173ef655/apmanager/mock_service_adaptor.cc
[delete] https://crrev.com/afb59ae4c00d9f45b0b4210c4867e0d7173ef655/apmanager/mock_event_dispatcher.h
[delete] https://crrev.com/afb59ae4c00d9f45b0b4210c4867e0d7173ef655/apmanager/mock_control.cc
[delete] https://crrev.com/afb59ae4c00d9f45b0b4210c4867e0d7173ef655/apmanager/control_interface.h
[delete] https://crrev.com/afb59ae4c00d9f45b0b4210c4867e0d7173ef655/apmanager/hostapd_monitor_test.cc
[delete] https://crrev.com/afb59ae4c00d9f45b0b4210c4867e0d7173ef655/apmanager/mock_service.cc
[delete] https://crrev.com/afb59ae4c00d9f45b0b4210c4867e0d7173ef655/apmanager/dbus/shill_dbus_proxy.cc
[delete] https://crrev.com/afb59ae4c00d9f45b0b4210c4867e0d7173ef655/apmanager/config_adaptor_interface.h
[delete] https://crrev.com/afb59ae4c00d9f45b0b4210c4867e0d7173ef655/apmanager/mock_device.h
[delete] https://crrev.com/afb59ae4c00d9f45b0b4210c4867e0d7173ef655/apmanager/mock_dhcp_server.h
[delete] https://crrev.com/afb59ae4c00d9f45b0b4210c4867e0d7173ef655/apmanager/dhcp_server_factory.cc
[delete] https://crrev.com/afb59ae4c00d9f45b0b4210c4867e0d7173ef655/apmanager/dbus/dbus_control.cc
[delete] https://crrev.com/afb59ae4c00d9f45b0b4210c4867e0d7173ef655/apmanager/init/apmanager-seccomp-amd64.policy
[delete] https://crrev.com/afb59ae4c00d9f45b0b4210c4867e0d7173ef655/apmanager/file_writer.h
[delete] https://crrev.com/afb59ae4c00d9f45b0b4210c4867e0d7173ef655/apmanager/init/apmanager-seccomp-arm.policy
[delete] https://crrev.com/afb59ae4c00d9f45b0b4210c4867e0d7173ef655/apmanager/device_info_test.cc
[delete] https://crrev.com/afb59ae4c00d9f45b0b4210c4867e0d7173ef655/apmanager/dhcp_server.cc
[delete] https://crrev.com/afb59ae4c00d9f45b0b4210c4867e0d7173ef655/apmanager/error.cc

Status: Fixed (was: Started)

Sign in to add a comment