New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 914565 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Dec 13
Cc:
Components:
EstimatedDays: ----
NextAction: 2018-12-14
OS: Android
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Explore Sites category navigation from the NTP is broken

Project Member Reported by dewittj@chromium.org, Dec 12

Issue description

Recent changes appear to have regressed navigation to partway down the page.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9ff6728935c1da1efb2bee2a708998b3ff0be5a2

commit 9ff6728935c1da1efb2bee2a708998b3ff0be5a2
Author: Justin DeWitt <dewittj@chromium.org>
Date: Thu Dec 13 05:34:50 2018

[EoS] Fix regression in scrolling to a part of the ESP

The state serialization part of the back navigation feature occasionally
saved its state too early in the loading process, resulting in
"restoring" navigation to the top of the page.

This patch creates the tab observer only after loading is completed.

Additionally allows placeholder ntp categories to be rendered.

Bug:  914565 ,  914535 
Change-Id: I764a901b72f656cd61407b12f1989ef418aaa9f6
Reviewed-on: https://chromium-review.googlesource.com/c/1374869
Commit-Queue: Justin DeWitt <dewittj@chromium.org>
Reviewed-by: Cathy Li <chili@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616224}
[modify] https://crrev.com/9ff6728935c1da1efb2bee2a708998b3ff0be5a2/chrome/android/java/src/org/chromium/chrome/browser/explore_sites/ExploreSitesPage.java
[modify] https://crrev.com/9ff6728935c1da1efb2bee2a708998b3ff0be5a2/chrome/android/java/src/org/chromium/chrome/browser/explore_sites/ExploreSitesSection.java
[modify] https://crrev.com/9ff6728935c1da1efb2bee2a708998b3ff0be5a2/chrome/android/javatests/src/org/chromium/chrome/browser/explore_sites/ExploreSitesPageTest.java
[add] https://crrev.com/9ff6728935c1da1efb2bee2a708998b3ff0be5a2/chrome/test/data/android/render_tests/ExploreSitesPageTest.scrolled_to_category_2.Nexus_5-19.png

Labels: -Pri-3 M-72 Pri-1
Status: Fixed (was: Untriaged)
Labels: Merge-TBD
Labels: -Merge-TBD Merge-Request-72
Project Member

Comment 5 by sheriffbot@chromium.org, Dec 13

Labels: -Merge-Request-72 Merge-Review-72 Hotlist-Merge-Review
This bug requires manual review: M72 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
NextAction: 2018-12-14
CL listed at #1 is not in canary yet, pls update bug with canary result tomorrow and justify the merge. Thank you.
The NextAction date has arrived: 2018-12-14
Canary has been manually verified by me and chili@, I will ask jiewu@ to run a full test of the feature on canary and dev (when it updates to the new beta candidate)

* This change has been verified manually and has automated testing
* If for some reason this change has a crasher problem, it can be disabled using a Finch flag
* This change fixes a visible regression in the UI on the NTP.
Labels: -Merge-Review-72 Merge-Approved-72
Approving merge to M72 branch 3626 based on comment #8, pls merge ASAP. Thank you.
Project Member

Comment 10 by bugdroid1@chromium.org, Dec 14

Labels: -merge-approved-72 merge-merged-3626
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/13beb9fc3b94cfa885ff45ac32c4f1d21021b336

commit 13beb9fc3b94cfa885ff45ac32c4f1d21021b336
Author: Justin DeWitt <dewittj@chromium.org>
Date: Fri Dec 14 20:06:19 2018

[EoS] Fix regression in scrolling to a part of the ESP

The state serialization part of the back navigation feature occasionally
saved its state too early in the loading process, resulting in
"restoring" navigation to the top of the page.

This patch creates the tab observer only after loading is completed.

Additionally allows placeholder ntp categories to be rendered.

Bug:  914565 ,  914535 
Change-Id: I764a901b72f656cd61407b12f1989ef418aaa9f6
Reviewed-on: https://chromium-review.googlesource.com/c/1374869
Commit-Queue: Justin DeWitt <dewittj@chromium.org>
Reviewed-by: Cathy Li <chili@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#616224}(cherry picked from commit 9ff6728935c1da1efb2bee2a708998b3ff0be5a2)
Reviewed-on: https://chromium-review.googlesource.com/c/1378808
Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#365}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
[modify] https://crrev.com/13beb9fc3b94cfa885ff45ac32c4f1d21021b336/chrome/android/java/src/org/chromium/chrome/browser/explore_sites/ExploreSitesPage.java
[modify] https://crrev.com/13beb9fc3b94cfa885ff45ac32c4f1d21021b336/chrome/android/java/src/org/chromium/chrome/browser/explore_sites/ExploreSitesSection.java
[modify] https://crrev.com/13beb9fc3b94cfa885ff45ac32c4f1d21021b336/chrome/android/javatests/src/org/chromium/chrome/browser/explore_sites/ExploreSitesPageTest.java
[add] https://crrev.com/13beb9fc3b94cfa885ff45ac32c4f1d21021b336/chrome/test/data/android/render_tests/ExploreSitesPageTest.scrolled_to_category_2.Nexus_5-19.png

Cc: jiewu@chromium.org
Tom, can you please ensure this feature is in the ES test plan and run a test pass on the next beta candidate?
Sure. I will do that. 
As discussed, I created the following bug:
https://bugs.chromium.org/p/chromium/issues/detail?id=915378
Labels: Merge-Merged-72-3626
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/13beb9fc3b94cfa885ff45ac32c4f1d21021b336

Commit: 13beb9fc3b94cfa885ff45ac32c4f1d21021b336
Author: dewittj@chromium.org
Commiter: dewittj@chromium.org
Date: 2018-12-14 20:06:19 +0000 UTC

[EoS] Fix regression in scrolling to a part of the ESP

The state serialization part of the back navigation feature occasionally
saved its state too early in the loading process, resulting in
"restoring" navigation to the top of the page.

This patch creates the tab observer only after loading is completed.

Additionally allows placeholder ntp categories to be rendered.

Bug:  914565 ,  914535 
Change-Id: I764a901b72f656cd61407b12f1989ef418aaa9f6
Reviewed-on: https://chromium-review.googlesource.com/c/1374869
Commit-Queue: Justin DeWitt <dewittj@chromium.org>
Reviewed-by: Cathy Li <chili@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#616224}(cherry picked from commit 9ff6728935c1da1efb2bee2a708998b3ff0be5a2)
Reviewed-on: https://chromium-review.googlesource.com/c/1378808
Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#365}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}

Sign in to add a comment