New issue
Advanced search Search tips

Issue 914548 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Remove dependency on md_header_bar.js

Project Member Reported by qnnguyen@chromium.org, Dec 12

Issue description

Both login and OOBE now use the views login shelf, so we should remove the redundant md_header_bar.js class.

The browser account picker screen seems to use the header bar in some capacity, so we might need to break it up a bit.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a1c0c76376ec6acfffe18b11586ee75541e2f751

commit a1c0c76376ec6acfffe18b11586ee75541e2f751
Author: Quan Nguyen <qnnguyen@chromium.org>
Date: Thu Dec 13 23:01:49 2018

cros: Don't use $('login-header-bar').signinUIState = FOO in OOBE

This CL is the first step towards removing the header bar dependency from OOBE
webUI.

Bug: 914548
Change-Id: I476c6515d9a29ea31f99bf889b70ae80a41c18f0
Reviewed-on: https://chromium-review.googlesource.com/c/1375030
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Commit-Queue: Quan Nguyen <qnnguyen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616467}
[modify] https://crrev.com/a1c0c76376ec6acfffe18b11586ee75541e2f751/chrome/browser/resources/chromeos/login/md_header_bar.js
[modify] https://crrev.com/a1c0c76376ec6acfffe18b11586ee75541e2f751/chrome/browser/resources/chromeos/login/oobe_screen_oauth_enrollment.js
[modify] https://crrev.com/a1c0c76376ec6acfffe18b11586ee75541e2f751/chrome/browser/resources/chromeos/login/screen_confirm_password.js
[modify] https://crrev.com/a1c0c76376ec6acfffe18b11586ee75541e2f751/chrome/browser/resources/chromeos/login/screen_device_disabled.js
[modify] https://crrev.com/a1c0c76376ec6acfffe18b11586ee75541e2f751/chrome/browser/resources/chromeos/login/screen_encryption_migration.js
[modify] https://crrev.com/a1c0c76376ec6acfffe18b11586ee75541e2f751/chrome/browser/resources/chromeos/login/screen_error_message.js
[modify] https://crrev.com/a1c0c76376ec6acfffe18b11586ee75541e2f751/chrome/browser/resources/chromeos/login/screen_gaia_signin.js
[modify] https://crrev.com/a1c0c76376ec6acfffe18b11586ee75541e2f751/chrome/browser/resources/chromeos/login/screen_password_changed.js
[modify] https://crrev.com/a1c0c76376ec6acfffe18b11586ee75541e2f751/chrome/browser/resources/chromeos/login/screen_wrong_hwid.js
[modify] https://crrev.com/a1c0c76376ec6acfffe18b11586ee75541e2f751/ui/login/display_manager.js

Status: Assigned (was: Untriaged)
This issue has an owner, a component and a priority, but is still listed as untriaged or unconfirmed. By definition, this bug is triaged. Changing status to "assigned". Please reach out to me if you disagree with how I've done this.

Sign in to add a comment