Default categories filtered out from NTP when there is no data |
||||
Issue descriptionCanary: - clear all data - go to NTP - see that explore sites panel only has "more" button
,
Dec 14
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/13beb9fc3b94cfa885ff45ac32c4f1d21021b336 commit 13beb9fc3b94cfa885ff45ac32c4f1d21021b336 Author: Justin DeWitt <dewittj@chromium.org> Date: Fri Dec 14 20:06:19 2018 [EoS] Fix regression in scrolling to a part of the ESP The state serialization part of the back navigation feature occasionally saved its state too early in the loading process, resulting in "restoring" navigation to the top of the page. This patch creates the tab observer only after loading is completed. Additionally allows placeholder ntp categories to be rendered. Bug: 914565 , 914535 Change-Id: I764a901b72f656cd61407b12f1989ef418aaa9f6 Reviewed-on: https://chromium-review.googlesource.com/c/1374869 Commit-Queue: Justin DeWitt <dewittj@chromium.org> Reviewed-by: Cathy Li <chili@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#616224}(cherry picked from commit 9ff6728935c1da1efb2bee2a708998b3ff0be5a2) Reviewed-on: https://chromium-review.googlesource.com/c/1378808 Reviewed-by: Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#365} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} [modify] https://crrev.com/13beb9fc3b94cfa885ff45ac32c4f1d21021b336/chrome/android/java/src/org/chromium/chrome/browser/explore_sites/ExploreSitesPage.java [modify] https://crrev.com/13beb9fc3b94cfa885ff45ac32c4f1d21021b336/chrome/android/java/src/org/chromium/chrome/browser/explore_sites/ExploreSitesSection.java [modify] https://crrev.com/13beb9fc3b94cfa885ff45ac32c4f1d21021b336/chrome/android/javatests/src/org/chromium/chrome/browser/explore_sites/ExploreSitesPageTest.java [add] https://crrev.com/13beb9fc3b94cfa885ff45ac32c4f1d21021b336/chrome/test/data/android/render_tests/ExploreSitesPageTest.scrolled_to_category_2.Nexus_5-19.png
,
Dec 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/13beb9fc3b94cfa885ff45ac32c4f1d21021b336 Commit: 13beb9fc3b94cfa885ff45ac32c4f1d21021b336 Author: dewittj@chromium.org Commiter: dewittj@chromium.org Date: 2018-12-14 20:06:19 +0000 UTC [EoS] Fix regression in scrolling to a part of the ESP The state serialization part of the back navigation feature occasionally saved its state too early in the loading process, resulting in "restoring" navigation to the top of the page. This patch creates the tab observer only after loading is completed. Additionally allows placeholder ntp categories to be rendered. Bug: 914565 , 914535 Change-Id: I764a901b72f656cd61407b12f1989ef418aaa9f6 Reviewed-on: https://chromium-review.googlesource.com/c/1374869 Commit-Queue: Justin DeWitt <dewittj@chromium.org> Reviewed-by: Cathy Li <chili@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#616224}(cherry picked from commit 9ff6728935c1da1efb2bee2a708998b3ff0be5a2) Reviewed-on: https://chromium-review.googlesource.com/c/1378808 Reviewed-by: Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#365} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
,
Jan 1
|
||||
►
Sign in to add a comment |
||||
Comment 1 by bugdroid1@chromium.org
, Dec 13