`git cl patch --reapply` gives confusing error message when trying to apply patch from different repo. |
||||
Issue descriptionTo try to reland a reverted patch, I pushed the reland button and copied the url to the new CL then created a new branch and issued these commands: [hi on] (reland=):robertocn@traal:~/infra/build/scripts/slave/recipe_modules/clang_coverage$ git cl issue https://chromium-review.googlesource.com/c/chromium/src/+/1374525 Issue number: 1374525 (https://chromium-review.googlesource.com/1374525) [hi on] (reland=):robertocn@traal:~/infra/build/scripts/slave/recipe_modules/clang_coverage$ git cl patch --reapply [W2018-12-12 13:52:04,685 25473 139884425103104 gerrit_util.py] A transient error occurred while querying chromium-review.googlesource.com: GET https://chromium-review.googlesource.com/a/changes/chromium%2Ftools%2Fbuild~1374525/detail?o=ALL_REVISIONS&o=CURRENT_COMMIT HTTP/1.1 HTTP/1.1 404 Not Found [W2018-12-12 13:52:05,760 25473 139884425103104 gerrit_util.py] A transient error occurred while querying chromium-review.googlesource.com: (... went over all mirrors ...) change 1374525 at https://chromium-review.googlesource.com does not exist or you have no access to it [hi on] (reland=):robertocn@traal:~/infra/build/scripts/slave/recipe_modules/clang_coverage$ The change, however does exist. What gives?
,
Dec 12
+ ehmaldonado@ who is more familiar with these tools I can reproduce something similar but weirder. When I set the issue it's changing the repo: ยป git cl issue https://chromium-review.googlesource.com/c/chromium/src/+/1374525 Issue number: 1374525 (https://chrome-internal-review.googlesource.com/1374525) which more expectedly has issues, but I don't think you're experiencing that based on the output above.
,
Dec 12
Hah! I found the issue. And it seems it's just the user that's broken. I was trying to patch --reapply a change from a different repo. (chromium/src patch onto infra/build) All we can do here is to improve the error messaging. I am not sure if the best place to notify the user is when setting the issue number `git cl issue <blah>`
,
Dec 13
That makes sense, thanks for figuring out the cause and updating the issue summary! |
||||
►
Sign in to add a comment |
||||
Comment 1 by robert...@chromium.org
, Dec 12