When the ET is showing the back button should dismiss it. Currently when the Ephemeral Tab is in the peeking state the back button doesn't dismiss it, it navigates the base page back.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1c2925773851f7c443d8ab3e61ae5526ac5e5e97 commit 1c2925773851f7c443d8ab3e61ae5526ac5e5e97 Author: Jinsuk Kim <jinsukkim@chromium.org> Date: Sat Dec 15 00:32:23 2018 EphemeralTab: Close the panel on back key press Back key press should close the ephemeral tab if shown, not let the base tab go back. This CL handles it. Bug: 914510 Change-Id: Id9b59f406480b3a25fe3e9733ba88753fe789600 Reviewed-on: https://chromium-review.googlesource.com/c/1377249 Reviewed-by: Theresa <twellington@chromium.org> Reviewed-by: Donn Denman <donnd@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#616894} [modify] https://crrev.com/1c2925773851f7c443d8ab3e61ae5526ac5e5e97/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java [modify] https://crrev.com/1c2925773851f7c443d8ab3e61ae5526ac5e5e97/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanel.java [modify] https://crrev.com/1c2925773851f7c443d8ab3e61ae5526ac5e5e97/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanel.java [modify] https://crrev.com/1c2925773851f7c443d8ab3e61ae5526ac5e5e97/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagementDelegate.java [modify] https://crrev.com/1c2925773851f7c443d8ab3e61ae5526ac5e5e97/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java
Comment 1 by donnd@chromium.org
, Dec 12