New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 15
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug

Blocking:
issue 912397



Sign in to add a comment
link

Issue 914510: [Ephemeral Tab] Back button should dismiss

Reported by donnd@chromium.org, Dec 12 Project Member

Issue description

When the ET is showing the back button should dismiss it.  Currently when the Ephemeral Tab is in the peeking state the back button doesn't dismiss it, it navigates the base page back.
 

Comment 1 by donnd@chromium.org, Dec 12

Blocking: 912397

Comment 2 by jinsuk...@chromium.org, Dec 13

Cc: -jinsuk...@chromium.org
Owner: jinsuk...@chromium.org
Status: Started (was: Available)

Comment 3 by bugdroid1@chromium.org, Dec 15

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1c2925773851f7c443d8ab3e61ae5526ac5e5e97

commit 1c2925773851f7c443d8ab3e61ae5526ac5e5e97
Author: Jinsuk Kim <jinsukkim@chromium.org>
Date: Sat Dec 15 00:32:23 2018

EphemeralTab: Close the panel on back key press

Back key press should close the ephemeral tab if shown,
not let the base tab go back. This CL handles it.

Bug:  914510 
Change-Id: Id9b59f406480b3a25fe3e9733ba88753fe789600
Reviewed-on: https://chromium-review.googlesource.com/c/1377249
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Donn Denman <donnd@chromium.org>
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616894}
[modify] https://crrev.com/1c2925773851f7c443d8ab3e61ae5526ac5e5e97/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
[modify] https://crrev.com/1c2925773851f7c443d8ab3e61ae5526ac5e5e97/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanel.java
[modify] https://crrev.com/1c2925773851f7c443d8ab3e61ae5526ac5e5e97/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanel.java
[modify] https://crrev.com/1c2925773851f7c443d8ab3e61ae5526ac5e5e97/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagementDelegate.java
[modify] https://crrev.com/1c2925773851f7c443d8ab3e61ae5526ac5e5e97/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java

Comment 4 by jinsuk...@chromium.org, Dec 15

Status: Fixed (was: Started)

Sign in to add a comment