Refactor AppsGridView to not use translation for UI scale. |
||||||
Issue descriptionWe use transform to adjust AppsGridView for different UI scale. Some things to consider: 1. When UI scale changes, the launcher(usually) closes. 2. On the emulator, changing ui scale is done by resizing the window w/ the mouse. 3. If we don't use transform, for case 2, the app icons jitter due to rounding error. Because case 2 is not reproable on device, we should get rid of the transform, and just call Layout. This will allow us to prevent problems like issue 907914
,
Jan 11
,
Jan 11
,
Jan 11
,
Jan 15
,
Jan 17
(5 days ago)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cfd90688ae6be060fae2ae14fcbaad17b8728843 commit cfd90688ae6be060fae2ae14fcbaad17b8728843 Author: Weidong Guo <weidongg@chromium.org> Date: Thu Jan 17 18:28:01 2019 Fix folder issue in small display Changes: 1. Instead of apply transform to apps grid, apply it to the AppListMainView when apps grid does not fit in small display. 2. Add a separate layer for AppListMainView. 3. Avoid converting point using transform by using local coordiates when calculating the page flip buffer and bottom drag buffer. 4. Clean up unused code. Images: https://screenshot.googleplex.com/XcFxsGn9wfJ https://screenshot.googleplex.com/JkvuTu9FoZY https://screenshot.googleplex.com/Yy6OZfD4NvL Bug: 914509 , 913408 Change-Id: I2030e865b1da26f23940f64454ba7ce514e0e5cf Reviewed-on: https://chromium-review.googlesource.com/c/1413136 Commit-Queue: Weidong Guo <weidongg@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#623760} [modify] https://crrev.com/cfd90688ae6be060fae2ae14fcbaad17b8728843/ash/app_list/views/app_list_main_view.cc [modify] https://crrev.com/cfd90688ae6be060fae2ae14fcbaad17b8728843/ash/app_list/views/app_list_view.cc [modify] https://crrev.com/cfd90688ae6be060fae2ae14fcbaad17b8728843/ash/app_list/views/apps_container_view.cc [modify] https://crrev.com/cfd90688ae6be060fae2ae14fcbaad17b8728843/ash/app_list/views/apps_container_view.h [modify] https://crrev.com/cfd90688ae6be060fae2ae14fcbaad17b8728843/ash/app_list/views/apps_grid_view.cc [modify] https://crrev.com/cfd90688ae6be060fae2ae14fcbaad17b8728843/ash/app_list/views/apps_grid_view.h [modify] https://crrev.com/cfd90688ae6be060fae2ae14fcbaad17b8728843/ash/app_list/views/contents_view.cc [modify] https://crrev.com/cfd90688ae6be060fae2ae14fcbaad17b8728843/ash/app_list/views/contents_view.h [modify] https://crrev.com/cfd90688ae6be060fae2ae14fcbaad17b8728843/ash/app_list/views/horizontal_page_container.cc
,
Jan 17
(5 days ago)
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by kaznacheev@chromium.org
, Dec 14