Request the install of the VR DFM at Chrome start on Daydream-ready devices. By doing so, the DFM will hopefully be available when the user tries to enter Chrome from VR.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4ca801964f8b02b19554be114d95d62dcdd1e319 commit 4ca801964f8b02b19554be114d95d62dcdd1e319 Author: Tibor Goldschwendt <tiborg@chromium.org> Date: Mon Jan 21 16:09:58 2019 [vr] Deferred install module at startup on Daydream-ready devices + Consolidate VR initialization after module install. + Add ability to have instrumentation tests that expect the module not be installed. + Add instrumentation test for startup install request. TBR=mthiesse@chromium.org Bug: 914499 Change-Id: I4819734e5826d1b3919779046b1ab864f29241b0 Reviewed-on: https://chromium-review.googlesource.com/c/1412532 Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by: Michael Thiessen <mthiesse@chromium.org> Reviewed-by: agrieve <agrieve@chromium.org> Reviewed-by: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#624597} [modify] https://crrev.com/4ca801964f8b02b19554be114d95d62dcdd1e319/chrome/android/BUILD.gn [modify] https://crrev.com/4ca801964f8b02b19554be114d95d62dcdd1e319/chrome/android/chrome_public_apk_tmpl.gni [modify] https://crrev.com/4ca801964f8b02b19554be114d95d62dcdd1e319/chrome/android/java/src/org/chromium/chrome/browser/vr/VrDelegate.java [modify] https://crrev.com/4ca801964f8b02b19554be114d95d62dcdd1e319/chrome/android/java/src/org/chromium/chrome/browser/vr/VrDelegateFallback.java [modify] https://crrev.com/4ca801964f8b02b19554be114d95d62dcdd1e319/chrome/android/java/src/org/chromium/chrome/browser/vr/VrDelegateImpl.java [modify] https://crrev.com/4ca801964f8b02b19554be114d95d62dcdd1e319/chrome/android/java/src/org/chromium/chrome/browser/vr/VrModuleProvider.java [modify] https://crrev.com/4ca801964f8b02b19554be114d95d62dcdd1e319/chrome/android/java/src/org/chromium/chrome/browser/vr/VrShellDelegate.java [modify] https://crrev.com/4ca801964f8b02b19554be114d95d62dcdd1e319/chrome/android/javatests/DEPS [modify] https://crrev.com/4ca801964f8b02b19554be114d95d62dcdd1e319/chrome/android/javatests/src/org/chromium/chrome/browser/vr/TestVrShellDelegate.java [add] https://crrev.com/4ca801964f8b02b19554be114d95d62dcdd1e319/chrome/android/javatests/src/org/chromium/chrome/browser/vr/VrDaydreamReadyModuleInstallTest.java [modify] https://crrev.com/4ca801964f8b02b19554be114d95d62dcdd1e319/chrome/android/javatests/src/org/chromium/chrome/browser/vr/rules/ChromeTabbedActivityVrTestRule.java [modify] https://crrev.com/4ca801964f8b02b19554be114d95d62dcdd1e319/chrome/android/javatests/src/org/chromium/chrome/browser/vr/rules/CustomTabActivityVrTestRule.java [add] https://crrev.com/4ca801964f8b02b19554be114d95d62dcdd1e319/chrome/android/javatests/src/org/chromium/chrome/browser/vr/rules/VrModuleNotInstalled.java [modify] https://crrev.com/4ca801964f8b02b19554be114d95d62dcdd1e319/chrome/android/javatests/src/org/chromium/chrome/browser/vr/rules/WebappActivityVrTestRule.java [modify] https://crrev.com/4ca801964f8b02b19554be114d95d62dcdd1e319/chrome/android/javatests/src/org/chromium/chrome/browser/vr/util/VrTestRuleUtils.java [modify] https://crrev.com/4ca801964f8b02b19554be114d95d62dcdd1e319/components/module_installer/android/BUILD.gn [modify] https://crrev.com/4ca801964f8b02b19554be114d95d62dcdd1e319/components/module_installer/android/java/src-impl/org/chromium/components/module_installer/FakeModuleInstallerBackend.java [modify] https://crrev.com/4ca801964f8b02b19554be114d95d62dcdd1e319/components/module_installer/android/java/src-impl/org/chromium/components/module_installer/ModuleInstaller.java [modify] https://crrev.com/4ca801964f8b02b19554be114d95d62dcdd1e319/components/module_installer/android/java/src-impl/org/chromium/components/module_installer/ModuleInstallerBackend.java [modify] https://crrev.com/4ca801964f8b02b19554be114d95d62dcdd1e319/components/module_installer/android/java/src-impl/org/chromium/components/module_installer/PlayCoreModuleInstallerBackend.java [modify] https://crrev.com/4ca801964f8b02b19554be114d95d62dcdd1e319/components/module_installer/android/java/src-stub/org/chromium/components/module_installer/ModuleInstaller.java [add] https://crrev.com/4ca801964f8b02b19554be114d95d62dcdd1e319/components/module_installer/android/java/src-test/org/chromium/components/module_installer/ModuleInstaller.java
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b213bde773c619cce27a19c8ea315aa61dfe5357 commit b213bde773c619cce27a19c8ea315aa61dfe5357 Author: Findit <findit-for-me@appspot.gserviceaccount.com> Date: Mon Jan 21 17:25:22 2019 Revert "[vr] Deferred install module at startup on Daydream-ready devices" This reverts commit 4ca801964f8b02b19554be114d95d62dcdd1e319. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 624597 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzRjYTgwMTk2NGY4YjAyYjE5NTU0YmUxMTRkOTVkNjJkY2RkMWUzMTkM Sample Failed Build: https://ci.chromium.org/buildbot/chromium/android-rel/7250 Sample Failed Step: compile Original change's description: > [vr] Deferred install module at startup on Daydream-ready devices > > + Consolidate VR initialization after module install. > > + Add ability to have instrumentation tests that expect the module not > be installed. > > + Add instrumentation test for startup install request. > > TBR=mthiesse@chromium.org > > Bug: 914499 > Change-Id: I4819734e5826d1b3919779046b1ab864f29241b0 > Reviewed-on: https://chromium-review.googlesource.com/c/1412532 > Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> > Reviewed-by: Michael Thiessen <mthiesse@chromium.org> > Reviewed-by: agrieve <agrieve@chromium.org> > Reviewed-by: Brian Sheedy <bsheedy@chromium.org> > Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#624597} Change-Id: I8279f638b8a3d366114b87b6c755e585abde08ad No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 914499 Reviewed-on: https://chromium-review.googlesource.com/c/1425557 Cr-Commit-Position: refs/heads/master@{#624604} [modify] https://crrev.com/b213bde773c619cce27a19c8ea315aa61dfe5357/chrome/android/BUILD.gn [modify] https://crrev.com/b213bde773c619cce27a19c8ea315aa61dfe5357/chrome/android/chrome_public_apk_tmpl.gni [modify] https://crrev.com/b213bde773c619cce27a19c8ea315aa61dfe5357/chrome/android/java/src/org/chromium/chrome/browser/vr/VrDelegate.java [modify] https://crrev.com/b213bde773c619cce27a19c8ea315aa61dfe5357/chrome/android/java/src/org/chromium/chrome/browser/vr/VrDelegateFallback.java [modify] https://crrev.com/b213bde773c619cce27a19c8ea315aa61dfe5357/chrome/android/java/src/org/chromium/chrome/browser/vr/VrDelegateImpl.java [modify] https://crrev.com/b213bde773c619cce27a19c8ea315aa61dfe5357/chrome/android/java/src/org/chromium/chrome/browser/vr/VrModuleProvider.java [modify] https://crrev.com/b213bde773c619cce27a19c8ea315aa61dfe5357/chrome/android/java/src/org/chromium/chrome/browser/vr/VrShellDelegate.java [modify] https://crrev.com/b213bde773c619cce27a19c8ea315aa61dfe5357/chrome/android/javatests/DEPS [modify] https://crrev.com/b213bde773c619cce27a19c8ea315aa61dfe5357/chrome/android/javatests/src/org/chromium/chrome/browser/vr/TestVrShellDelegate.java [delete] https://crrev.com/a37d56fb71b13f93cd25dffc786c5916f65d385d/chrome/android/javatests/src/org/chromium/chrome/browser/vr/VrDaydreamReadyModuleInstallTest.java [modify] https://crrev.com/b213bde773c619cce27a19c8ea315aa61dfe5357/chrome/android/javatests/src/org/chromium/chrome/browser/vr/rules/ChromeTabbedActivityVrTestRule.java [modify] https://crrev.com/b213bde773c619cce27a19c8ea315aa61dfe5357/chrome/android/javatests/src/org/chromium/chrome/browser/vr/rules/CustomTabActivityVrTestRule.java [delete] https://crrev.com/a37d56fb71b13f93cd25dffc786c5916f65d385d/chrome/android/javatests/src/org/chromium/chrome/browser/vr/rules/VrModuleNotInstalled.java [modify] https://crrev.com/b213bde773c619cce27a19c8ea315aa61dfe5357/chrome/android/javatests/src/org/chromium/chrome/browser/vr/rules/WebappActivityVrTestRule.java [modify] https://crrev.com/b213bde773c619cce27a19c8ea315aa61dfe5357/chrome/android/javatests/src/org/chromium/chrome/browser/vr/util/VrTestRuleUtils.java [modify] https://crrev.com/b213bde773c619cce27a19c8ea315aa61dfe5357/components/module_installer/android/BUILD.gn [modify] https://crrev.com/b213bde773c619cce27a19c8ea315aa61dfe5357/components/module_installer/android/java/src-impl/org/chromium/components/module_installer/FakeModuleInstallerBackend.java [modify] https://crrev.com/b213bde773c619cce27a19c8ea315aa61dfe5357/components/module_installer/android/java/src-impl/org/chromium/components/module_installer/ModuleInstaller.java [modify] https://crrev.com/b213bde773c619cce27a19c8ea315aa61dfe5357/components/module_installer/android/java/src-impl/org/chromium/components/module_installer/ModuleInstallerBackend.java [modify] https://crrev.com/b213bde773c619cce27a19c8ea315aa61dfe5357/components/module_installer/android/java/src-impl/org/chromium/components/module_installer/PlayCoreModuleInstallerBackend.java [modify] https://crrev.com/b213bde773c619cce27a19c8ea315aa61dfe5357/components/module_installer/android/java/src-stub/org/chromium/components/module_installer/ModuleInstaller.java [delete] https://crrev.com/a37d56fb71b13f93cd25dffc786c5916f65d385d/components/module_installer/android/java/src-test/org/chromium/components/module_installer/ModuleInstaller.java
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8d6272c6c6212608b368f4509b7151917dcd77cc commit 8d6272c6c6212608b368f4509b7151917dcd77cc Author: Tibor Goldschwendt <tiborg@chromium.org> Date: Mon Jan 21 21:04:47 2019 Reland "[vr] Deferred install module at startup on Daydream-ready devices" This is a reland of 4ca801964f8b02b19554be114d95d62dcdd1e319 Original change's description: > [vr] Deferred install module at startup on Daydream-ready devices > > + Consolidate VR initialization after module install. > > + Add ability to have instrumentation tests that expect the module not > be installed. > > + Add instrumentation test for startup install request. > > TBR=mthiesse@chromium.org > > Bug: 914499 > Change-Id: I4819734e5826d1b3919779046b1ab864f29241b0 > Reviewed-on: https://chromium-review.googlesource.com/c/1412532 > Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> > Reviewed-by: Michael Thiessen <mthiesse@chromium.org> > Reviewed-by: agrieve <agrieve@chromium.org> > Reviewed-by: Brian Sheedy <bsheedy@chromium.org> > Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#624597} TBR=agrieve@chromium.org,mthiesse@chromium.org,bsheedy@chromium.org Bug: 914499 Change-Id: If8b7108f2cd56327c68a4a717a775db124348c7b Reviewed-on: https://chromium-review.googlesource.com/c/1425358 Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#624668} [modify] https://crrev.com/8d6272c6c6212608b368f4509b7151917dcd77cc/chrome/android/BUILD.gn [modify] https://crrev.com/8d6272c6c6212608b368f4509b7151917dcd77cc/chrome/android/chrome_public_apk_tmpl.gni [modify] https://crrev.com/8d6272c6c6212608b368f4509b7151917dcd77cc/chrome/android/java/src/org/chromium/chrome/browser/vr/VrDelegate.java [modify] https://crrev.com/8d6272c6c6212608b368f4509b7151917dcd77cc/chrome/android/java/src/org/chromium/chrome/browser/vr/VrDelegateFallback.java [modify] https://crrev.com/8d6272c6c6212608b368f4509b7151917dcd77cc/chrome/android/java/src/org/chromium/chrome/browser/vr/VrDelegateImpl.java [modify] https://crrev.com/8d6272c6c6212608b368f4509b7151917dcd77cc/chrome/android/java/src/org/chromium/chrome/browser/vr/VrModuleProvider.java [modify] https://crrev.com/8d6272c6c6212608b368f4509b7151917dcd77cc/chrome/android/java/src/org/chromium/chrome/browser/vr/VrShellDelegate.java [modify] https://crrev.com/8d6272c6c6212608b368f4509b7151917dcd77cc/chrome/android/javatests/DEPS [modify] https://crrev.com/8d6272c6c6212608b368f4509b7151917dcd77cc/chrome/android/javatests/src/org/chromium/chrome/browser/vr/TestVrShellDelegate.java [add] https://crrev.com/8d6272c6c6212608b368f4509b7151917dcd77cc/chrome/android/javatests/src/org/chromium/chrome/browser/vr/VrDaydreamReadyModuleInstallTest.java [modify] https://crrev.com/8d6272c6c6212608b368f4509b7151917dcd77cc/chrome/android/javatests/src/org/chromium/chrome/browser/vr/rules/ChromeTabbedActivityVrTestRule.java [modify] https://crrev.com/8d6272c6c6212608b368f4509b7151917dcd77cc/chrome/android/javatests/src/org/chromium/chrome/browser/vr/rules/CustomTabActivityVrTestRule.java [add] https://crrev.com/8d6272c6c6212608b368f4509b7151917dcd77cc/chrome/android/javatests/src/org/chromium/chrome/browser/vr/rules/VrModuleNotInstalled.java [modify] https://crrev.com/8d6272c6c6212608b368f4509b7151917dcd77cc/chrome/android/javatests/src/org/chromium/chrome/browser/vr/rules/WebappActivityVrTestRule.java [modify] https://crrev.com/8d6272c6c6212608b368f4509b7151917dcd77cc/chrome/android/javatests/src/org/chromium/chrome/browser/vr/util/VrTestRuleUtils.java [modify] https://crrev.com/8d6272c6c6212608b368f4509b7151917dcd77cc/components/module_installer/android/BUILD.gn [modify] https://crrev.com/8d6272c6c6212608b368f4509b7151917dcd77cc/components/module_installer/android/java/src-impl/org/chromium/components/module_installer/FakeModuleInstallerBackend.java [modify] https://crrev.com/8d6272c6c6212608b368f4509b7151917dcd77cc/components/module_installer/android/java/src-impl/org/chromium/components/module_installer/ModuleInstaller.java [modify] https://crrev.com/8d6272c6c6212608b368f4509b7151917dcd77cc/components/module_installer/android/java/src-impl/org/chromium/components/module_installer/ModuleInstallerBackend.java [modify] https://crrev.com/8d6272c6c6212608b368f4509b7151917dcd77cc/components/module_installer/android/java/src-impl/org/chromium/components/module_installer/PlayCoreModuleInstallerBackend.java [modify] https://crrev.com/8d6272c6c6212608b368f4509b7151917dcd77cc/components/module_installer/android/java/src-stub/org/chromium/components/module_installer/ModuleInstaller.java [add] https://crrev.com/8d6272c6c6212608b368f4509b7151917dcd77cc/components/module_installer/android/java/src-test/org/chromium/components/module_installer/ModuleInstaller.java
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e1980234649a5cb286f21d24dd1d2b8eab3f19b3 commit e1980234649a5cb286f21d24dd1d2b8eab3f19b3 Author: Tibor Goldschwendt <tiborg@chromium.org> Date: Mon Jan 21 21:27:59 2019 [vr] Deferred install module after update on Daydream-ready devices Bug: 914499 Change-Id: Iaa89dd42a2ddbefe9cf4ca02b861a53e9d2848f7 Reviewed-on: https://chromium-review.googlesource.com/c/1425998 Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by: Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#624678} [modify] https://crrev.com/e1980234649a5cb286f21d24dd1d2b8eab3f19b3/chrome/android/java/src/org/chromium/chrome/browser/upgrade/PackageReplacedBroadcastReceiver.java [modify] https://crrev.com/e1980234649a5cb286f21d24dd1d2b8eab3f19b3/chrome/android/java/src/org/chromium/chrome/browser/vr/VrModuleProvider.java
Comment 1 by tiborg@chromium.org
, Jan 3