New issue
Advanced search Search tips

Issue 914498 link

Starred by 1 user
Status: Fixed
Owner:
tiborg@chromium.org
Closed: Jan 8
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Task
Proj-VR
Proj-XR
Proj-XR-VR

Blocking:
issue 914494



Sign in to add a comment

N+ VR DFM: Indicate to the user that install failed / timed out

Project Member Reported by tiborg@chromium.org, Dec 12 
If the DFM is not available after a timeout, close Chrome (on SVR) or launch it in 2D-in-VR mode (on standalones). After, show an immersive notification with the text "Chrome is still preparing for VR. Try again later." on SVR or a toast with the text "Chrome is still preparing for VR. Restart Chrome later." on standalones.
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f02afbe4d4cf4d32d8ebeeebd01224f5fea850b7

commit f02afbe4d4cf4d32d8ebeeebd01224f5fea850b7
Author: Tibor Goldschwendt <tiborg@chromium.org>
Date: Thu Jan 03 18:01:03 2019

[vr] Show toast in 2D-in-VR telling user that Chrome is getting ready

This toast is shown if the VR module is not installed yet when launching
Chrome on standalone VR headsets.

Bug:  914498 
Change-Id: Iaac05f06e20a40d62dca52916bb158914edb4320
Reviewed-on: https://chromium-review.googlesource.com/c/1393556
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619684}
[modify] https://crrev.com/f02afbe4d4cf4d32d8ebeeebd01224f5fea850b7/chrome/android/java/src/org/chromium/chrome/browser/vr/VrDelegateFallback.java
[modify] https://crrev.com/f02afbe4d4cf4d32d8ebeeebd01224f5fea850b7/chrome/android/java/strings/android_chrome_strings.grd

Comment 2 by tiborg@chromium.org, Jan 3

Labels: VR-DFM
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 8 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8a7d3de4066f3c2b0f2e951fcde2bdbf54e0b1dc

commit 8a7d3de4066f3c2b0f2e951fcde2bdbf54e0b1dc
Author: Tibor Goldschwendt <tiborg@chromium.org>
Date: Tue Jan 08 19:18:10 2019

[vr] Show VR notification if Chrome is started from VR without VR DFM

This indicates to the user that Chrome is still getting ready for VR on
Daydream ready devices. Since we cannot draw any VR UI ourselves without
the VR DFM we resort back to immersive notifications that appear
centered in front of the user.

Change-Id: Iba5a5c9fc0b9c6da1aed55a1ca70452fe1edb948
Bug:  914498 
Reviewed-on: https://chromium-review.googlesource.com/c/1393347
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#620829}
[modify] https://crrev.com/8a7d3de4066f3c2b0f2e951fcde2bdbf54e0b1dc/chrome/android/java/src/org/chromium/chrome/browser/notifications/ChromeNotificationBuilder.java
[modify] https://crrev.com/8a7d3de4066f3c2b0f2e951fcde2bdbf54e0b1dc/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationBuilder.java
[modify] https://crrev.com/8a7d3de4066f3c2b0f2e951fcde2bdbf54e0b1dc/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationCompatBuilder.java
[modify] https://crrev.com/8a7d3de4066f3c2b0f2e951fcde2bdbf54e0b1dc/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationConstants.java
[modify] https://crrev.com/8a7d3de4066f3c2b0f2e951fcde2bdbf54e0b1dc/chrome/android/java/src/org/chromium/chrome/browser/notifications/channels/ChannelDefinitions.java
[modify] https://crrev.com/8a7d3de4066f3c2b0f2e951fcde2bdbf54e0b1dc/chrome/android/java/src/org/chromium/chrome/browser/vr/VrDelegateFallback.java
[modify] https://crrev.com/8a7d3de4066f3c2b0f2e951fcde2bdbf54e0b1dc/chrome/android/java/strings/android_chrome_strings.grd
[add] https://crrev.com/8a7d3de4066f3c2b0f2e951fcde2bdbf54e0b1dc/chrome/android/java/strings/android_chrome_strings_grd/IDS_NOTIFICATION_CATEGORY_VR.png.sha1
[add] https://crrev.com/8a7d3de4066f3c2b0f2e951fcde2bdbf54e0b1dc/chrome/android/java/strings/android_chrome_strings_grd/IDS_VR_PREPARING_VR_NOTIFICATION_BODY.png.sha1
[add] https://crrev.com/8a7d3de4066f3c2b0f2e951fcde2bdbf54e0b1dc/chrome/android/java/strings/android_chrome_strings_grd/IDS_VR_PREPARING_VR_NOTIFICATION_TITLE.png.sha1

Comment 4 by tiborg@chromium.org, Jan 8

Status: Fixed (was: Started)
►

Sign in to add a comment