New issue
Advanced search Search tips

Issue 914494 link

Starred by 1 user
Status: Fixed
Owner:
tiborg@chromium.org
Closed: Yesterday
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Task
Proj-VR
Proj-XR
Proj-XR-VR

Blocked on:
issue 914498
issue 914499
issue 918549
issue 918914
issue 918915
issue 922638
Blocking:
issue 850674



Sign in to add a comment

VR DFM: on-demand install on Daydream-ready devices

Project Member Reported by tiborg@chromium.org, Dec 12 
Summary from doc at [1]: "We will on-demand install the Chrome VR dynamic feature module (DFM) on Daydream-ready devices. We will request the install as soon as Chrome updates or starts. If the user starts Chrome from VR (e.g. through Daydream Home) before the VR DFM is installed we close Chrome (on smartphone VR) or launch it in 2D-in-VR (on standalones) and show a toast that Chrome is getting ready."

This replaces the previous conditional install approach (see issue 862719).

[1] https://docs.google.com/document/d/1T-iuP-5nSZ_YfF9zSxb4GJCH_NyuNvZ1_4rSnUs0Io8

Comment 1 by tiborg@chromium.org, Dec 12

Blocking: 850674

Comment 2 by tiborg@chromium.org, Dec 12

Blockedon: 914498

Comment 3 by tiborg@chromium.org, Dec 12

Blockedon: 914499
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 13 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3e6d27f2d89227b59b81f75cb3a396a01512595c

commit 3e6d27f2d89227b59b81f75cb3a396a01512595c
Author: Tibor Goldschwendt <tiborg@chromium.org>
Date: Thu Dec 13 21:43:09 2018

[vr] On-demand install VR DFM on N+

This requires handling the case when Chrome is started from VR before
the module is installed. For this, move code that is required to
identify VR intents and prevent 2D UI showing up in headset back to the
base module. Furthermore, request VR module install when entering Chrome
from VR and set up VR appropriately once the module install was
successful. If the module cannot be installed within a timeout (we need
a timeout so that Daydream does not kick us out of VR because we don't
active VR mode in time) close Chrome on smartphones or launch it in
2D-in-VR mode on standalones.

NOTE: The VR DFM is still not activated in Monochrome. So, this change
won't be active yet.

Bug:  914494 
Change-Id: If37544f3a35b4d01ac924ee874618348d4b6004d
Reviewed-on: https://chromium-review.googlesource.com/c/1372227
Reviewed-by: agrieve <agrieve@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616442}
[modify] https://crrev.com/3e6d27f2d89227b59b81f75cb3a396a01512595c/base/android/java/src/org/chromium/base/compat/ApiHelperForN.java
[modify] https://crrev.com/3e6d27f2d89227b59b81f75cb3a396a01512595c/chrome/android/java/src/org/chromium/chrome/browser/vr/VrDelegate.java
[modify] https://crrev.com/3e6d27f2d89227b59b81f75cb3a396a01512595c/chrome/android/java/src/org/chromium/chrome/browser/vr/VrDelegateFallback.java
[modify] https://crrev.com/3e6d27f2d89227b59b81f75cb3a396a01512595c/chrome/android/java/src/org/chromium/chrome/browser/vr/VrDelegateImpl.java
[modify] https://crrev.com/3e6d27f2d89227b59b81f75cb3a396a01512595c/chrome/android/java/src/org/chromium/chrome/browser/vr/VrDelegateProviderFallback.java
[modify] https://crrev.com/3e6d27f2d89227b59b81f75cb3a396a01512595c/chrome/android/java/src/org/chromium/chrome/browser/vr/VrDelegateProviderImpl.java
[modify] https://crrev.com/3e6d27f2d89227b59b81f75cb3a396a01512595c/chrome/android/java/src/org/chromium/chrome/browser/vr/VrFirstRunActivity.java
[modify] https://crrev.com/3e6d27f2d89227b59b81f75cb3a396a01512595c/chrome/android/java/src/org/chromium/chrome/browser/vr/VrIntentDelegate.java
[add] https://crrev.com/3e6d27f2d89227b59b81f75cb3a396a01512595c/chrome/android/java/src/org/chromium/chrome/browser/vr/VrIntentDelegateFallback.java
[add] https://crrev.com/3e6d27f2d89227b59b81f75cb3a396a01512595c/chrome/android/java/src/org/chromium/chrome/browser/vr/VrIntentDelegateImpl.java
[delete] https://crrev.com/ec94617e848c656e340b8113580f944c09f27e22/chrome/android/java/src/org/chromium/chrome/browser/vr/VrIntentUtils.java
[modify] https://crrev.com/3e6d27f2d89227b59b81f75cb3a396a01512595c/chrome/android/java/src/org/chromium/chrome/browser/vr/VrModuleProvider.java
[modify] https://crrev.com/3e6d27f2d89227b59b81f75cb3a396a01512595c/chrome/android/java/src/org/chromium/chrome/browser/vr/VrShell.java
[modify] https://crrev.com/3e6d27f2d89227b59b81f75cb3a396a01512595c/chrome/android/java/src/org/chromium/chrome/browser/vr/VrShellDelegate.java
[modify] https://crrev.com/3e6d27f2d89227b59b81f75cb3a396a01512595c/chrome/android/java_sources.gni
[modify] https://crrev.com/3e6d27f2d89227b59b81f75cb3a396a01512595c/chrome/android/javatests/src/org/chromium/chrome/browser/vr/util/VrBrowserTransitionUtils.java
[modify] https://crrev.com/3e6d27f2d89227b59b81f75cb3a396a01512595c/chrome/android/javatests/src/org/chromium/chrome/browser/vr/util/VrTestRuleUtils.java
[modify] https://crrev.com/3e6d27f2d89227b59b81f75cb3a396a01512595c/chrome/browser/android/vr/BUILD.gn
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 13 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dcff246e043fe293c9b3a8f46142bf9425f45993

commit dcff246e043fe293c9b3a8f46142bf9425f45993
Author: David Trainor <dtrainor@chromium.org>
Date: Thu Dec 13 23:18:59 2018

Revert "[vr] On-demand install VR DFM on N+"

This reverts commit 3e6d27f2d89227b59b81f75cb3a396a01512595c.

Reason for revert: Causing a compile failure on the builder: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Android%20x64%20Builder%20%28dbg%29/31519

VrIntentDelegate.java:55: error: cannot find symbol
        int animation = VrDelegate.USE_HIDE_ANIMATION ? R.anim.stay_hidden : 0;

  symbol:   variable stay_hidden
  location: class anim
1 error


Original change's description:
> [vr] On-demand install VR DFM on N+
> 
> This requires handling the case when Chrome is started from VR before
> the module is installed. For this, move code that is required to
> identify VR intents and prevent 2D UI showing up in headset back to the
> base module. Furthermore, request VR module install when entering Chrome
> from VR and set up VR appropriately once the module install was
> successful. If the module cannot be installed within a timeout (we need
> a timeout so that Daydream does not kick us out of VR because we don't
> active VR mode in time) close Chrome on smartphones or launch it in
> 2D-in-VR mode on standalones.
> 
> NOTE: The VR DFM is still not activated in Monochrome. So, this change
> won't be active yet.
> 
> Bug:  914494 
> Change-Id: If37544f3a35b4d01ac924ee874618348d4b6004d
> Reviewed-on: https://chromium-review.googlesource.com/c/1372227
> Reviewed-by: agrieve <agrieve@chromium.org>
> Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#616442}

TBR=mthiesse@chromium.org,agrieve@chromium.org,tiborg@chromium.org

Change-Id: I25c203f54e9b8be8371d882133b3123ef233adad
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  914494 
Reviewed-on: https://chromium-review.googlesource.com/c/1377289
Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616478}
[modify] https://crrev.com/dcff246e043fe293c9b3a8f46142bf9425f45993/base/android/java/src/org/chromium/base/compat/ApiHelperForN.java
[modify] https://crrev.com/dcff246e043fe293c9b3a8f46142bf9425f45993/chrome/android/java/src/org/chromium/chrome/browser/vr/VrDelegate.java
[modify] https://crrev.com/dcff246e043fe293c9b3a8f46142bf9425f45993/chrome/android/java/src/org/chromium/chrome/browser/vr/VrDelegateFallback.java
[modify] https://crrev.com/dcff246e043fe293c9b3a8f46142bf9425f45993/chrome/android/java/src/org/chromium/chrome/browser/vr/VrDelegateImpl.java
[modify] https://crrev.com/dcff246e043fe293c9b3a8f46142bf9425f45993/chrome/android/java/src/org/chromium/chrome/browser/vr/VrDelegateProviderFallback.java
[modify] https://crrev.com/dcff246e043fe293c9b3a8f46142bf9425f45993/chrome/android/java/src/org/chromium/chrome/browser/vr/VrDelegateProviderImpl.java
[modify] https://crrev.com/dcff246e043fe293c9b3a8f46142bf9425f45993/chrome/android/java/src/org/chromium/chrome/browser/vr/VrFirstRunActivity.java
[modify] https://crrev.com/dcff246e043fe293c9b3a8f46142bf9425f45993/chrome/android/java/src/org/chromium/chrome/browser/vr/VrIntentDelegate.java
[delete] https://crrev.com/fb8ee2b61b035504fbc27604bcb67ba53e81f788/chrome/android/java/src/org/chromium/chrome/browser/vr/VrIntentDelegateFallback.java
[delete] https://crrev.com/fb8ee2b61b035504fbc27604bcb67ba53e81f788/chrome/android/java/src/org/chromium/chrome/browser/vr/VrIntentDelegateImpl.java
[add] https://crrev.com/dcff246e043fe293c9b3a8f46142bf9425f45993/chrome/android/java/src/org/chromium/chrome/browser/vr/VrIntentUtils.java
[modify] https://crrev.com/dcff246e043fe293c9b3a8f46142bf9425f45993/chrome/android/java/src/org/chromium/chrome/browser/vr/VrModuleProvider.java
[modify] https://crrev.com/dcff246e043fe293c9b3a8f46142bf9425f45993/chrome/android/java/src/org/chromium/chrome/browser/vr/VrShell.java
[modify] https://crrev.com/dcff246e043fe293c9b3a8f46142bf9425f45993/chrome/android/java/src/org/chromium/chrome/browser/vr/VrShellDelegate.java
[modify] https://crrev.com/dcff246e043fe293c9b3a8f46142bf9425f45993/chrome/android/java_sources.gni
[modify] https://crrev.com/dcff246e043fe293c9b3a8f46142bf9425f45993/chrome/android/javatests/src/org/chromium/chrome/browser/vr/util/VrBrowserTransitionUtils.java
[modify] https://crrev.com/dcff246e043fe293c9b3a8f46142bf9425f45993/chrome/android/javatests/src/org/chromium/chrome/browser/vr/util/VrTestRuleUtils.java
[modify] https://crrev.com/dcff246e043fe293c9b3a8f46142bf9425f45993/chrome/browser/android/vr/BUILD.gn
Project Member

Comment 6 by bugdroid1@chromium.org, Dec 14 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d1dd91e45e02d1c7e2bbf1fb91450a72f7d78a19

commit d1dd91e45e02d1c7e2bbf1fb91450a72f7d78a19
Author: Tibor Goldschwendt <tiborg@chromium.org>
Date: Fri Dec 14 18:50:13 2018

Reland "[vr] On-demand install VR DFM on N+"

This is a reland of 3e6d27f2d89227b59b81f75cb3a396a01512595c with fix for
x86 builders (which have VR disabled).

Original change's description:
> [vr] On-demand install VR DFM on N+
>
> This requires handling the case when Chrome is started from VR before
> the module is installed. For this, move code that is required to
> identify VR intents and prevent 2D UI showing up in headset back to the
> base module. Furthermore, request VR module install when entering Chrome
> from VR and set up VR appropriately once the module install was
> successful. If the module cannot be installed within a timeout (we need
> a timeout so that Daydream does not kick us out of VR because we don't
> active VR mode in time) close Chrome on smartphones or launch it in
> 2D-in-VR mode on standalones.
>
> NOTE: The VR DFM is still not activated in Monochrome. So, this change
> won't be active yet.
>
> Bug:  914494 
> Change-Id: If37544f3a35b4d01ac924ee874618348d4b6004d
> Reviewed-on: https://chromium-review.googlesource.com/c/1372227
> Reviewed-by: agrieve <agrieve@chromium.org>
> Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#616442}

TBR=agrieve@chromium.org,mthiesse@chromium.org

Bug:  914494 
Change-Id: I4be696bf60e61e57d3d405e9a594838157244abd
Reviewed-on: https://chromium-review.googlesource.com/c/1377427
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616763}
[modify] https://crrev.com/d1dd91e45e02d1c7e2bbf1fb91450a72f7d78a19/base/android/java/src/org/chromium/base/compat/ApiHelperForN.java
[rename] https://crrev.com/d1dd91e45e02d1c7e2bbf1fb91450a72f7d78a19/chrome/android/java/res/anim/stay_hidden.xml
[modify] https://crrev.com/d1dd91e45e02d1c7e2bbf1fb91450a72f7d78a19/chrome/android/java/src/org/chromium/chrome/browser/vr/VrDelegate.java
[modify] https://crrev.com/d1dd91e45e02d1c7e2bbf1fb91450a72f7d78a19/chrome/android/java/src/org/chromium/chrome/browser/vr/VrDelegateFallback.java
[modify] https://crrev.com/d1dd91e45e02d1c7e2bbf1fb91450a72f7d78a19/chrome/android/java/src/org/chromium/chrome/browser/vr/VrDelegateImpl.java
[modify] https://crrev.com/d1dd91e45e02d1c7e2bbf1fb91450a72f7d78a19/chrome/android/java/src/org/chromium/chrome/browser/vr/VrDelegateProviderFallback.java
[modify] https://crrev.com/d1dd91e45e02d1c7e2bbf1fb91450a72f7d78a19/chrome/android/java/src/org/chromium/chrome/browser/vr/VrDelegateProviderImpl.java
[modify] https://crrev.com/d1dd91e45e02d1c7e2bbf1fb91450a72f7d78a19/chrome/android/java/src/org/chromium/chrome/browser/vr/VrFirstRunActivity.java
[modify] https://crrev.com/d1dd91e45e02d1c7e2bbf1fb91450a72f7d78a19/chrome/android/java/src/org/chromium/chrome/browser/vr/VrIntentDelegate.java
[add] https://crrev.com/d1dd91e45e02d1c7e2bbf1fb91450a72f7d78a19/chrome/android/java/src/org/chromium/chrome/browser/vr/VrIntentDelegateFallback.java
[add] https://crrev.com/d1dd91e45e02d1c7e2bbf1fb91450a72f7d78a19/chrome/android/java/src/org/chromium/chrome/browser/vr/VrIntentDelegateImpl.java
[delete] https://crrev.com/e0006bcec361a8197eb9b16f6e4ec5911b47e95e/chrome/android/java/src/org/chromium/chrome/browser/vr/VrIntentUtils.java
[modify] https://crrev.com/d1dd91e45e02d1c7e2bbf1fb91450a72f7d78a19/chrome/android/java/src/org/chromium/chrome/browser/vr/VrModuleProvider.java
[modify] https://crrev.com/d1dd91e45e02d1c7e2bbf1fb91450a72f7d78a19/chrome/android/java/src/org/chromium/chrome/browser/vr/VrShell.java
[modify] https://crrev.com/d1dd91e45e02d1c7e2bbf1fb91450a72f7d78a19/chrome/android/java/src/org/chromium/chrome/browser/vr/VrShellDelegate.java
[modify] https://crrev.com/d1dd91e45e02d1c7e2bbf1fb91450a72f7d78a19/chrome/android/java_sources.gni
[modify] https://crrev.com/d1dd91e45e02d1c7e2bbf1fb91450a72f7d78a19/chrome/android/javatests/src/org/chromium/chrome/browser/vr/util/VrBrowserTransitionUtils.java
[modify] https://crrev.com/d1dd91e45e02d1c7e2bbf1fb91450a72f7d78a19/chrome/android/javatests/src/org/chromium/chrome/browser/vr/util/VrTestRuleUtils.java
[modify] https://crrev.com/d1dd91e45e02d1c7e2bbf1fb91450a72f7d78a19/chrome/browser/android/vr/BUILD.gn

Comment 7 by tiborg@chromium.org, Jan 2

Blockedon: 918549

Comment 8 by tiborg@chromium.org, Jan 3

Labels: VR-DFM

Comment 9 by tiborg@chromium.org, Jan 3

Blockedon: 918914

Comment 10 by tiborg@chromium.org, Jan 3

Blockedon: 918915

Comment 11 by tiborg@chromium.org, Jan 16 (6 days ago)

Blockedon: 922638
Project Member

Comment 12 by bugdroid1@chromium.org, Jan 18 (5 days ago) 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/09c19b7a67313cd6f4b861ff502eb88be9516cdc

commit 09c19b7a67313cd6f4b861ff502eb88be9516cdc
Author: Tibor Goldschwendt <tiborg@chromium.org>
Date: Fri Jan 18 02:35:05 2019

[vr] Add DFM to Monochrome

Bug:  914494 
Change-Id: Ieec8916279d673059b457544bc5e19321e3f2106
Reviewed-on: https://chromium-review.googlesource.com/c/1415761
Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org>
Commit-Queue: agrieve <agrieve@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623967}
[modify] https://crrev.com/09c19b7a67313cd6f4b861ff502eb88be9516cdc/build/config/android/rules.gni
[modify] https://crrev.com/09c19b7a67313cd6f4b861ff502eb88be9516cdc/chrome/android/BUILD.gn
[modify] https://crrev.com/09c19b7a67313cd6f4b861ff502eb88be9516cdc/chrome/android/chrome_public_apk_tmpl.gni
[modify] https://crrev.com/09c19b7a67313cd6f4b861ff502eb88be9516cdc/chrome/android/modules/vr/vr_module_tmpl.gni
Project Member

Comment 13 by bugdroid1@chromium.org, Jan 18 (4 days ago) 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/clank/internal/apps/+/9c65fa3bc4edec12de537a0ff44cae7655d42a61

commit 9c65fa3bc4edec12de537a0ff44cae7655d42a61
Author: Tibor Goldschwendt <tiborg@google.com>
Date: Fri Jan 18 18:46:33 2019

Comment 14 by tiborg@chromium.org, Yesterday (33 hours ago)

Status: Fixed (was: Started)
►

Sign in to add a comment