New issue
Advanced search Search tips

Issue 914470 link

Starred by 1 user
Status: Fixed
Owner:
tonydeluna@chromium.org
Closed: Dec 21
Cc:
jessejames@chromium.org
r...@chromium.org
tbarzic@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Remove data saver extension recommendation notification

Project Member Reported by tbarzic@chromium.org, Dec 12 
When a user first uses mobile data, they're shown a notification suggesting them to install a data saver extension - when clicked it is supposed to open the extension's page in the Chrome Web Store.
The extension seems to have been recently removed from the web store, so now clicking the notification opens up a 404 page.

Let's remove the notification.

Comment 1 by tonydeluna@chromium.org, Dec 14

Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 14 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/49d89d55ff609a1adc9511866e1b2e0358cd391f

commit 49d89d55ff609a1adc9511866e1b2e0358cd391f
Author: Tony de Luna <tonydeluna@chromium.org>
Date: Fri Dec 14 19:17:34 2018

cros: Remove data saver extension notification

Stop showing chromeos users a notification prompting them to install a
data saver extension the first time they connect with a cellular
connection. Extension was recently removed.

Remove flag 'enable-datasaver-prompt' and deprecate
prefs::kDataSaverPromptsShown.

Add more tests to validate that notifications are only shown once.

Bug:  914470 , 910767
Change-Id: I0c7799d9a57fcb207fcea946a4454b4edc466ef4
Reviewed-on: https://chromium-review.googlesource.com/c/1374581
Commit-Queue: Tony De Luna <tonydeluna@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616779}
[modify] https://crrev.com/49d89d55ff609a1adc9511866e1b2e0358cd391f/chrome/browser/about_flags.cc
[modify] https://crrev.com/49d89d55ff609a1adc9511866e1b2e0358cd391f/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/49d89d55ff609a1adc9511866e1b2e0358cd391f/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/49d89d55ff609a1adc9511866e1b2e0358cd391f/chrome/browser/prefs/browser_prefs.cc
[modify] https://crrev.com/49d89d55ff609a1adc9511866e1b2e0358cd391f/chrome/browser/ui/ash/network/mobile_data_notifications.cc
[modify] https://crrev.com/49d89d55ff609a1adc9511866e1b2e0358cd391f/chrome/browser/ui/ash/network/mobile_data_notifications.h
[modify] https://crrev.com/49d89d55ff609a1adc9511866e1b2e0358cd391f/chrome/browser/ui/ash/network/mobile_data_notifications_unittest.cc
[modify] https://crrev.com/49d89d55ff609a1adc9511866e1b2e0358cd391f/chromeos/chromeos_switches.cc
[modify] https://crrev.com/49d89d55ff609a1adc9511866e1b2e0358cd391f/chromeos/chromeos_switches.h

Comment 3 by arthurhsu@google.com, Dec 14

Components: UI>Browser

Comment 4 by tonydeluna@chromium.org, Dec 21 

tbarzic@ should I request a merge to get this fixed in 72? Or do you think it's ok to wait for 73 ?

Comment 5 by tbarzic@chromium.org, Dec 21

Labels: -M-72 M-73
Status: Fixed (was: Started)
let's just close it

Comment 6 by k...@9to5mac.com, Dec 26 

Did this need to be fixed? The plugin in question seems to still be available. It was last updated on the same day this issue was reported, so perhaps it was only mistakenly removed?
►

Sign in to add a comment