SigninProfileAttributesUpdaterTest failures on Win64, Mac64 and Linux 64 beta official.desktop.continuous builders. |
||||||
Issue descriptionLink to builders : https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/win64%20beta/builds/5832 https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/mac64%20beta/builds/6708 https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/linux64%20beta/builds/6191 Error log : https://logs.chromium.org/logs/chrome/bb/official.desktop.continuous/win64_beta/5832/+/recipes/steps/unit_tests/0/logs/SigninProfileAttributesUpdaterTest.AuthError/0 Error : SigninProfileAttributesUpdaterTest.AuthError (run #1): [ RUN ] SigninProfileAttributesUpdaterTest.AuthError ../../chrome/browser/signin/signin_profile_attributes_updater_unittest.cc(132): error: Value of: entry->IsAuthError() Actual: false Expected: true Stack trace: Backtrace: testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop [0x00000001410F41A7+87] (C:\b\c\b\win64_beta\src\third_party\googletest\src\googletest\src\gtest.cc:843) testing::internal::AssertHelper::operator= [0x00000001410F3D2E+78] (C:\b\c\b\win64_beta\src\third_party\googletest\src\googletest\src\gtest.cc:417) SigninProfileAttributesUpdaterTest_AuthError_Test::TestBody [0x0000000140166F84+1108] (C:\b\c\b\win64_beta\src\chrome\browser\signin\signin_profile_attributes_updater_unittest.cc:132) [ FAILED ] SigninProfileAttributesUpdaterTest.AuthError (4929 ms) Suspected CL : https://chromium.googlesource.com/chromium/src/+/5c244328206e0bde796a7fc8ddf65e8638dc1f5e
,
Dec 13
I could repro the bug and understood the cause. This test relies on this CL to work: https://chromium-review.googlesource.com/c/chromium/src/+/1070154 I'll investigate what is the best way to fix this. One options would be: - do a manual test for this feature on beta and simply disable the automated test. - cherry pick that CL (which is a bit large) - do a branch-specific fix
,
Dec 13
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5958ebb18d6c7d40fd4fa8969a287ca3bca1aaa9 commit 5958ebb18d6c7d40fd4fa8969a287ca3bca1aaa9 Author: David Roger <droger@chromium.org> Date: Thu Dec 13 13:22:14 2018 [signin] Fix SigninProfileAttributesUpdaterTest This CL does a branch-specific fix for SigninProfileAttributesUpdaterTest. This test passes on trunk but not on the branch because it relies on a refactoring: https://chromium-review.googlesource.com/c/chromium/src/+/1070154 This CL fixes the test so that it can pass even without the refactoring. Bug: 914454 Change-Id: I08d4a81a44f0a57f057603dd291ce2e69aefb761 Reviewed-on: https://chromium-review.googlesource.com/c/1375120 Reviewed-by: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#324} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} [modify] https://crrev.com/5958ebb18d6c7d40fd4fa8969a287ca3bca1aaa9/chrome/browser/signin/signin_profile_attributes_updater_unittest.cc
,
Dec 13
Fixed on the branch.
,
Dec 19
Here's a summary of the rules that were executed: - OnlyMergeApprovedChange: Rule Failed -- Revision 5958ebb18d6c7d40fd4fa8969a287ca3bca1aaa9 was merged to refs/branch-heads/3626 branch with no merge approval from a TPM! Please explain why this change was merged to the branch! - AcknowledgeMerge: Notification Required --
,
Dec 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5958ebb18d6c7d40fd4fa8969a287ca3bca1aaa9 Commit: 5958ebb18d6c7d40fd4fa8969a287ca3bca1aaa9 Author: droger@chromium.org Commiter: droger@chromium.org Date: 2018-12-13 13:22:14 +0000 UTC [signin] Fix SigninProfileAttributesUpdaterTest This CL does a branch-specific fix for SigninProfileAttributesUpdaterTest. This test passes on trunk but not on the branch because it relies on a refactoring: https://chromium-review.googlesource.com/c/chromium/src/+/1070154 This CL fixes the test so that it can pass even without the refactoring. Bug: 914454 Change-Id: I08d4a81a44f0a57f057603dd291ce2e69aefb761 Reviewed-on: https://chromium-review.googlesource.com/c/1375120 Reviewed-by: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#324} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
,
Dec 26
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by droger@chromium.org
, Dec 13