New issue
Advanced search Search tips

Issue 914443 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 12
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug-Regression



Sign in to add a comment

components_unittests failures were seen on official.desktop.continuous on Win and Win trunk builders.

Project Member Reported by pbomm...@chromium.org, Dec 12

Issue description

Link to builders :
https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/win%20trunk/builds/99079
https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/win64%20trunk/builds/47712


Error log :
https://logs.chromium.org/logs/chrome/bb/official.desktop.continuous/win_trunk/99018/+/recipes/steps/components_unittests/0/logs/Parameterized_UpdateCheckerTest.UpdateCheckSuccess_1/0


Error :
Parameterized/UpdateCheckerTest.UpdateCheckSuccess/1 (run #1):
 [ RUN      ] Parameterized/UpdateCheckerTest.UpdateCheckSuccess/1
 Received fatal exception EXCEPTION_ACCESS_VIOLATION
 Backtrace:
 	update_client::UpdateCheckerTest_UpdateCheckSuccess_Test::TestBody [0x0000000140B6DB79+16857] (C:\b\c\b\win_trunk\src\components\update_client\update_checker_unittest.cc:344)
 	testing::Test::Run [0x00000001411DC6D0+208] (C:\b\c\b\win_trunk\src\third_party\googletest\src\googletest\src\gtest.cc:2529)
 	testing::TestInfo::Run [0x00000001411DCFE2+226] (C:\b\c\b\win_trunk\src\third_party\googletest\src\googletest\src\gtest.cc:2707)
 	testing::TestCase::Run [0x00000001411DD562+258] (C:\b\c\b\win_trunk\src\third_party\googletest\src\googletest\src\gtest.cc:2824)
 	testing::internal::UnitTestImpl::RunAllTests [0x00000001411E4EEE+638] (C:\b\c\b\win_trunk\src\third_party\googletest\src\googletest\src\gtest.cc:5226)
 	testing::UnitTest::Run [0x00000001411E4BB5+165] (C:\b\c\b\win_trunk\src\third_party\googletest\src\googletest\src\gtest.cc:4835)
 	base::TestSuite::Run [0x0000000142DEEF76+118] (C:\b\c\b\win_trunk\src\base\test\test_suite.cc:294)
 	base::`anonymous namespace'::LaunchUnitTestsInternal [0x0000000142DF0B19+329] (C:\b\c\b\win_trunk\src\base\test\launcher\unit_test_launcher.cc:225)
 	base::LaunchUnitTests [0x0000000142DF099F+159] (C:\b\c\b\win_trunk\src\base\test\launcher\unit_test_launcher.cc:575)
 	main [0x0000000140AC8A6A+58] (C:\b\c\b\win_trunk\src\components\test\run_all_unittests.cc:8)
 	__scrt_common_main_seh [0x000000014557B288+268] (f:\dd\vctools\crt\vcstartup\src\startup\exe_common.inl:283)
 	BaseThreadInitThunk [0x0000000076CE59BD+13]
 	RtlUserThreadStart [0x0000000076F1A2E1+33]



 
Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9b80e27d30c5638ac95beff7c5ea959d08cccc4d

commit 9b80e27d30c5638ac95beff7c5ea959d08cccc4d
Author: Joshua Pawlicki <waffles@chromium.org>
Date: Wed Dec 12 20:03:58 2018

Remove some updaterstate from test

It is only sent if valid, and isn't valid on machines with no Omaha
(e.g. official builders).

Bug:  914443 
Change-Id: I9d8746557290bc80ede5b3eba8330cce1405e4fd
Reviewed-on: https://chromium-review.googlesource.com/c/1374450
Reviewed-by: Sorin Jianu <sorin@chromium.org>
Commit-Queue: Joshua Pawlicki <waffles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616007}
[modify] https://crrev.com/9b80e27d30c5638ac95beff7c5ea959d08cccc4d/components/update_client/update_checker_unittest.cc

Status: Fixed (was: Started)

Sign in to add a comment