New issue
Advanced search Search tips
Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 14
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug


Participants' hotlists:
md-notifications-desktop


Sign in to add a comment
link

Issue 914437: New style notifications - display of RTL text is inconsistent

Reported by peter@chromium.org, Dec 12 Project Member

Issue description

See attached. Both are exactly the same string of text, but it's left-aligned for the title and right-aligned for the content. I believe that the content example is what's expected.
 
rtl.png
14.1 KB View Download

Comment 1 by peter@chromium.org, Dec 12

As a data point: they're both right-aligned in the original notification style, but not on Android - I believe Android doesn't right-align anything in System UI unless the system direction is set to RTL?

Comment 2 by robliao@chromium.org, Dec 13

Labels: Hotlist-DesktopUIConsider

Comment 3 by robliao@chromium.org, Dec 13

Labels: Group-Notifications

Comment 4 by knollr@chromium.org, Dec 14

Owner: knollr@chromium.org
Status: Started (was: Untriaged)

Comment 5 by bugdroid1@chromium.org, Dec 14

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/685bcc0c2b065d1a51be73a2dac609e4265eea19

commit 685bcc0c2b065d1a51be73a2dac609e4265eea19
Author: Richard Knoll <knollr@chromium.org>
Date: Fri Dec 14 11:27:44 2018

fix: align rtl title in new style notification

New style notifications do not use a BoundedLabel for their title, which
renders RTL content right-aligned. Changed the aligment of the title
Label to gfx::ALIGN_TO_HEAD so that the behaviour is the same for title
and message.

Bug:  914437 
Change-Id: I99a316c6166385aa4f58b52da7cf7a15a6d5d2a9
Reviewed-on: https://chromium-review.googlesource.com/c/1375734
Reviewed-by: Peter Beverloo <peter@chromium.org>
Commit-Queue: Richard Knoll <knollr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616636}
[modify] https://crrev.com/685bcc0c2b065d1a51be73a2dac609e4265eea19/ui/message_center/views/notification_view_md.cc

Comment 6 by knollr@chromium.org, Dec 14

Status: Fixed (was: Started)

Sign in to add a comment