ChromeOsMirrorAccountConsistencyTest fail with network service |
||
Issue descriptionThese tests are passing now, but I'm about to land https://chromium-review.googlesource.com/c/chromium/src/+/1367088 which disable creating a URLRequestContext in the browser process when network service is enabled. That cl made this test fails. Looks like the test was passing incorrectly because it was using the in-process URLRequestContext. The test should be rewritten to make requests not using net/ directly, but to either navigate a frame or use SimpleURLLoader. We also need to fix the underlying feature to set headers in a way that is compatible with network service. looks like this was added in https://chromium-review.googlesource.com/c/chromium/src/+/741803/
,
Dec 19
signin::URLLoaderThrottle implements the header modification logic, so only the test needs to be fixed.
,
Dec 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/076c0bc8b5fc7a58c61ee948f48a4c7c29ee6b02 commit 076c0bc8b5fc7a58c61ee948f48a4c7c29ee6b02 Author: Robbie McElrath <rmcelrath@chromium.org> Date: Wed Dec 19 20:38:14 2018 Refactor ChromeOsMirrorAccountConsistencyTest to not use net/ directly. This is necessary to get the test working with the network service enabled. Bug: 914406 Change-Id: I12cf941dfcdd6e7264a51c50e94bd026af45447e Reviewed-on: https://chromium-review.googlesource.com/c/1383591 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#617936} [modify] https://crrev.com/076c0bc8b5fc7a58c61ee948f48a4c7c29ee6b02/chrome/browser/signin/chromeos_mirror_account_consistency_browsertest.cc [modify] https://crrev.com/076c0bc8b5fc7a58c61ee948f48a4c7c29ee6b02/testing/buildbot/filters/mojo.fyi.chromeos.network_browser_tests.filter
,
Dec 19
|
||
►
Sign in to add a comment |
||
Comment 1 by rmcelrath@chromium.org
, Dec 18Status: Started (was: Unconfirmed)