New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 1 user

Issue metadata

Status: Started
Owner:
Cc:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug

Blocking:
issue 496298



Sign in to add a comment
link

Issue 914393: Need UMAs for installation info

Reported by a...@chromium.org, Dec 12 Project Member

Issue description

On the Mac, we need to update our updating process. We need info about how Chrome is installed in the wild.
 

Comment 1 by a...@chromium.org, Dec 12

Cc: norberg@google.com

Comment 2 by bugdroid1@chromium.org, Dec 12

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/753cb9dffd9887d9ce84ef3d3f546f10f91cf409

commit 753cb9dffd9887d9ce84ef3d3f546f10f91cf409
Author: Avi Drissman <avi@chromium.org>
Date: Wed Dec 12 17:15:20 2018

Add a Mac UMA for the filesystem where Chrome lives.

BUG=914393

Change-Id: Ia9813b162121de8c3763ccafc6525a628370f5ac
Reviewed-on: https://chromium-review.googlesource.com/c/1371936
Commit-Queue: Avi Drissman <avi@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615934}
[modify] https://crrev.com/753cb9dffd9887d9ce84ef3d3f546f10f91cf409/chrome/browser/chrome_browser_main_mac.mm
[modify] https://crrev.com/753cb9dffd9887d9ce84ef3d3f546f10f91cf409/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/753cb9dffd9887d9ce84ef3d3f546f10f91cf409/tools/metrics/histograms/histograms.xml

Comment 3 by bugdroid1@chromium.org, Dec 14

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bc95a5bb05ce462fe6f5c03bf831caf70b1c8fc5

commit bc95a5bb05ce462fe6f5c03bf831caf70b1c8fc5
Author: Avi Drissman <avi@chromium.org>
Date: Fri Dec 14 22:01:35 2018

Add a Mac UMA for other proccesses running from the binary.

BUG=914393

Change-Id: Ic680bc4ec2697c0211c8bfc09cff26591b50bc64
Reviewed-on: https://chromium-review.googlesource.com/c/1374436
Commit-Queue: Avi Drissman <avi@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616839}
[modify] https://crrev.com/bc95a5bb05ce462fe6f5c03bf831caf70b1c8fc5/chrome/browser/chrome_browser_main_mac.mm
[modify] https://crrev.com/bc95a5bb05ce462fe6f5c03bf831caf70b1c8fc5/tools/metrics/histograms/histograms.xml

Comment 4 by avi@google.com, Dec 21

Labels: Merge-Request-72
May we merge these UMAs to 72? We are updating our Mac updater code and we need to know the condition of Chrome in the field.

Comment 5 by avi@google.com, Dec 21

Labels: -Pri-3 Pri-2

Comment 6 by sheriffbot@chromium.org, Dec 21

Project Member
Labels: -Merge-Request-72 Merge-Review-72 Hotlist-Merge-Review
This bug requires manual review: M72 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 7 by abdulsyed@google.com, Dec 21

Labels: -Merge-Review-72 Merge-Approved-72
branch:3626

Comment 8 by bugdroid1@chromium.org, Dec 21

Project Member
Labels: -merge-approved-72 merge-merged-3626
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c4f891379c7fd22c30d54ddb4bd871112ed80df2

commit c4f891379c7fd22c30d54ddb4bd871112ed80df2
Author: Avi Drissman <avi@chromium.org>
Date: Fri Dec 21 20:34:41 2018

Add a Mac UMA for the filesystem where Chrome lives.

BUG=914393

Change-Id: Ia9813b162121de8c3763ccafc6525a628370f5ac
Reviewed-on: https://chromium-review.googlesource.com/c/1371936
Commit-Queue: Avi Drissman <avi@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#615934}(cherry picked from commit 753cb9dffd9887d9ce84ef3d3f546f10f91cf409)
Reviewed-on: https://chromium-review.googlesource.com/c/1388821
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#504}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
[modify] https://crrev.com/c4f891379c7fd22c30d54ddb4bd871112ed80df2/chrome/browser/chrome_browser_main_mac.mm
[modify] https://crrev.com/c4f891379c7fd22c30d54ddb4bd871112ed80df2/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/c4f891379c7fd22c30d54ddb4bd871112ed80df2/tools/metrics/histograms/histograms.xml

Comment 9 by bugdroid1@chromium.org, Dec 21

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1a714daf3fb78aafa914998584cd69bbb503f6cd

commit 1a714daf3fb78aafa914998584cd69bbb503f6cd
Author: Avi Drissman <avi@chromium.org>
Date: Fri Dec 21 20:35:22 2018

Add a Mac UMA for other proccesses running from the binary.

BUG=914393

Change-Id: Ic680bc4ec2697c0211c8bfc09cff26591b50bc64
Reviewed-on: https://chromium-review.googlesource.com/c/1374436
Commit-Queue: Avi Drissman <avi@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#616839}(cherry picked from commit bc95a5bb05ce462fe6f5c03bf831caf70b1c8fc5)
Reviewed-on: https://chromium-review.googlesource.com/c/1388822
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#505}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
[modify] https://crrev.com/1a714daf3fb78aafa914998584cd69bbb503f6cd/chrome/browser/chrome_browser_main_mac.mm
[modify] https://crrev.com/1a714daf3fb78aafa914998584cd69bbb503f6cd/tools/metrics/histograms/histograms.xml

Comment 10 by cr-audit...@appspot.gserviceaccount.com, Dec 21

Project Member
Labels: Merge-Merged-72-3626
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/1a714daf3fb78aafa914998584cd69bbb503f6cd

Commit: 1a714daf3fb78aafa914998584cd69bbb503f6cd
Author: avi@chromium.org
Commiter: avi@chromium.org
Date: 2018-12-21 20:35:22 +0000 UTC

Add a Mac UMA for other proccesses running from the binary.

BUG=914393

Change-Id: Ic680bc4ec2697c0211c8bfc09cff26591b50bc64
Reviewed-on: https://chromium-review.googlesource.com/c/1374436
Commit-Queue: Avi Drissman <avi@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#616839}(cherry picked from commit bc95a5bb05ce462fe6f5c03bf831caf70b1c8fc5)
Reviewed-on: https://chromium-review.googlesource.com/c/1388822
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#505}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}

Comment 11 by cr-audit...@appspot.gserviceaccount.com, Dec 21

Project Member
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/c4f891379c7fd22c30d54ddb4bd871112ed80df2

Commit: c4f891379c7fd22c30d54ddb4bd871112ed80df2
Author: avi@chromium.org
Commiter: avi@chromium.org
Date: 2018-12-21 20:34:41 +0000 UTC

Add a Mac UMA for the filesystem where Chrome lives.

BUG=914393

Change-Id: Ia9813b162121de8c3763ccafc6525a628370f5ac
Reviewed-on: https://chromium-review.googlesource.com/c/1371936
Commit-Queue: Avi Drissman <avi@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#615934}(cherry picked from commit 753cb9dffd9887d9ce84ef3d3f546f10f91cf409)
Reviewed-on: https://chromium-review.googlesource.com/c/1388821
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#504}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}

Comment 12 by bugdroid1@chromium.org, Jan 16

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8bcf1fdb0dfc2a870dc093f228b3b208d1184e66

commit 8bcf1fdb0dfc2a870dc093f228b3b208d1184e66
Author: Avi Drissman <avi@chromium.org>
Date: Wed Jan 16 22:24:44 2019

Add a Mac UMA for fast user switching.

BUG=914393

Change-Id: Ife24dd2508cd912b210299130059d2b818300c27
Reviewed-on: https://chromium-review.googlesource.com/c/1412997
Commit-Queue: Avi Drissman <avi@chromium.org>
Reviewed-by: Sidney San Martín <sdy@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623400}
[modify] https://crrev.com/8bcf1fdb0dfc2a870dc093f228b3b208d1184e66/chrome/browser/chrome_browser_main_mac.mm
[modify] https://crrev.com/8bcf1fdb0dfc2a870dc093f228b3b208d1184e66/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/8bcf1fdb0dfc2a870dc093f228b3b208d1184e66/tools/metrics/histograms/histograms.xml

Comment 13 by bugdroid1@chromium.org, Jan 18

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f316ef44992122636cacb59c97d99575b68c108b

commit f316ef44992122636cacb59c97d99575b68c108b
Author: Avi Drissman <avi@chromium.org>
Date: Fri Jan 18 00:46:05 2019

Add a Mac UMA for finding a staging directory.

BUG=914393

Change-Id: Ia7ac0137972c45bad9e4a1013f21665bd4fac8a8
Reviewed-on: https://chromium-review.googlesource.com/c/1416370
Commit-Queue: Avi Drissman <avi@chromium.org>
Commit-Queue: Mark Mentovai <mark@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623931}
[modify] https://crrev.com/f316ef44992122636cacb59c97d99575b68c108b/chrome/browser/chrome_browser_main_mac.mm
[modify] https://crrev.com/f316ef44992122636cacb59c97d99575b68c108b/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/f316ef44992122636cacb59c97d99575b68c108b/tools/metrics/histograms/histograms.xml

Comment 14 by a...@chromium.org, Jan 22

Labels: Merge-Request-72

Comment 15 by sheriffbot@chromium.org, Jan 22

Project Member
Labels: -Merge-Request-72 Merge-Review-72
This bug requires manual review: We are only 6 days from stable.
Please contact the milestone owner if you have questions.
Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 16 by a...@chromium.org, Jan 22

For the manual review:

This is a request to merge the second two UMA changes (the ones in comments 12 and 13). This is to collect data that will be required for a feature that we'll be forced to support by an external party later this year, so data collection is important. These are small code changes and are safe merges.

Comment 17 by abdulsyed@google.com, Jan 22

Labels: -Merge-Review-72 Merge-Approved-72
Branch:3626

Comment 18 by bugdroid1@chromium.org, Jan 22

Project Member
Labels: -merge-approved-72
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ad37c1effd0c2b07f543b0a6e8c1f7b95753f143

commit ad37c1effd0c2b07f543b0a6e8c1f7b95753f143
Author: Avi Drissman <avi@chromium.org>
Date: Tue Jan 22 17:49:34 2019

Add a Mac UMA for fast user switching.

BUG=914393

Change-Id: Ife24dd2508cd912b210299130059d2b818300c27
Reviewed-on: https://chromium-review.googlesource.com/c/1412997
Commit-Queue: Avi Drissman <avi@chromium.org>
Reviewed-by: Sidney San Martín <sdy@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#623400}(cherry picked from commit 8bcf1fdb0dfc2a870dc093f228b3b208d1184e66)
Reviewed-on: https://chromium-review.googlesource.com/c/1427000
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#753}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
[modify] https://crrev.com/ad37c1effd0c2b07f543b0a6e8c1f7b95753f143/chrome/browser/chrome_browser_main_mac.mm
[modify] https://crrev.com/ad37c1effd0c2b07f543b0a6e8c1f7b95753f143/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/ad37c1effd0c2b07f543b0a6e8c1f7b95753f143/tools/metrics/histograms/histograms.xml

Comment 19 by bugdroid1@chromium.org, Jan 22

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/133a73b78348f91d341427c24ffb5f23cf265fdd

commit 133a73b78348f91d341427c24ffb5f23cf265fdd
Author: Avi Drissman <avi@chromium.org>
Date: Tue Jan 22 17:50:28 2019

Add a Mac UMA for finding a staging directory.

BUG=914393

Change-Id: Ia7ac0137972c45bad9e4a1013f21665bd4fac8a8
Reviewed-on: https://chromium-review.googlesource.com/c/1416370
Commit-Queue: Avi Drissman <avi@chromium.org>
Commit-Queue: Mark Mentovai <mark@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#623931}(cherry picked from commit f316ef44992122636cacb59c97d99575b68c108b)
Reviewed-on: https://chromium-review.googlesource.com/c/1427001
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#754}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
[modify] https://crrev.com/133a73b78348f91d341427c24ffb5f23cf265fdd/chrome/browser/chrome_browser_main_mac.mm
[modify] https://crrev.com/133a73b78348f91d341427c24ffb5f23cf265fdd/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/133a73b78348f91d341427c24ffb5f23cf265fdd/tools/metrics/histograms/histograms.xml

Comment 20 by cr-audit...@appspot.gserviceaccount.com, Jan 22

Project Member
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/133a73b78348f91d341427c24ffb5f23cf265fdd

Commit: 133a73b78348f91d341427c24ffb5f23cf265fdd
Author: avi@chromium.org
Commiter: avi@chromium.org
Date: 2019-01-22 17:50:28 +0000 UTC

Add a Mac UMA for finding a staging directory.

BUG=914393

Change-Id: Ia7ac0137972c45bad9e4a1013f21665bd4fac8a8
Reviewed-on: https://chromium-review.googlesource.com/c/1416370
Commit-Queue: Avi Drissman <avi@chromium.org>
Commit-Queue: Mark Mentovai <mark@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#623931}(cherry picked from commit f316ef44992122636cacb59c97d99575b68c108b)
Reviewed-on: https://chromium-review.googlesource.com/c/1427001
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#754}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}

Comment 21 by cr-audit...@appspot.gserviceaccount.com, Jan 22

Project Member
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/ad37c1effd0c2b07f543b0a6e8c1f7b95753f143

Commit: ad37c1effd0c2b07f543b0a6e8c1f7b95753f143
Author: avi@chromium.org
Commiter: avi@chromium.org
Date: 2019-01-22 17:49:34 +0000 UTC

Add a Mac UMA for fast user switching.

BUG=914393

Change-Id: Ife24dd2508cd912b210299130059d2b818300c27
Reviewed-on: https://chromium-review.googlesource.com/c/1412997
Commit-Queue: Avi Drissman <avi@chromium.org>
Reviewed-by: Sidney San Martín <sdy@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#623400}(cherry picked from commit 8bcf1fdb0dfc2a870dc093f228b3b208d1184e66)
Reviewed-on: https://chromium-review.googlesource.com/c/1427000
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#753}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}

Comment 22 by bugdroid, Feb 16

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4a3246682168b0342bc293f327a663182e79ee4c

commit 4a3246682168b0342bc293f327a663182e79ee4c
Author: Avi Drissman <avi@chromium.org>
Date: Sat Feb 16 02:10:51 2019

Search for persistent staging locations first.

BUG=914393

Change-Id: Ieda541820b186832423126516d878c836de2ffc6
Reviewed-on: https://chromium-review.googlesource.com/c/1475886
Commit-Queue: Avi Drissman <avi@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Auto-Submit: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632854}
[modify] https://crrev.com/4a3246682168b0342bc293f327a663182e79ee4c/chrome/browser/chrome_browser_main_mac.mm
[modify] https://crrev.com/4a3246682168b0342bc293f327a663182e79ee4c/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/4a3246682168b0342bc293f327a663182e79ee4c/tools/metrics/histograms/histograms.xml

Comment 23 by a...@chromium.org, Feb 19 (3 days ago)

Labels: Merge-Request-72 Merge-Request-73
We need this staging data for stable and beta channels.

Comment 24 by sheriffbot@chromium.org, Feb 19 (3 days ago)

Project Member
Labels: -Merge-Request-73 Merge-Review-73
This bug requires manual review: M73 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), cindyb@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 25 by abdulsyed@google.com, Feb 19 (3 days ago)

Labels: -Merge-Request-72 Merge-Rejected-72
Rejecting merge for m72. We are already at 100% stable, and this doesn't appear to be critical to merge to 72 stable. If you disagree, please provide justification for why this is critical for M72 respin.

Comment 26 by abdulsyed@google.com, Feb 19 (3 days ago)

Labels: -Merge-Review-73 Merge-Approved-73
Approving merge to M73, branch:3683

Sign in to add a comment