Lighthouse flags not set properly |
|||||||||||||||
Issue descriptionChrome Version: 71+ OS: Win, Mac, Linux, Chrome What steps will reproduce the problem? (1) open devtools on google.com, audits panel (2) select "Desktop", run (3) see that the viewport is set to mobile What is the expected result? Viewport should be desktop What happens instead? It is mobile. All flags are ignored.
,
Dec 14
RE: request for 71 merge Would like to deploy this trivial code change. OK with it going in the next security update. Current impact is a DevTools Audits panel ignores all options, which is very confusing for users.
,
Dec 14
CL listed at #1 is not in canary yet. Pls update bug with canary result tomorrow. Pls note we're not planning any further M71 respin due to upcoming holidays, unless critical issue arise.
,
Dec 14
Able to reproduce the issue on chrome version 73.0.3638.0(Build without fix) Verified the fix on Mac 10.12.6, Windows-10 & Ubuntu 17.10 on Chrome version #73.0.3640.0 as per the comment#0 Attaching screencast for reference. Observed "Viewport is desktop" Hence, the fix is working as expected. Adding the verified label. Thanks!
,
Dec 14
The NextAction date has arrived: 2018-12-14
,
Dec 14
The bug is marked as P3 or Feature. It should not be merged as M72 is in beta. Please contact the approriate milestone owner if you have questions. Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 14
,
Dec 14
,
Dec 14
This bug requires manual review: M72 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 14
Approving this for M72 branch, 3626.
,
Dec 18
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 18
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f608117a688e3b9f29a11dc635997a6a06e5fb99 commit f608117a688e3b9f29a11dc635997a6a06e5fb99 Author: Paul Irish <paulirish@chromium.org> Date: Tue Dec 18 20:48:20 2018 [DevTools] Audits: Update interface for setting Lighthouse flags TBR=cjamcl@google.com (cherry picked from commit 23c268dc95840a2fcb266f72acfa2aaf1a42b8ab) Bug: 914387 Change-Id: Ice3e79cc8527d687ffdfe87a22ddf8a459230ef2 Reviewed-on: https://chromium-review.googlesource.com/c/1374196 Reviewed-by: Paul Irish <paulirish@chromium.org> Reviewed-by: Erik Luo <luoe@chromium.org> Commit-Queue: Paul Irish <paulirish@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#616360} Reviewed-on: https://chromium-review.googlesource.com/c/1383125 Cr-Commit-Position: refs/branch-heads/3626@{#447} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} [modify] https://crrev.com/f608117a688e3b9f29a11dc635997a6a06e5fb99/third_party/blink/renderer/devtools/front_end/audits2_worker/Audits2Service.js
,
Dec 19
Able to reproduce the issue on chrome version 72.0.3626.17(Build without fix) Verified the fix on Mac 10.13.6, Windows-10 & Ubuntu 17.10 on Chrome version #72.0.3626.28 as per the comment#0 Attaching screencast for reference. Observed "Viewport is desktop" Hence, the fix is working as expected. Adding the verified label. Thanks!
,
Dec 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f608117a688e3b9f29a11dc635997a6a06e5fb99 Commit: f608117a688e3b9f29a11dc635997a6a06e5fb99 Author: paulirish@chromium.org Commiter: paulirish@chromium.org Date: 2018-12-18 20:48:20 +0000 UTC [DevTools] Audits: Update interface for setting Lighthouse flags TBR=cjamcl@google.com (cherry picked from commit 23c268dc95840a2fcb266f72acfa2aaf1a42b8ab) Bug: 914387 Change-Id: Ice3e79cc8527d687ffdfe87a22ddf8a459230ef2 Reviewed-on: https://chromium-review.googlesource.com/c/1374196 Reviewed-by: Paul Irish <paulirish@chromium.org> Reviewed-by: Erik Luo <luoe@chromium.org> Commit-Queue: Paul Irish <paulirish@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#616360} Reviewed-on: https://chromium-review.googlesource.com/c/1383125 Cr-Commit-Position: refs/branch-heads/3626@{#447} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
,
Dec 27
,
Jan 7
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5b061f846eb18add758c5dbfe263fcce59c08408 commit 5b061f846eb18add758c5dbfe263fcce59c08408 Author: cjamcl@google.com <cjamcl@google.com> Date: Mon Jan 07 20:59:57 2019 [DevTools] Audits: add test for flags Bug: 914387 Change-Id: I98fd77034b021b3de85ae6dc6cd30fdd1bd58c5a Reviewed-on: https://chromium-review.googlesource.com/c/1379026 Reviewed-by: Paul Irish <paulirish@chromium.org> Reviewed-by: Erik Luo <luoe@chromium.org> Commit-Queue: Connor Clark <cjamcl@google.com> Cr-Commit-Position: refs/heads/master@{#620465} [add] https://crrev.com/5b061f846eb18add758c5dbfe263fcce59c08408/third_party/blink/web_tests/http/tests/devtools/audits2/audits2-flags-run-expected.txt [add] https://crrev.com/5b061f846eb18add758c5dbfe263fcce59c08408/third_party/blink/web_tests/http/tests/devtools/audits2/audits2-flags-run.js
,
Jan 11
This issue has an owner, a component and a priority, but is still listed as untriaged or unconfirmed. By definition, this bug is triaged. Changing status to "assigned". Please reach out to me if you disagree with how I've done this.
,
Today
(9 hours ago)
|
|||||||||||||||
►
Sign in to add a comment |
|||||||||||||||
Comment 1 by bugdroid1@chromium.org
, Dec 13