New issue
Advanced search Search tips

Issue 914380 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 12
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug
Flaky-Test: AndroidUsbCountTest.TestNoMultipleCallsRemoveAddInCallback



Sign in to add a comment

AndroidUsbCountTest.TestNoMultipleCallsRemoveAddInCallback is flaky

Project Member Reported by xiy...@chromium.org, Dec 12

Issue description

Happening in browser_tests on multiple platform. Cause is similar to 
 issue 883680  that MessageLoopCurrent::Get()->IsIdleForTesting() is flaky.

../../chrome/browser/devtools/device/usb/android_usb_browsertest.cc:726: Failure
Value of: base::MessageLoopCurrent::Get()->IsIdleForTesting()
  Actual: false
Expected: true
Stack trace:
#0 0x563741fc68dc testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop()
#1 0x563741fc62b9 testing::internal::AssertHelper::operator=()
#2 0x563740762122 AndroidUsbCountTest_TestNoMultipleCallsRemoveAddInCallback_Test::RunTestOnMainThread()
#3 0x56374472dfcd content::BrowserTestBase::ProxyRunTestOnMainThreadLoop()
#4 0x5637442ec590 ChromeBrowserMainParts::PreMainMessageLoopRunImpl()
#5 0x5637442eb572 ChromeBrowserMainParts::PreMainMessageLoopRun()
#6 0x563741b25852 chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun()
#7 0x563742b94932 content::BrowserMainLoop::PreMainMessageLoopRun()
#8 0x563742f1f0e7 content::StartupTaskRunner::RunAllTasksNow()
#9 0x563742b9372d content::BrowserMainLoop::CreateStartupTasks()
#10 0x563742b96775 content::BrowserMainRunnerImpl::Initialize()
#11 0x563742b91c32 content::BrowserMain()
#12 0x563743e33b2f content::ContentMainRunnerImpl::RunServiceManager()
#13 0x563743e337b9 content::ContentMainRunnerImpl::Run()
#14 0x563745f3c833 service_manager::Main()
#15 0x563743e31e44 content::ContentMain()
#16 0x56374472dc01 content::BrowserTestBase::SetUp()
#17 0x56374429e144 InProcessBrowserTest::SetUp()


Fails for chromeos single process mash browser tests:
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-rel/17177
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-rel/17178

Fail pass on Linux, Mac, Win
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Tests%20%28dbg%29%281%29/76373
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.11%20Tests/31663
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20Tests%20x64/29921
 
Flaky-Test: AndroidUsbCountTest.TestNoMultipleCallsRemoveAddInCallback
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2b4cda586f3e85c9c86b36aeebf07f8a984b3953

commit 2b4cda586f3e85c9c86b36aeebf07f8a984b3953
Author: Xiyuan Xia <xiyuan@chromium.org>
Date: Wed Dec 12 17:24:05 2018

Remove MessageLoopCurrent::IsIdleForTesting in AndroidUsbCountTest

Testing of message loop idle seems not relevant to the tests
and is bound to be flaky in browser_tests.

Bug:  914380 ,  883680 
Change-Id: Iac6862c995ae105b8451f0cbcb544f64473c0d85
Reviewed-on: https://chromium-review.googlesource.com/c/1374199
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615938}
[modify] https://crrev.com/2b4cda586f3e85c9c86b36aeebf07f8a984b3953/chrome/browser/devtools/device/usb/android_usb_browsertest.cc

Status: Fixed (was: Untriaged)

Sign in to add a comment