New issue
Advanced search Search tips
Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 14
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment
link

Issue 914375: Dawn build: Support for enable_opengl=false

Reported by arthurso...@chromium.org, Dec 12 Project Member

Issue description

In args.gn, if you use the option:
~~~
enable_opengl=false
~~~

Then you will have a linker error:
~~~
[147/175] LINK ./dawn_spirv_cross_hlsl_full_fuzzer
FAILED: dawn_spirv_cross_hlsl_full_fuzzer 
python "../../build/toolchain/gcc_link_wrapper.py" --output="./dawn_spirv_cross_hlsl_full_fuzzer" -- ../../third_party/llvm-build/Release+Asserts/bin/clang++ -Wl,--fatal-warnings -fPIC -Wl,-z,noexecstack -Wl,-z,now -Wl,-z,relro -Wl,-z,defs -Wl,--as-needed -fuse-ld=lld -Wl,--icf=all -Wl,--color-diagnostics -m64 -Werror -Wl,--gdb-index -rdynamic -nostdlib++ --sysroot=../../build/linux/debian_sid_amd64-sysroot -L../../build/linux/debian_sid_amd64-sysroot/usr/local/lib/x86_64-linux-gnu -Wl,-rpath-link=../../build/linux/debian_sid_amd64-sysroot/usr/local/lib/x86_64-linux-gnu -L../../build/linux/debian_sid_amd64-sysroot/lib/x86_64-linux-gnu -Wl,-rpath-link=../../build/linux/debian_sid_amd64-sysroot/lib/x86_64-linux-gnu -L../../build/linux/debian_sid_amd64-sysroot/usr/lib/x86_64-linux-gnu -Wl,-rpath-link=../../build/linux/debian_sid_amd64-sysroot/usr/lib/x86_64-linux-gnu -pie -Wl,-rpath-link=. -Wl,--disable-new-dtags -Wl,-rpath=\$ORIGIN/. -Wl,-rpath-link=. -o "./dawn_spirv_cross_hlsl_full_fuzzer" -Wl,--start-group @"./dawn_spirv_cross_hlsl_full_fuzzer.rsp" ./libc++.so -Wl,--end-group   -ldl -lpthread -lrt 
ld.lld: error: undefined symbol: vtable for spirv_cross::CompilerGLSL
>>> referenced by spirv_glsl.hpp:131 (../../third_party/spirv-cross/spirv_glsl.hpp:131)
>>>               obj/src/fuzzers/dawn_spirv_cross_hlsl_full_fuzzer/DawnSPIRVCrossGLSLFullFuzzer.o:(spirv_cross::CompilerGLSL::CompilerGLSL(std::__1::vector<unsigned int, std::__1::allocator<unsigned int> >))
clang: error: linker command failed with exit code 1 (use -v to see invocation)
~~~

It looks like fuzzer's don't expect enable_opengl=false.
 

Comment 1 by arthurso...@chromium.org, Dec 12

Status: Assigned (was: Untriaged)

Comment 2 by bugdroid1@chromium.org, Dec 14

Project Member
The following revision refers to this bug:
  https://dawn.googlesource.com/dawn/+/fd3717fa7cbc2495d41f6ca2620803a9324db188

commit fd3717fa7cbc2495d41f6ca2620803a9324db188
Author: Corentin Wallez <cwallez@chromium.org>
Date: Fri Dec 14 08:28:55 2018

Fix the build with only the OpenGL and Null backends enabled

BUG= chromium:914375 

Change-Id: I07dbdbdb7518ac6b9800483f570fe97c16f08ee1
Reviewed-on: https://dawn-review.googlesource.com/c/3243
Reviewed-by: Stephen White <senorblanco@chromium.org>
Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>

[modify] https://crrev.com/fd3717fa7cbc2495d41f6ca2620803a9324db188/src/fuzzers/BUILD.gn
[modify] https://crrev.com/fd3717fa7cbc2495d41f6ca2620803a9324db188/third_party/BUILD.gn

Comment 3 by bugdroid1@chromium.org, Dec 14

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bead589464b1d970f7fd1f6f881c45596fef4950

commit bead589464b1d970f7fd1f6f881c45596fef4950
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Fri Dec 14 10:43:58 2018

Roll src/third_party/dawn ff9562f7927b..fd3717fa7cbc (1 commits)

https://dawn.googlesource.com/dawn.git/+log/ff9562f7927b..fd3717fa7cbc


git log ff9562f7927b..fd3717fa7cbc --date=short --no-merges --format='%ad %ae %s'
2018-12-14 cwallez@chromium.org Fix the build with only the OpenGL and Null backends enabled


Created with:
  gclient setdep -r src/third_party/dawn@fd3717fa7cbc

The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG= chromium:914375 
TBR=cwallez@chromium.org

Change-Id: I399894c9c5044ab883e6da85e2323d464802433a
Reviewed-on: https://chromium-review.googlesource.com/c/1377994
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#616630}
[modify] https://crrev.com/bead589464b1d970f7fd1f6f881c45596fef4950/DEPS

Comment 4 by cwallez@chromium.org, Dec 14

Status: Fixed (was: Assigned)

Sign in to add a comment