New issue
Advanced search Search tips

Issue 914374 link

Starred by 1 user

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug



Sign in to add a comment

KeyboardObserverTestCase/testKeyboardDidHide is flaky in ios_chrome_manual_fill_egtests on ios-slimnav

Project Member Reported by fhorschig@chromium.org, Dec 12

Issue description

KeyboardObserverTestCase/testKeyboardDidHide is flaky according to
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=ios_chrome_manual_fill_egtests&tests=testKeyboardDidHide

and recently broke ios_chrome_manual_fill_egtests on ios-slimnav:
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/ios-slimnav/795

Javier, would you please have a look?

Failure log:
KeyboardObserverTestCase/testKeyboardDidHide:
[1212/054237.184863:WARNING:embedded_test_server.cc(239)] Request not handled. Returning 404: /favicon.ico
[1212/054245.202310:WARNING:embedded_test_server.cc(239)] Request not handled. Returning 404: /ios/testing/data/http_server_files/printPostData
2018-12-12 05:42:46.816 ios_chrome_manual_fill_egtests[41905:612398] OCMockObject(KeyboardObserverHelperConsumer): expected method was not invoked: keyboardDidHide
<unknown>:0: error: -[KeyboardObserverTestCase testKeyboardDidHide] : failed: caught "OCMockTestFailure", "OCMockObject(KeyboardObserverHelperConsumer): expected method was not invoked: keyboardDidHide"
(
	0   CoreFoundation                      0x00000001217cd1e6 __exceptionPreprocess + 294
	1   libobjc.A.dylib                     0x0000000126cd3031 objc_exception_throw + 48
	2   CoreFoundation                      0x00000001217cd0b9 -[NSException raise] + 9
	3   ios_chrome_manual_fill_egtests      0x000000010cb55874 OCMReportFailure + 964
	4   ios_chrome_manual_fill_egtests      0x000000010cb592a0 -[OCMockObject verifyAtLocation:] + 720
	5   ios_chrome_manual_fill_egtests      0x000000010cb58fc0 -[OCMockObject verify] + 48
	6   ios_chrome_manual_fill_egtests      0x000000010d911022 -[KeyboardObserverTestCase testKeyboardDidHide] + 306
	7   CoreFoundation                      0x0000000121750ccc __invoking___ + 140
	8   CoreFoundation                      0x0000000121750b84 -[NSInvocation invoke] + 308
	9   EarlGrey                            0x0000000122d4d7f8 -[GREYTestCaseInvocation invoke] + 104
	10  XCTest                              0x0000000122ba7018 __24-[XCTestCase invokeTest]_block_invoke.196 + 78
	11  XCTest                              0x0000000122bfec74 -[XCTestCase(Failures) performFailableBlock:testCaseRun:shouldInterruptTest:] + 57
	12  XCTest                              0x0000000122bfeb91 -[XCTestCase(Failures) _performTurningExceptionsIntoFailuresInterruptAfterHandling:block:] + 96
	13  XCTest                              0x0000000122ba6cd9 __24-[XCTestCase invokeTest]_block_invoke + 848
	14  XCTest                              0x0000000122c04b7e -[XCUITestContext performInScope:] + 248
	15  XCTest                              0x0000000122ba68ce -[XCTestCase testContextPerformInScope:] + 98
	16  XCTest                              0x0000000122ba697c -[XCTestCase invokeTest] + 137
	17  EarlGrey                            0x0000000122d3e447 -[XCTestCase(GREYAdditions) grey_invokeTest] + 1079
	18  XCTest                              0x0000000122ba84b7 __26-[XCTestCase performTest:]_block_invoke_2 + 43
	19  XCTest                              0x0000000122bfec74 -[XCTestCase(Failures) performFailableBlock:testCaseRun:shouldInterruptTest:] + 57
	20  XCTest                              0x0000000122bfeb91 -[XCTestCase(Failures) _performTurningExceptionsIntoFailuresInterruptAfterHandling:block:] + 96
	21  XCTest                              0x0000000122ba83ce __26-[XCTestCase performTest:]_block_invoke.330 + 88
	22  XCTest                              0x0000000122c0f44b +[XCTContext runInContextForTestCase:block:] + 225
	23  XCTest                              0x0000000122ba7afd -[XCTestCase performTest:] + 675
	24  XCTest                              0x0000000122beb1a2 -[XCTest runTest] + 57
	25  XCTest                              0x0000000122ba2ccb __27-[XCTestSuite performTest:]_block_invoke + 365
	26  XCTest                              0x0000000122ba24a3 -[XCTestSuite _performProtectedSectionForTest:testSection:] + 55
	27  XCTest                              0x0000000122ba2766 -[XCTestSuite performTest:] + 296
	28  XCTest                              0x0000000122beb1a2 -[XCTest runTest] + 57
	29  XCTest                              0x0000000122ba2ccb __27-[XCTestSuite performTest:]_block_invoke + 365
	30  XCTest                              0x0000000122ba24a3 -[XCTestSuite _performProtectedSectionForTest:testSection:] + 55
	31  XCTest                              0x0000000122ba2766 -[XCTestSuite performTest:] + 296
	32  XCTest                              0x0000000122beb1a2 -[XCTest runTest] + 57
	33  XCTest                              0x0000000122ba2ccb __27-[XCTestSuite performTest:]_block_invoke + 365
	34  XCTest                              0x0000000122ba24a3 -[XCTestSuite _performProtectedSectionForTest:testSection:] + 55
	35  XCTest                              0x0000000122ba2766 -[XCTestSuite performTest:] + 296
	36  XCTest                              0x0000000122beb1a2 -[XCTest runTest] + 57
	37  XCTest                              0x0000000122c1ae86 __44-[XCTTestRunSession runTestsAndReturnError:]_block_invoke + 171
	38  XCTest                              0x0000000122c1afa7 __44-[XCTTestRunSession runTestsAndReturnError:]_block_invoke.80 + 68
	39  XCTest                              0x0000000122bbabc1 -[XCTestObservationCenter _observeTestExecutionForBlock:] + 585
	40  XCTest                              0x0000000122c1abfa -[XCTTestRunSession runTestsAndReturnError:] + 623
	41  XCTest                              0x0000000122b876b6 -[XCTestDriver runTestsAndReturnError:] + 422
	42  XCTest                              0x0000000122c0b9cd _XCTestMain + 1478
	43  libXCTestBundleInject.dylib         0x000000011f508bb8 __copy_helper_block_ + 0
	44  CoreFoundation                      0x000000012176fb0c __CFRUNLOOP_IS_CALLING_OUT_TO_A_BLOCK__ + 12
	45  CoreFoundation                      0x00000001217542db __CFRunLoopDoBlocks + 331
	46  CoreFoundation                      0x0000000121753a84 __CFRunLoopRun + 1284
	47  CoreFoundation                      0x000000012175330b CFRunLoopRunSpecific + 635
	48  GraphicsServices                    0x000000012815fa73 GSEventRunModal + 62
	49  UIKit                               0x000000011f53e057 UIApplicationMain + 159
	50  ios_chrome_manual_fill_egtests      0x000000010b9edb53 _ZN12_GLOBAL__N_120RunUIApplicationMainEiPPc + 355
	51  ios_chrome_manual_fill_egtests      0x000000010b9ed621 main + 417
	52  libdyld.dylib                       0x0000000129572955 start + 1
)

 
(Disabling in https://crrev.com/c/1373766)
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/404d6ea585eaaea54192b952b659b8c17c4b0103

commit 404d6ea585eaaea54192b952b659b8c17c4b0103
Author: Friedrich Horschig <fhorschig@chromium.org>
Date: Wed Dec 12 16:24:05 2018

[iOS][Flaky] Mark KeyboardObserverTestCase.testKeyboardDidHide flaky

This test was failing frequently, see linked bug for details.

TBR=javierrobles@chromium.org

Bug: 914374
Change-Id: I6cf9df559992c594258314fbb7e736a6da9c023d
Reviewed-on: https://chromium-review.googlesource.com/c/1373766
Reviewed-by: Friedrich Horschig [CET] <fhorschig@chromium.org>
Commit-Queue: Friedrich Horschig [CET] <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615918}
[modify] https://crrev.com/404d6ea585eaaea54192b952b659b8c17c4b0103/ios/chrome/browser/ui/autofill/manual_fill/keyboard_observer_egtest.mm

Status: Started (was: Assigned)

Sign in to add a comment