New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 914323 link

Starred by 1 user
Status: Assigned
Owner:
█ olka@chromium.org
OOO Dec 22 - Jan 8
Cc:
ossu@chromium.org
dalecur...@chromium.org
solenberg@chromium.org
maxmorin@chromium.org
grunell@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

Switch WebRTC rendering to asynchronous device info requests.

Project Member Reported by olka@chromium.org, Dec 12 
The fix for  Issue 905506  introduced an async version of GetOutputDeviceInfo. We'd like to switch WebRTC-related audio rendering to this async API, to get away from device authorization timeouts.
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 12 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/44e69ab575a20cdace11fd70b7a33de74005b412

commit 44e69ab575a20cdace11fd70b7a33de74005b412
Author: Olga Sharonova <olka@chromium.org>
Date: Wed Dec 12 14:48:18 2018

Remove unused MediaStreamAudioRenderer::GetOutputDeviceInfo

I don't recall how it was used before; but apparently it's not used any more.

Bug: 914323
Change-Id: I4c9bd365b4f2331999b973dfd09bba0dc1ced279
Reviewed-on: https://chromium-review.googlesource.com/c/1373833
Reviewed-by: Max Morin <maxmorin@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Olga Sharonova <olka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615883}
[modify] https://crrev.com/44e69ab575a20cdace11fd70b7a33de74005b412/content/public/renderer/media_stream_audio_renderer.h
[modify] https://crrev.com/44e69ab575a20cdace11fd70b7a33de74005b412/content/renderer/media/stream/track_audio_renderer.cc
[modify] https://crrev.com/44e69ab575a20cdace11fd70b7a33de74005b412/content/renderer/media/stream/track_audio_renderer.h
[modify] https://crrev.com/44e69ab575a20cdace11fd70b7a33de74005b412/content/renderer/media/stream/webmediaplayer_ms_unittest.cc
[modify] https://crrev.com/44e69ab575a20cdace11fd70b7a33de74005b412/content/renderer/media/webrtc/webrtc_audio_renderer.cc
[modify] https://crrev.com/44e69ab575a20cdace11fd70b7a33de74005b412/content/renderer/media/webrtc/webrtc_audio_renderer.h
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 13 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2d102680df90e4bf54645b0332b78978e0b85172

commit 2d102680df90e4bf54645b0332b78978e0b85172
Author: Olga Sharonova <olka@chromium.org>
Date: Thu Dec 13 08:29:23 2018

UMA for TrackAudioRenderer and WebRTCAudioRenderer device status

To identify how device authorization timeouts affect WebRTC audio
rendering

Bug: 914323,913476
Change-Id: Id33846a5dd34be0f35a7a21c414e2df35bdcdd90
Reviewed-on: https://chromium-review.googlesource.com/c/1373760
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Max Morin <maxmorin@chromium.org>
Commit-Queue: Olga Sharonova <olka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616244}
[modify] https://crrev.com/2d102680df90e4bf54645b0332b78978e0b85172/content/renderer/media/stream/track_audio_renderer.cc
[modify] https://crrev.com/2d102680df90e4bf54645b0332b78978e0b85172/content/renderer/media/webrtc/webrtc_audio_renderer.cc
[modify] https://crrev.com/2d102680df90e4bf54645b0332b78978e0b85172/tools/metrics/histograms/histograms.xml
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 18

Labels: merge-merged-3626
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fd0ffefe76fd049836a244d3204f18c72197320c

commit fd0ffefe76fd049836a244d3204f18c72197320c
Author: Olga Sharonova <olka@chromium.org>
Date: Tue Dec 18 18:29:39 2018

UMA for TrackAudioRenderer and WebRTCAudioRenderer device status

To identify how device authorization timeouts affect WebRTC audio
rendering

Bug: 914323,913476
Change-Id: Id33846a5dd34be0f35a7a21c414e2df35bdcdd90
Reviewed-on: https://chromium-review.googlesource.com/c/1373760
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Max Morin <maxmorin@chromium.org>
Commit-Queue: Olga Sharonova <olka@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#616244}(cherry picked from commit 2d102680df90e4bf54645b0332b78978e0b85172)
Reviewed-on: https://chromium-review.googlesource.com/c/1382500
Reviewed-by: Olga Sharonova <olka@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#436}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
[modify] https://crrev.com/fd0ffefe76fd049836a244d3204f18c72197320c/content/renderer/media/stream/track_audio_renderer.cc
[modify] https://crrev.com/fd0ffefe76fd049836a244d3204f18c72197320c/content/renderer/media/webrtc/webrtc_audio_renderer.cc
[modify] https://crrev.com/fd0ffefe76fd049836a244d3204f18c72197320c/tools/metrics/histograms/histograms.xml
Project Member

Comment 4 by cr-audit...@appspot.gserviceaccount.com, Dec 19

Labels: Merge-Merged-72-3626
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/fd0ffefe76fd049836a244d3204f18c72197320c

Commit: fd0ffefe76fd049836a244d3204f18c72197320c
Author: olka@chromium.org
Commiter: olka@chromium.org
Date: 2018-12-18 18:29:39 +0000 UTC

UMA for TrackAudioRenderer and WebRTCAudioRenderer device status

To identify how device authorization timeouts affect WebRTC audio
rendering

Bug: 914323,913476
Change-Id: Id33846a5dd34be0f35a7a21c414e2df35bdcdd90
Reviewed-on: https://chromium-review.googlesource.com/c/1373760
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Max Morin <maxmorin@chromium.org>
Commit-Queue: Olga Sharonova <olka@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#616244}(cherry picked from commit 2d102680df90e4bf54645b0332b78978e0b85172)
Reviewed-on: https://chromium-review.googlesource.com/c/1382500
Reviewed-by: Olga Sharonova <olka@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#436}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
►

Sign in to add a comment