New issue
Advanced search Search tips

Issue 914316 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 21
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 3
Type: Bug-Regression



Sign in to add a comment

Regression: Tooltip overlaps with iron icon on 'chrome://settings/content/notifications'.

Project Member Reported by pranja...@virtusa.com, Dec 12

Issue description

Chrome Version:73.0.3638.0 (Official Build) c6d06cddb87285ab9e8d92e07af7918bb728ea67-refs/branch-heads/3638@{#1}(32/64 bit)

OS:  Win(7,8,8.1,10) , Mac(10.13.1 , 10.13.6 , 10.14.2) and Linux(14.04 LTS)OS 

What steps will reproduce the problem?
1.Launch chrome and navigate to 'chrome://settings/content/notifications'.
2.Press tab key until focus reaches to iron icon and repeat step for next iron icon.
3.Observe.

Actual  : Tooltip overlaps with iron icon on 'chrome://settings/content/notifications'.
Expected: Tooltip should not overlap with iron icon on 'chrome://settings/content/notifications'.

This is a regression issue broken in ‘M-72’ and below is the 'Chromium bisect' information:
Good Build: 72.0.3599.0
Bad Build : 72.0.3600.0

You are probably looking for a change made after 605026 (known good), but no later than 605027 (first known bad).

CHANGELOG URL:

The script might not always return single CL as suspect as some perf builds might get missing due to failure.

https://chromium.googlesource.com/chromium/src/+log/4a67575ed3af80e498ac344c8e19eb37bcdc5dad..5181c8f75f52980b89768e7732a204b74bd3fc4b

Suspecting: https://chromium.googlesource.com/chromium/src/+/5181c8f75f52980b89768e7732a204b74bd3fc4b

@aee: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Kindly review the attached screen-cast for reference.

Thank you.
 
Actual Result.png
157 KB View Download
Expected Result.png
158 KB View Download
Labels: -Pri-1 Pri-3
The tooltip is fitting to the visible bounds of the site list. I will investigate whether the common tooltip change is needed now that the sub-page animation has been removed.

Status: Started (was: Assigned)
Cc: johntlee@chromium.org aee@chromium.org
 Issue 899183  has been merged into this issue.
Cc: -aee@chromium.org
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 21

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a85ba634365bffa14adf4fe28e37c8e2e41bc901

commit a85ba634365bffa14adf4fe28e37c8e2e41bc901
Author: Esmael El-Moslimany <aee@chromium.org>
Date: Fri Dec 21 01:19:25 2018

Settings WebUI: site-list, set policy icon as tooltip target before
updating location

This CL reverts most of
https://chromium-review.googlesource.com/c/chromium/src/+/1315627
which introduced the target and update position bug and handled the
tooltip cutoff due to the neon animation which was removed. This is
mentioned in  https://crbug.com/899183#c7 .

Bug:  914316 
Change-Id: Id35e6ffaf418c6b01ab273c6353928eaa12ebed1
Reviewed-on: https://chromium-review.googlesource.com/c/1387664
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618422}
[modify] https://crrev.com/a85ba634365bffa14adf4fe28e37c8e2e41bc901/chrome/browser/resources/settings/site_settings/site_list.js

Status: Fixed (was: Started)
Labels: TE-Verified-M73 TE-Verified-73.0.3647.0
Update:

Rechecked the above issue on latest canary build #73.0.3647.0 using Win(7,8,8.1,10) , Mac(10.13.1 , 10.13.6 , 10.14.2) and Linux(14.04 LTS)OS  and issue is fixed. 
Please refer attached screencast for same.

Thank You..
Canary Behaviour.mp4
266 KB View Download

Sign in to add a comment