New issue
Advanced search Search tips
Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Dec 14
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug



Sign in to add a comment
link

Issue 914303: Unnecessary grey focus is seen on search engine menus

Reported by usman.shaikh@chromium.org, Dec 12 Project Member

Issue description

App Version: 72.0.3626.15 beta 
iOS Version: 11.4.1, 11.3.1, 12.1
Device: iPhone5s, iPhone 7, iPad Pro, iPad 6th gen

Steps to reproduce:
 1. Launch Chrome 
 2. Tap on chrome menus > settings > Search Engine > select any search engine
 3. Tap again on the same > Observe

Observed results: Unnecessary grey focus is seen 

Expected results: Grey focus should not stay after the menu has been tapped

Number of times you were able to reproduce: 5/5
Bug reproducible after clean install: Yes
Bug reproducible after clearing cache and cookies: Yes
Bug reproducible on Chrome Mobile on Android: No
Bug reproducible on Safari/Firefox: Firefox: NA Safari: NA
Bug reproducible on current stable build (App Version, iOS Version): No on 71.0.3578.77, iOS Version-11.4.1
Bug reproducible on the current beta channel build (App Version, iOS Version): Yes on 72.0.3626.15, iOS Version- 11.4.1

Link to video:
M72 Behavior:
https://drive.google.com/file/d/1eD773blaSNbWnquP_LAHuzv_N8hZqfKB/view?usp=sharing

M71 Behavior:
https://drive.google.com/file/d/14Dcbhm0JfkSR6nbyMg_D2ML1hmOatRf3/view?usp=sharing
 

Comment 1 by rakurati@chromium.org, Dec 12

Components: UI>Browser>Search

Comment 2 by rakurati@chromium.org, Dec 12

Description: Show this description

Comment 3 by sczs@google.com, Dec 12

Cc: gambard@chromium.org
Components: -UI>Browser>Search
Owner: mrsuyi@chromium.org
Status: Assigned (was: Untriaged)
mrsuyi@ I don't think this is a bug and its WAI on a TableView, but just assigning to you to confirm.

Comment 4 by mrsuyi@chromium.org, Dec 14

Status: Started (was: Assigned)

Comment 5 by bugdroid1@chromium.org, Dec 14

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1794d6d608c8fb5ff76b8c5788ec0f4bff4ef265

commit 1794d6d608c8fb5ff76b8c5788ec0f4bff4ef265
Author: Yi Su <mrsuyi@chromium.org>
Date: Fri Dec 14 10:50:51 2018

Fix uncleared highlight in search engine settings.

Search Engine settings has some early returns in its overriden method
"tableView:didSelectRowAtIndexPath:" that may cause uncleared highlight.

Bug:  914303 
Change-Id: I86aa12169266ddada77668e5aa2739afcb775462
Reviewed-on: https://chromium-review.googlesource.com/c/1377432
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Yi Su <mrsuyi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616631}
[modify] https://crrev.com/1794d6d608c8fb5ff76b8c5788ec0f4bff4ef265/ios/chrome/browser/ui/settings/search_engine_table_view_controller.mm

Comment 6 by mrsuyi@chromium.org, Dec 14

Labels: Merge-Request-72
Status: Fixed (was: Started)

Comment 7 by sheriffbot@chromium.org, Dec 14

Project Member
Labels: -Merge-Request-72 Merge-Review-72 Hotlist-Merge-Review
This bug requires manual review: M72 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 8 by kariahda@chromium.org, Dec 17

Labels: -Merge-Review-72 Merge-Approved-72
Approved.

Comment 9 by bugdroid1@chromium.org, Dec 17

Project Member
Labels: -merge-approved-72 merge-merged-3626
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f96f63f58ce952514c42c2f291cfd8965a83eac7

commit f96f63f58ce952514c42c2f291cfd8965a83eac7
Author: Yi Su <mrsuyi@chromium.org>
Date: Mon Dec 17 19:23:54 2018

Fix uncleared highlight in search engine settings.

Search Engine settings has some early returns in its overriden method
"tableView:didSelectRowAtIndexPath:" that may cause uncleared highlight.

Bug:  914303 
Change-Id: I86aa12169266ddada77668e5aa2739afcb775462
Reviewed-on: https://chromium-review.googlesource.com/c/1377432
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Yi Su <mrsuyi@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#616631}(cherry picked from commit 1794d6d608c8fb5ff76b8c5788ec0f4bff4ef265)
Reviewed-on: https://chromium-review.googlesource.com/c/1380538
Reviewed-by: Yi Su <mrsuyi@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#404}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
[modify] https://crrev.com/f96f63f58ce952514c42c2f291cfd8965a83eac7/ios/chrome/browser/ui/settings/search_engine_table_view_controller.mm

Comment 10 by subhashi...@chromium.org, Dec 18

Status: Verified (was: Fixed)
Verified in:

App Version: 73.0.3643.0 canary
Devices: iPhoneX, iPhone 6S Plus, iPad Pro
iOS Versions: 11.4.1, 12.1.2 beta 2, 12.1.1

Grey focus is cleared on choosing the search engine.

Comment 11 by cr-audit...@appspot.gserviceaccount.com, Dec 19

Project Member
Labels: Merge-Merged-72-3626
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/f96f63f58ce952514c42c2f291cfd8965a83eac7

Commit: f96f63f58ce952514c42c2f291cfd8965a83eac7
Author: mrsuyi@chromium.org
Commiter: mrsuyi@chromium.org
Date: 2018-12-17 19:23:54 +0000 UTC

Fix uncleared highlight in search engine settings.

Search Engine settings has some early returns in its overriden method
"tableView:didSelectRowAtIndexPath:" that may cause uncleared highlight.

Bug:  914303 
Change-Id: I86aa12169266ddada77668e5aa2739afcb775462
Reviewed-on: https://chromium-review.googlesource.com/c/1377432
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Yi Su <mrsuyi@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#616631}(cherry picked from commit 1794d6d608c8fb5ff76b8c5788ec0f4bff4ef265)
Reviewed-on: https://chromium-review.googlesource.com/c/1380538
Reviewed-by: Yi Su <mrsuyi@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#404}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}

Comment 12 by yangulo@chromium.org, Dec 19

Issue verified 
Version: Chrome Beta 72.0.3626.28
Device: iPad Mini
iOS: 11.4.1

No unnecessary shadow remains on focus on search engine menus
https://drive.google.com/open?id=11RjOwrvuTxJRKbIQGIhC0aBTvAqUaVp8

Sign in to add a comment