New issue
Advanced search Search tips

Issue 914270 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 12
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android , Chrome
Pri: 0
Type: Bug-Regression
Proj-VR
Proj-XR
Proj-XR-VR



Sign in to add a comment

compile confirm no-op failing on android and CrOS builders

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Dec 12

Issue description

Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of fhorschig@google.com

The "compile confirm no-op" step is failing on : 
- android-dbg: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/android-dbg
- android-rel: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/android-rel
- Google Chrome ChromeOS: https://ci.chromium.org/buildbot/chromium.chrome/Google%20Chrome%20ChromeOS
- Android CFI: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Android%20CFI

Ninja explain reports:
ninja explain: output gen/tools/perf/contrib/vr_benchmarks/vr_assets_profile doesn't exist
ninja explain: gen/tools/perf/contrib/vr_benchmarks/vr_assets_profile is dirty
ninja explain: obj/tools/perf/contrib/vr_benchmarks/generate_vr_assets_profile.stamp is dirty
 
Owner: fhorschig@chromium.org
Status: Started (was: Available)
Okay, so all builders show this error as soon as they included the commits ranging from r2dc2e737 to aed99d7e. If the error wasn't introduced in a configuration before that, this is the regression range.

It's unlikely that the error was introduced before the first failing commit as there is no set of "last-known-good" CLs for this issue. If an earlier CL is the root, it must have landed before r5534e46f.

Components: UI>Browser>VR
Labels: OS-Android OS-Chrome Type-Bug-Regression
Labels: -Pri-2 Pri-1
Now my CL cannot be committed due to this error on the try bots. I'm not sure other people's situation, but I'd like to give this higher priority. Thank you for triage!

Hmm, I can't find a good suspect. 

Complete list (oldest to newest suspect):
https://crrev.com/c/1372990 - Adds a dependency in a build file - nothing removed here.
https://crrev.com/c/1358615 - Name change of a histogram.
https://crrev.com/c/1373049 - Changes only comments.
https://crrev.com/c/1372831 - Changes a single test JS file.
https://crrev.com/c/1370486 - Changes mainly expectations and a one-line rounding hack. (Someone reverted it: https://crrev.com/c/1373285 ==> It showed no effect and Google Chrome ChromeOS fails still)
Cc: fhorschig@chromium.org
Owner: ----
Status: Available (was: Started)
I'll check older CLs for culprits. As this is pretty hopeless: if someone knows how to create a fix for this kind of issue, please go ahead and take this.
Labels: -Pri-1 Pri-0
Setting to P-0 as this renders a lot of builders completely useless, blocks CLs from landing and should absolutely take priority over any other bug.
Labels: -Pri-0 Pri-1
Okay, Now "Google Chrome OS" and "android-rel" have been cycling green [1].
Let's wait for android-dbg to see whether this was the solution and whether it persists.

Or has someone touched the bots manually to fix this?


[1] android-rel with https://crrev.com/c/1373285 only and Google Chrome OS right after this commit)
Components: Infra
Labels: -Pri-1 Infra-Troopers Pri-0
It apparently got worse: The "green" builds aren't really green. They just ignore the failure.
So this opens another question: How is that possible?
Isn't the bot expectation set _somewhere_ in the chromium repo?
(https://crrev.com/c/1373285 was the first to cycle green, but it's only a revert and doesn't touch any bot config file)
Owner: oprypin@chromium.org
Status: Fixed (was: Available)
This is fixed by
https://chromium-review.googlesource.com/c/chromium/tools/build/+/1373509
Okay, to record hat happened:

1. Quite a while ago, it was decided to ignore failures in this step.
2. https://crrev.com/c/1371350 stated these failures are rare and should be blocking.
3. This broke mac_asan and win_x86_msvc_rel [1]
4. https://crrev.com/c/1373509 reverted the CL from 2 to ignore these failures again.
5. Failures still exist and they are ignored as expected.

The observed red cycles happened between 2 and 4 but the changes in 2 & 4 were invisible in the regular tree as they happened in the sub-repo https://chromium.googlesource.com/chromium/tools/build/.

[1] 
https://ci.chromium.org/p/webrtc/builders/luci.webrtc.try/mac_asan/15219
https://ci.chromium.org/p/webrtc/builders/luci.webrtc.try/win_x86_msvc_rel/489

Sign in to add a comment