New issue
Advanced search Search tips

Issue 914269 link

Starred by 1 user
Status: Assigned
Owner:
linds...@chromium.org
Cc:
justincohen@chromium.org
olivierrobin@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug



Sign in to add a comment

Add individual timeout to EarlGrey test

Project Member Reported by olivierrobin@chromium.org, Dec 12 
Due to network issues, ExternalURLSigninTestCase currently times out after 1 hour.
Result is that the watch dog kills the whold test suite and we don't have the data.
There is also a bigger queue to run the tests.
Would it be possible to add individual timeouts (let's say 1 minute) that could be reconfigured by tests if needed, so we don't affect the whole test suite?

Comment 1 by lindsayw@google.com, Dec 13 

Do you mind please linking to an example log? 

This is related to the network/connectivity in the lab bug you filed right?

You are proposing individual timeouts per test case or per test suite? Also shouldn't the pre-run network check test case be failing in such a case and preventing hour-long holds like this? I can try to check more tomorrow.

Comment 2 by olivierrobin@google.com, Dec 13 

https://logs.chromium.org/logs/chrome/bb/internal.bling.main/iphone11-simulator-x64/10084/+/recipes/steps/ios_internal_chrome_external_url_egtests__iPhone_5s_iOS_11.4__on_Mac/0/stdout
is an example

Test Case '-[ExternalURLSigninTestCase testAccesibilityOnNewSignIn]' starts at 2018-12-12 23:52:51.653 and is killed at 2018-12-13 00:35:38.961 on whole test suite timeout.
As a result, we have no output logs in the tree status (and the bot queue grows).
And tests after this one does not run.

I propose to set a timeout per test case (say 1 minute). If a test is expected to last longer, it can set a longer timer. But if the timer is reached, test times out cleanly and other test runs.

I am not sure the pre-run network check is run (I did not find where to check that).
►

Sign in to add a comment