New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 914268 link

Starred by 1 user

Issue metadata

Status: Closed
Owner: ----
Closed: Dec 13
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature

Blocked on:
issue 909848



Sign in to add a comment

Support WARNING step status in buildbucket BQ table

Project Member Reported by tikuta@chromium.org, Dec 12

Issue description

Do we have warning information of build step somewhere?

e.g.
"compile confirm no-op" in below build is marked as WARNING in recipe, but BQ table does not store the step as warning.
https://ci.chromium.org/p/webrtc/builders/luci.webrtc.try/mac_asan/15213

context: lack of status data caused me revert.
https://chromium-review.googlesource.com/c/chromium/tools/build/+/1373509
 
Cc: iannucci@chromium.org hinoka@chromium.org
Sorry the data seems to be there.
I wonder why there is no WARNING status.
Description: Show this description
Summary: Support WARNING step status in buildbucket BQ table (was: Upload step data of all luci builds to BigQuery)
Blockedon: 909848
Labels: -Type-Bug Type-Feature
Status: Available (was: Untriaged)
indeed, there is no warning in go/buildbucket-proto/common.proto

the format from which go/build.proto messages are being created does not support WARNING either: https://cs.chromium.org/chromium/infra/go/src/go.chromium.org/luci/common/proto/milo/annotations.proto
not sure why it doesn't, but it is deprecated and it is unlikely that we will extend it.

Robbie plans to add native support of go/build.proto to recipe engine directly (bug 909848). When it is done, we can add warning status support.

--

however, why do you need it? Do you use it for monitoring?
WARNING status wasn't used for a while. Users rarely need it.
Robbie, WDYT about warning status?
> however, why do you need it? Do you use it for monitoring?

I intended to use WARNING status to find steps having something we want to fix, but not want to make it failure at the same time.
Also I used WARNING to detect failure by incorrect build rule that can happen non-deterministically. If we cannot use WARNING, is there some replacement which can be used for this kinds of purpose?

My target step is being everywhere, so I'd like to have ability to find target step from existing steps.
you could use output properties for that. Write a JSON object with anything you want to be able to retrieve from a build, and then retrieve it with JSON functions, see examples in go/buildbucket-bq

this assumes there will be only one such object per build though, because of current recipe engine limitations. Would that work for you?
Ah, it seems to be usable for my purpose. Thanks
But how can we set output properties?
Status: Closed (was: Available)
Thanks, then I don't need WARNING status support in BQ table. I can just using that field.

Sign in to add a comment