New issue
Advanced search Search tips

Issue 914264 link

Starred by 2 users

Issue metadata

Status: Started
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug


Sign in to add a comment

enable 'compile confirm no-op' check everywhere

Project Member Reported by tikuta@chromium.org, Dec 12

Issue description

Project Member

Comment 1 by bugdroid1@chromium.org, Dec 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/07d76e6d151c308ce1bdee86a5bb9eca0660009c

commit 07d76e6d151c308ce1bdee86a5bb9eca0660009c
Author: Takuto Ikuta <tikuta@chromium.org>
Date: Wed Dec 12 19:18:41 2018

make vr_assets_profile dir always

This is necessary to make second build no-op.
Without this, following command runs the script always.
$ ninja -C out/android_arm64_dbg_recipe/ gen/tools/perf/contrib/vr_benchmarks/vr_assets_profile

Bug: 914264
Change-Id: I35ff097c6a34318813957b71c690386fc1a7a1e3
Reviewed-on: https://chromium-review.googlesource.com/c/1373734
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615991}
[modify] https://crrev.com/07d76e6d151c308ce1bdee86a5bb9eca0660009c/tools/perf/contrib/vr_benchmarks/generate_vr_assets_profile.py

Project Member

Comment 2 by bugdroid1@chromium.org, Dec 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/218c2a7d5374a4848bc79f309324850f6b40f0a6

commit 218c2a7d5374a4848bc79f309324850f6b40f0a6
Author: Takuto Ikuta <tikuta@chromium.org>
Date: Thu Dec 13 06:06:51 2018

[chromium] use output property to detect confirm no-op failure

Currently WARNING status is not supported in BigQuery table.
Instead, I was told that we can use property to detect unexpected failure in
https://bugs.chromium.org/p/chromium/issues/detail?id=914268#c6

I will use this property to collect confirm no-op failure steps.

Bug: 914264
Change-Id: Ic5ae309831b502ce53896a56555f8ed81c39b08a
Reviewed-on: https://chromium-review.googlesource.com/c/1375550
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Shinya Kawanaka <shinyak@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>

[modify] https://crrev.com/218c2a7d5374a4848bc79f309324850f6b40f0a6/scripts/slave/README.recipes.md
[modify] https://crrev.com/218c2a7d5374a4848bc79f309324850f6b40f0a6/scripts/slave/recipe_modules/chromium/examples/full.py
[modify] https://crrev.com/218c2a7d5374a4848bc79f309324850f6b40f0a6/scripts/slave/recipe_modules/chromium/api.py

Blockedon: 914707
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 13

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/goma/client/+/f1e7bdab864ee93a8f1a78e6cbbff754e703f82e

commit f1e7bdab864ee93a8f1a78e6cbbff754e703f82e
Author: Takuto Ikuta <tikuta@google.com>
Date: Thu Dec 13 09:28:23 2018

Status: Started (was: Untriaged)
Project Member

Comment 7 by bugdroid1@chromium.org, Dec 14

The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/3be607f2bc8d59120e2191dece67089f97618456

commit 3be607f2bc8d59120e2191dece67089f97618456
Author: Takuto Ikuta <tikuta@google.com>
Date: Fri Dec 14 14:22:52 2018

Use output_dir instead of output_name

This is to make second build no-op in mac_asan builder.
e.g. https://ci.chromium.org/p/webrtc/builders/luci.webrtc.try/mac_asan/15219

We can use output_dir to override default_output_dir of executable.
https://gn.googlesource.com/gn/+/master/docs/reference.md#tool-variables


confirm no-op step for this CL does not complain.
https://ci.chromium.org/p/webrtc/builders/luci.webrtc.try/mac_asan/15305

Bug: chromium:914264
Change-Id: Ia1196280064703dcb08e208e91c704cce25a925c
Reviewed-on: https://webrtc-review.googlesource.com/c/114180
Reviewed-by: Oleh Prypin <oprypin@webrtc.org>
Commit-Queue: Takuto Ikuta <tikuta@google.com>
Cr-Commit-Position: refs/heads/master@{#26013}
[modify] https://crrev.com/3be607f2bc8d59120e2191dece67089f97618456/modules/audio_processing/test/py_quality_assessment/BUILD.gn

Project Member

Comment 8 by bugdroid1@chromium.org, Dec 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ccdf497297e98c74fe282b112b7d3008582ae537

commit ccdf497297e98c74fe282b112b7d3008582ae537
Author: Takuto Ikuta <tikuta@chromium.org>
Date: Fri Dec 14 15:01:58 2018

[android] specify collect library path in depfile

This is to fix error in
https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8927198065475228928/+/steps/compile_confirm_no-op/0/stdout

Without this, following command always re-run.
$ ninja -C out/Android_CFI/ -dexplain -v gen/tools/android/md5sum/md5sum_prepare_dist_library_dependencies.list

This CL specifies '../../third_party/llvm-build/Release+Asserts/lib/clang/8.0.0/lib/linux/libclang_rt.ubsan_standalone-arm-android.so' in deps instead of non-existing file 'libclang_rt.ubsan_standalone-arm-android.so' in deps.

Bug: 914264
Change-Id: I34e30ebcd81ff8c4e7cccb59295aca710a1cda81
Reviewed-on: https://chromium-review.googlesource.com/c/1378151
Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616671}
[modify] https://crrev.com/ccdf497297e98c74fe282b112b7d3008582ae537/build/android/gyp/write_ordered_libraries.py

Project Member

Comment 9 by bugdroid1@chromium.org, Dec 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/54a631f03d888aadfd1a5d3af371f4748412a99f

commit 54a631f03d888aadfd1a5d3af371f4748412a99f
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Fri Dec 14 20:32:43 2018

Roll src/third_party/webrtc d96b275cd686..24779d82292e (15 commits)

https://webrtc.googlesource.com/src.git/+log/d96b275cd686..24779d82292e


git log d96b275cd686..24779d82292e --date=short --no-merges --format='%ad %ae %s'
2018-12-14 terelius@webrtc.org Missing packet send time should not cause BWE backoff.
2018-12-14 oprypin@webrtc.org Switch to logdog binary provided by IMPLIED_CIPD_BINARIES
2018-12-14 henrikg@webrtc.org Revert "Reland "Default to dlopening the PipeWire.""
2018-12-14 tikuta@google.com Use output_dir instead of output_name
2018-12-14 kron@webrtc.org Refactor creation of ColorSpace test data
2018-12-14 nisse@webrtc.org Delete log severity LS_SENSITIVE
2018-12-14 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 55b877610b..6d37479eb8 (615952:616603)
2018-12-14 tikuta@google.com update luci-go client
2018-12-14 steveanton@webrtc.org Use unique_ptr in DataChannel PacketQueue
2018-12-13 steveanton@webrtc.org Remove unused cryptoparams.h header
2018-12-13 zstein@webrtc.org Set LoggedIceCandidatePairEvent.transaction_id to default value if missing.
2018-12-13 benwright@webrtc.org Adding fuzzing configuration files for Rtp Replay Fuzzing.
2018-12-13 tomas.popela@gmail.com Reland "Default to dlopening the PipeWire."
2018-12-13 jeroendb@webrtc.org Adding metrics for hostname candidate use.
2018-12-13 kron@webrtc.org Reorder methods and members of HdrMetadata


Created with:
  gclient setdep -r src/third_party/webrtc@24779d82292e

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng

BUG=chromium:755660,chromium:682122,chromium:914264,chromium:None,chromium:894045,chromium:914164,chromium:None,chromium:None,chromium:682122
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I5286b9abd8b5c2110cdcc85633079001b3689e71
Reviewed-on: https://chromium-review.googlesource.com/c/1378445
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#616810}
[modify] https://crrev.com/54a631f03d888aadfd1a5d3af371f4748412a99f/DEPS

Blockedon: 898167
Blockedon: 919422
Blockedon: 921902

Comment 13 by tikuta@chromium.org, Jan 18 (4 days ago)

Blockedon: 923275

Sign in to add a comment