|
|
|||||||||||||||
Issue descriptionDerived from https://chromium-review.googlesource.com/c/chromium/tools/build/+/1373509 I will use below query to find current no-op failure. https://pantheon.corp.google.com/bigquery?folder&organizationId=433637338589&project=cr-buildbucket&j=bquxjob_72f14c91_168e07ebbdb&page=queryresults , Dec 13Project MemberThe following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/218c2a7d5374a4848bc79f309324850f6b40f0a6 commit 218c2a7d5374a4848bc79f309324850f6b40f0a6 Author: Takuto Ikuta <tikuta@chromium.org> Date: Thu Dec 13 06:06:51 2018 [chromium] use output property to detect confirm no-op failure Currently WARNING status is not supported in BigQuery table. Instead, I was told that we can use property to detect unexpected failure in https://bugs.chromium.org/p/chromium/issues/detail?id=914268#c6 I will use this property to collect confirm no-op failure steps. Bug: 914264 Change-Id: Ic5ae309831b502ce53896a56555f8ed81c39b08a Reviewed-on: https://chromium-review.googlesource.com/c/1375550 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Reviewed-by: Shinya Kawanaka <shinyak@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> [modify] https://crrev.com/218c2a7d5374a4848bc79f309324850f6b40f0a6/scripts/slave/README.recipes.md [modify] https://crrev.com/218c2a7d5374a4848bc79f309324850f6b40f0a6/scripts/slave/recipe_modules/chromium/examples/full.py [modify] https://crrev.com/218c2a7d5374a4848bc79f309324850f6b40f0a6/scripts/slave/recipe_modules/chromium/api.py , Dec 13I can use this to extract no-op failure steps. https://pantheon.corp.google.com/bigquery?folder&organizationId=433637338589&project=cr-buildbucket&j=bquxjob_6a6b6e8_167a66b9eb2&page=queryresults , Dec 13
, Dec 13Project MemberThe following revision refers to this bug: https://chrome-internal.googlesource.com/goma/client/+/f1e7bdab864ee93a8f1a78e6cbbff754e703f82e commit f1e7bdab864ee93a8f1a78e6cbbff754e703f82e Author: Takuto Ikuta <tikuta@google.com> Date: Thu Dec 13 09:28:23 2018 , Dec 14
, Dec 14Project MemberThe following revision refers to this bug: https://webrtc.googlesource.com/src.git/+/3be607f2bc8d59120e2191dece67089f97618456 commit 3be607f2bc8d59120e2191dece67089f97618456 Author: Takuto Ikuta <tikuta@google.com> Date: Fri Dec 14 14:22:52 2018 Use output_dir instead of output_name This is to make second build no-op in mac_asan builder. e.g. https://ci.chromium.org/p/webrtc/builders/luci.webrtc.try/mac_asan/15219 We can use output_dir to override default_output_dir of executable. https://gn.googlesource.com/gn/+/master/docs/reference.md#tool-variables confirm no-op step for this CL does not complain. https://ci.chromium.org/p/webrtc/builders/luci.webrtc.try/mac_asan/15305 Bug: chromium:914264 Change-Id: Ia1196280064703dcb08e208e91c704cce25a925c Reviewed-on: https://webrtc-review.googlesource.com/c/114180 Reviewed-by: Oleh Prypin <oprypin@webrtc.org> Commit-Queue: Takuto Ikuta <tikuta@google.com> Cr-Commit-Position: refs/heads/master@{#26013} [modify] https://crrev.com/3be607f2bc8d59120e2191dece67089f97618456/modules/audio_processing/test/py_quality_assessment/BUILD.gn , Dec 14Project MemberThe following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ccdf497297e98c74fe282b112b7d3008582ae537 commit ccdf497297e98c74fe282b112b7d3008582ae537 Author: Takuto Ikuta <tikuta@chromium.org> Date: Fri Dec 14 15:01:58 2018 [android] specify collect library path in depfile This is to fix error in https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8927198065475228928/+/steps/compile_confirm_no-op/0/stdout Without this, following command always re-run. $ ninja -C out/Android_CFI/ -dexplain -v gen/tools/android/md5sum/md5sum_prepare_dist_library_dependencies.list This CL specifies '../../third_party/llvm-build/Release+Asserts/lib/clang/8.0.0/lib/linux/libclang_rt.ubsan_standalone-arm-android.so' in deps instead of non-existing file 'libclang_rt.ubsan_standalone-arm-android.so' in deps. Bug: 914264 Change-Id: I34e30ebcd81ff8c4e7cccb59295aca710a1cda81 Reviewed-on: https://chromium-review.googlesource.com/c/1378151 Reviewed-by: agrieve <agrieve@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#616671} [modify] https://crrev.com/ccdf497297e98c74fe282b112b7d3008582ae537/build/android/gyp/write_ordered_libraries.py , Dec 14Project MemberThe following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/54a631f03d888aadfd1a5d3af371f4748412a99f commit 54a631f03d888aadfd1a5d3af371f4748412a99f Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Dec 14 20:32:43 2018 Roll src/third_party/webrtc d96b275cd686..24779d82292e (15 commits) https://webrtc.googlesource.com/src.git/+log/d96b275cd686..24779d82292e git log d96b275cd686..24779d82292e --date=short --no-merges --format='%ad %ae %s' 2018-12-14 terelius@webrtc.org Missing packet send time should not cause BWE backoff. 2018-12-14 oprypin@webrtc.org Switch to logdog binary provided by IMPLIED_CIPD_BINARIES 2018-12-14 henrikg@webrtc.org Revert "Reland "Default to dlopening the PipeWire."" 2018-12-14 tikuta@google.com Use output_dir instead of output_name 2018-12-14 kron@webrtc.org Refactor creation of ColorSpace test data 2018-12-14 nisse@webrtc.org Delete log severity LS_SENSITIVE 2018-12-14 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 55b877610b..6d37479eb8 (615952:616603) 2018-12-14 tikuta@google.com update luci-go client 2018-12-14 steveanton@webrtc.org Use unique_ptr in DataChannel PacketQueue 2018-12-13 steveanton@webrtc.org Remove unused cryptoparams.h header 2018-12-13 zstein@webrtc.org Set LoggedIceCandidatePairEvent.transaction_id to default value if missing. 2018-12-13 benwright@webrtc.org Adding fuzzing configuration files for Rtp Replay Fuzzing. 2018-12-13 tomas.popela@gmail.com Reland "Default to dlopening the PipeWire." 2018-12-13 jeroendb@webrtc.org Adding metrics for hostname candidate use. 2018-12-13 kron@webrtc.org Reorder methods and members of HdrMetadata Created with: gclient setdep -r src/third_party/webrtc@24779d82292e The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG= chromium:755660 ,chromium:682122,chromium:914264,chromium:None,chromium:894045,chromium:914164,chromium:None,chromium:None,chromium:682122 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I5286b9abd8b5c2110cdcc85633079001b3689e71 Reviewed-on: https://chromium-review.googlesource.com/c/1378445 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#616810} [modify] https://crrev.com/54a631f03d888aadfd1a5d3af371f4748412a99f/DEPS , Jan 3
, Jan 7
, Jan 15
, Jan 18
, Jan 25What's the status here? Can we turn this on for at least some more bots by now (maybe cros or android)? , Jan 28Currently, blocked by Mac ASAN Debug builder. But let me switch default in https://chromium-review.googlesource.com/c/chromium/tools/build/+/1436424 , Jan 28Project MemberThe following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/b295f0b4042a2f46dd27be4309b4fa5c77dad444 commit b295f0b4042a2f46dd27be4309b4fa5c77dad444 Author: Takuto Ikuta <tikuta@chromium.org> Date: Mon Jan 28 08:24:56 2019 [chromium] enable ninja confirm noop by default This CL switches to do noop check by default. But I blacklisted 'Mac ASAN Debug builder' that fails the check frequently. https://console.cloud.google.com/bigquery?project=cr-buildbucket&j=bquxjob_57647d44_16892e53358&page=queryresults I will remove ninja_confirm_noop config in later patch. Bug: 914264, 921902 Change-Id: Ic5cd8c73469b1bf9ee590d428e6a49964b4f5a53 Reviewed-on: https://chromium-review.googlesource.com/c/1436424 Reviewed-by: John Budorick <jbudorick@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> [modify] https://crrev.com/b295f0b4042a2f46dd27be4309b4fa5c77dad444/scripts/slave/recipe_modules/chromium/examples/full.py [modify] https://crrev.com/b295f0b4042a2f46dd27be4309b4fa5c77dad444/scripts/slave/recipe_modules/chromium_tests/chromium_memory.py [modify] https://crrev.com/b295f0b4042a2f46dd27be4309b4fa5c77dad444/scripts/slave/recipe_modules/chromium/config.py [modify] https://crrev.com/b295f0b4042a2f46dd27be4309b4fa5c77dad444/scripts/slave/recipe_modules/chromium/tests/configs.py , Jan 29Project MemberThe following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/7d945ba41e09206158d013d2c086dbff60b8bc70 commit 7d945ba41e09206158d013d2c086dbff60b8bc70 Author: Takuto Ikuta <tikuta@chromium.org> Date: Tue Jan 29 02:34:30 2019 Revert "[chromium] enable ninja confirm noop by default" This reverts commit b295f0b4042a2f46dd27be4309b4fa5c77dad444. Reason for revert: Broke official builder. https://ci.chromium.org/buildbot/chromium.chrome/Google%20Chrome%20ChromeOS/61062 Original change's description: > [chromium] enable ninja confirm noop by default > > This CL switches to do noop check by default. > > But I blacklisted 'Mac ASAN Debug builder' that fails the check frequently. > https://console.cloud.google.com/bigquery?project=cr-buildbucket&j=bquxjob_57647d44_16892e53358&page=queryresults > > I will remove ninja_confirm_noop config in later patch. > > Bug: 914264, 921902 > Change-Id: Ic5cd8c73469b1bf9ee590d428e6a49964b4f5a53 > Reviewed-on: https://chromium-review.googlesource.com/c/1436424 > Reviewed-by: John Budorick <jbudorick@chromium.org> > Commit-Queue: Takuto Ikuta <tikuta@chromium.org> TBR=thakis@chromium.org,tikuta@chromium.org,jbudorick@chromium.org Change-Id: I69d57a8515093caf27b4b2718a82e3dbcfd8ef55 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 914264, 921902 Reviewed-on: https://chromium-review.googlesource.com/c/1441891 Reviewed-by: Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> [modify] https://crrev.com/7d945ba41e09206158d013d2c086dbff60b8bc70/scripts/slave/recipe_modules/chromium/examples/full.py [modify] https://crrev.com/7d945ba41e09206158d013d2c086dbff60b8bc70/scripts/slave/recipe_modules/chromium_tests/chromium_memory.py [modify] https://crrev.com/7d945ba41e09206158d013d2c086dbff60b8bc70/scripts/slave/recipe_modules/chromium/config.py [modify] https://crrev.com/7d945ba41e09206158d013d2c086dbff60b8bc70/scripts/slave/recipe_modules/chromium/tests/configs.py , Jan 29
, Jan 30Project MemberThe following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/41a5c324b3476f39f855b980cb8e7163d7d59d61 commit 41a5c324b3476f39f855b980cb8e7163d7d59d61 Author: Takuto Ikuta <tikuta@chromium.org> Date: Wed Jan 30 12:54:23 2019 Reland "[chromium] enable ninja confirm noop by default" This is a reland of b295f0b4042a2f46dd27be4309b4fa5c77dad444 Blacklisted chromeos builder this time. Original change's description: > [chromium] enable ninja confirm noop by default > > This CL switches to do noop check by default. > > But I blacklisted 'Mac ASAN Debug builder' that fails the check frequently. > https://console.cloud.google.com/bigquery?project=cr-buildbucket&j=bquxjob_57647d44_16892e53358&page=queryresults > > I will remove ninja_confirm_noop config in later patch. > > Bug: 914264, 921902 > Change-Id: Ic5cd8c73469b1bf9ee590d428e6a49964b4f5a53 > Reviewed-on: https://chromium-review.googlesource.com/c/1436424 > Reviewed-by: John Budorick <jbudorick@chromium.org> > Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Bug: 914264, 921902, 926053 Change-Id: Ia81ece10671da0d9102ed4a045422259f3a9f608 Reviewed-on: https://chromium-review.googlesource.com/c/1441893 Reviewed-by: Nico Weber <thakis@chromium.org> Reviewed-by: John Budorick <jbudorick@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> [modify] https://crrev.com/41a5c324b3476f39f855b980cb8e7163d7d59d61/scripts/slave/recipe_modules/chromium_tests/chromium_chrome.py [modify] https://crrev.com/41a5c324b3476f39f855b980cb8e7163d7d59d61/scripts/slave/recipe_modules/chromium/examples/full.py [modify] https://crrev.com/41a5c324b3476f39f855b980cb8e7163d7d59d61/scripts/slave/recipe_modules/chromium_tests/chromium_memory.py [modify] https://crrev.com/41a5c324b3476f39f855b980cb8e7163d7d59d61/scripts/slave/recipe_modules/chromium/config.py [modify] https://crrev.com/41a5c324b3476f39f855b980cb8e7163d7d59d61/scripts/slave/recipe_modules/chromium/tests/configs.py , Jan 31Project MemberThe following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/6183b0c841bebe4f6b94f56dafa24fe174baa58a commit 6183b0c841bebe4f6b94f56dafa24fe174baa58a Author: Takuto Ikuta <tikuta@chromium.org> Date: Thu Jan 31 03:23:40 2019 [chromium] remove ninja confirm noop config I switched default value of ninja confirm noop config in https://chromium-review.googlesource.com/c/chromium/tools/build/+/1441893 This is just follow up to clean up no-meaning config usage. Bug: 914264 Change-Id: I4807f02440b0e3367ebf0081a9be93d5031b9498 Reviewed-on: https://chromium-review.googlesource.com/c/1445915 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Reviewed-by: Stephen Martinis <martiniss@chromium.org> [modify] https://crrev.com/6183b0c841bebe4f6b94f56dafa24fe174baa58a/scripts/slave/recipe_modules/chromium_tests/chromium_win.py [modify] https://crrev.com/6183b0c841bebe4f6b94f56dafa24fe174baa58a/scripts/slave/recipe_modules/chromium/examples/full.py [modify] https://crrev.com/6183b0c841bebe4f6b94f56dafa24fe174baa58a/scripts/slave/recipes/findit/chromium/compile_isolate.py [modify] https://crrev.com/6183b0c841bebe4f6b94f56dafa24fe174baa58a/scripts/slave/recipe_modules/chromium_tests/tryserver_chromium_android.py [modify] https://crrev.com/6183b0c841bebe4f6b94f56dafa24fe174baa58a/scripts/slave/recipe_modules/chromium_tests/client_v8_fyi.py [modify] https://crrev.com/6183b0c841bebe4f6b94f56dafa24fe174baa58a/scripts/slave/recipe_modules/chromium_tests/chromium_clang.py [modify] https://crrev.com/6183b0c841bebe4f6b94f56dafa24fe174baa58a/scripts/slave/recipe_modules/chromium_tests/chromium_android.py [modify] https://crrev.com/6183b0c841bebe4f6b94f56dafa24fe174baa58a/scripts/slave/recipe_modules/chromium_tests/client_v8_chromium.py [modify] https://crrev.com/6183b0c841bebe4f6b94f56dafa24fe174baa58a/scripts/slave/recipe_modules/chromium_tests/chromium_mac.py [modify] https://crrev.com/6183b0c841bebe4f6b94f56dafa24fe174baa58a/scripts/slave/recipe_modules/chromium_tests/chromium_gpu.py [modify] https://crrev.com/6183b0c841bebe4f6b94f56dafa24fe174baa58a/scripts/slave/recipe_modules/chromium/config.py [modify] https://crrev.com/6183b0c841bebe4f6b94f56dafa24fe174baa58a/scripts/slave/recipe_modules/chromium_tests/chromium_chromiumos.py [modify] https://crrev.com/6183b0c841bebe4f6b94f56dafa24fe174baa58a/scripts/slave/recipe_modules/chromium_tests/chromium_gpu_fyi.py [modify] https://crrev.com/6183b0c841bebe4f6b94f56dafa24fe174baa58a/scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py [modify] https://crrev.com/6183b0c841bebe4f6b94f56dafa24fe174baa58a/scripts/slave/recipe_modules/chromium_tests/chromium_webkit.py [modify] https://crrev.com/6183b0c841bebe4f6b94f56dafa24fe174baa58a/scripts/slave/recipe_modules/chromium_tests/chromium.py [modify] https://crrev.com/6183b0c841bebe4f6b94f56dafa24fe174baa58a/scripts/slave/recipe_modules/chromium_tests/chromium_linux.py [modify] https://crrev.com/6183b0c841bebe4f6b94f56dafa24fe174baa58a/scripts/slave/recipe_modules/chromium_tests/tests/api/wrap_chromium_tests.py [modify] https://crrev.com/6183b0c841bebe4f6b94f56dafa24fe174baa58a/scripts/slave/recipe_modules/chromium_tests/tryserver_chromium_linux.py , Feb 1Project MemberThe following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/28d16f987cf5db3f673abe7b2f052252b1b08031 commit 28d16f987cf5db3f673abe7b2f052252b1b08031 Author: Takuto Ikuta <tikuta@chromium.org> Date: Fri Feb 01 03:09:27 2019 [cronet] exclude pyc files from deps of generate_javadoc.py This is to fix compile noop failure in internal builder. http://shortn/_t5pHTnebHY Bug: 914264 Change-Id: I26881dca70d41fdb340df6d9ef85f1d9bd8b6a3b Reviewed-on: https://chromium-review.googlesource.com/c/1448085 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Paul Jensen <pauljensen@chromium.org> Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Reviewed-by: Paul Jensen <pauljensen@chromium.org> Cr-Commit-Position: refs/heads/master@{#628219} [modify] https://crrev.com/28d16f987cf5db3f673abe7b2f052252b1b08031/components/cronet/tools/generate_javadoc.py , Feb 1Project MemberThe following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/4cab13397c87644ab3abadc4bd7d215fc22a0c46 commit 4cab13397c87644ab3abadc4bd7d215fc22a0c46 Author: Takuto Ikuta <tikuta@chromium.org> Date: Fri Feb 01 05:26:11 2019 Remove ninja_confirm_noop config from chromium_clang builder This is not necessary anymore. Bug: 914264 Change-Id: I6b3e700a7f0dbe1c5d0928324ea6a7927fbdd278 Reviewed-on: https://chromium-review.googlesource.com/c/1449411 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Reviewed-by: Fumitoshi Ukai <ukai@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> [modify] https://crrev.com/4cab13397c87644ab3abadc4bd7d215fc22a0c46/scripts/slave/recipe_modules/chromium_tests/chromium_clang.py , Feb 1Project Member
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f8108efc1e107082f16b6ebc55d7324e4873dd8e commit f8108efc1e107082f16b6ebc55d7324e4873dd8e Author: Takuto Ikuta <tikuta@chromium.org> Date: Fri Feb 01 14:39:33 2019 [cronet] exclude pyc files from deps of generate_javadoc.py This is to fix compile noop failure in internal builder. http://shortn/_t5pHTnebHY Merging this back without normal approval as it only affects Cronet and not Chrome. Bug: 914264 Change-Id: I26881dca70d41fdb340df6d9ef85f1d9bd8b6a3b Reviewed-on: https://chromium-review.googlesource.com/c/1448085 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Paul Jensen <pauljensen@chromium.org> Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Reviewed-by: Paul Jensen <pauljensen@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#628219}(cherry picked from commit 28d16f987cf5db3f673abe7b2f052252b1b08031) Reviewed-on: https://chromium-review.googlesource.com/c/1449814 Reviewed-by: Takuto Ikuta <tikuta@chromium.org> Reviewed-by: Misha Efimov <mef@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#811} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} [modify] https://crrev.com/f8108efc1e107082f16b6ebc55d7324e4873dd8e/components/cronet/tools/generate_javadoc.py , Feb 1Project Member
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4e1c199249c5acae996f30cc5b851eed65487678 commit 4e1c199249c5acae996f30cc5b851eed65487678 Author: Takuto Ikuta <tikuta@chromium.org> Date: Fri Feb 01 14:39:08 2019 [cronet] exclude pyc files from deps of generate_javadoc.py This is to fix compile noop failure in internal builder. http://shortn/_t5pHTnebHY Merging this back without normal approval as it only affects Cronet and not Chrome. Bug: 914264 Change-Id: I26881dca70d41fdb340df6d9ef85f1d9bd8b6a3b Reviewed-on: https://chromium-review.googlesource.com/c/1448085 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Paul Jensen <pauljensen@chromium.org> Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Reviewed-by: Paul Jensen <pauljensen@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#628219}(cherry picked from commit 28d16f987cf5db3f673abe7b2f052252b1b08031) Reviewed-on: https://chromium-review.googlesource.com/c/1449813 Reviewed-by: Takuto Ikuta <tikuta@chromium.org> Reviewed-by: Misha Efimov <mef@chromium.org> Cr-Commit-Position: refs/branch-heads/3683@{#119} Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896} [modify] https://crrev.com/4e1c199249c5acae996f30cc5b851eed65487678/components/cronet/tools/generate_javadoc.py , Feb 1Project Member
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f8108efc1e107082f16b6ebc55d7324e4873dd8e Commit: f8108efc1e107082f16b6ebc55d7324e4873dd8e Author: tikuta@chromium.org Commiter: pauljensen@chromium.org Date: 2019-02-01 14:39:33 +0000 UTC [cronet] exclude pyc files from deps of generate_javadoc.py This is to fix compile noop failure in internal builder. http://shortn/_t5pHTnebHY Merging this back without normal approval as it only affects Cronet and not Chrome. Bug: 914264 Change-Id: I26881dca70d41fdb340df6d9ef85f1d9bd8b6a3b Reviewed-on: https://chromium-review.googlesource.com/c/1448085 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Paul Jensen <pauljensen@chromium.org> Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Reviewed-by: Paul Jensen <pauljensen@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#628219}(cherry picked from commit 28d16f987cf5db3f673abe7b2f052252b1b08031) Reviewed-on: https://chromium-review.googlesource.com/c/1449814 Reviewed-by: Takuto Ikuta <tikuta@chromium.org> Reviewed-by: Misha Efimov <mef@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#811} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} , Feb 1Project Member
Here's a summary of the rules that were executed: - OnlyMergeApprovedChange: Rule Failed -- Revision f8108efc1e107082f16b6ebc55d7324e4873dd8e was merged to refs/branch-heads/3626 branch with no merge approval from a TPM! Please explain why this change was merged to the branch! - AcknowledgeMerge: Notification Required -- , Feb 6Project MemberThe following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/tools/build_limited/scripts/slave/+/d7127780ee0769460f30e00103d5b19679e80410 commit d7127780ee0769460f30e00103d5b19679e80410 Author: Takuto Ikuta <tikuta@google.com> Date: Wed Feb 06 00:22:24 2019 , Feb 7Project Member
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4e1c199249c5acae996f30cc5b851eed65487678 Commit: 4e1c199249c5acae996f30cc5b851eed65487678 Author: tikuta@chromium.org Commiter: pauljensen@chromium.org Date: 2019-02-01 14:39:08 +0000 UTC [cronet] exclude pyc files from deps of generate_javadoc.py This is to fix compile noop failure in internal builder. http://shortn/_t5pHTnebHY Merging this back without normal approval as it only affects Cronet and not Chrome. Bug: 914264 Change-Id: I26881dca70d41fdb340df6d9ef85f1d9bd8b6a3b Reviewed-on: https://chromium-review.googlesource.com/c/1448085 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Paul Jensen <pauljensen@chromium.org> Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Reviewed-by: Paul Jensen <pauljensen@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#628219}(cherry picked from commit 28d16f987cf5db3f673abe7b2f052252b1b08031) Reviewed-on: https://chromium-review.googlesource.com/c/1449813 Reviewed-by: Takuto Ikuta <tikuta@chromium.org> Reviewed-by: Misha Efimov <mef@chromium.org> Cr-Commit-Position: refs/branch-heads/3683@{#119} Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896} , Feb 7Project Member
Here's a summary of the rules that were executed: - OnlyMergeApprovedChange: Rule Failed -- Revision 4e1c199249c5acae996f30cc5b851eed65487678 was merged to refs/branch-heads/3683 branch with no merge approval from a TPM! Please explain why this change was merged to the branch! - AcknowledgeMerge: Notification Required -- , Feb 12
|
|||||||||||||||
►
Sign in to add a comment |
|||||||||||||||
Comment 1 by bugdroid1@chromium.org, Dec 12
Project Member