New issue
Advanced search Search tips

Issue 914235 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 14
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

CHECK failure: sk_color_space in image_info_struct_traits.cc

Project Member Reported by ClusterFuzz, Dec 12

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5073979284652032

Fuzzer: mojo_fuzzer
Job Type: linux_asan_chrome_mojo
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  sk_color_space in image_info_struct_traits.cc
  mojo::StructTraits<skia::mojom::ImageInfoDataView, SkImageInfo>::Read
  mojo::StructTraits<skia::mojom::BitmapDataView, SkBitmap>::Read
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_asan_chrome_mojo&range=615610:615613

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5073979284652032

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Dec 12

Components: Internals>Skia
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Dec 12

Labels: Test-Predator-Auto-Owner
Owner: m...@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/046e446b56764939026ad97d198ff63410f629af (Implement SkColorSpace struct traits in skia.mojom.ImageInfo.).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
Project Member

Comment 3 by ClusterFuzz, Dec 13

ClusterFuzz has detected this issue as fixed in range 616240:616241.

Detailed report: https://clusterfuzz.com/testcase?key=5073979284652032

Fuzzer: mojo_fuzzer
Job Type: linux_asan_chrome_mojo
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  sk_color_space in image_info_struct_traits.cc
  mojo::StructTraits<skia::mojom::ImageInfoDataView, SkImageInfo>::Read
  mojo::StructTraits<skia::mojom::BitmapDataView, SkBitmap>::Read
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_asan_chrome_mojo&range=615610:615613
Fixed: https://clusterfuzz.com/revisions?job=linux_asan_chrome_mojo&range=616240:616241

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5073979284652032

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 4 by ClusterFuzz, Dec 13

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 5073979284652032 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Status: Started (was: Verified)
Actually, there's a bug: In the mojo Read() struct traits, there should not be a CHECK(), but rather the method should just return false on invalid input.
Labels: -ClusterFuzz-Verified ClusterFuzz-Wrong
Project Member

Comment 7 by bugdroid1@chromium.org, Dec 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bb7f0d774ec7f6ee47d51e709376e8ebc8686674

commit bb7f0d774ec7f6ee47d51e709376e8ebc8686674
Author: Yuri Wiitala <miu@chromium.org>
Date: Thu Dec 13 23:35:19 2018

Crash fix: Skia ImageInfo struct traits Read() should not CHECK().

A recent implementation of the mojo struct traits for SkImageInfo caused
Clusterfuzz to discover a crash: The root cause is that Clusterfuzz was
providing invalid inputs to StructTraits<...>::Read() (as it should),
but Read() should not be CHECK()-crashing the process on invalid inputs.
Instead, it should just return false, as is the interface contract.

TBR=palmer@chromium.org

Bug:  914235 
Change-Id: Ibe0af638ebab11e161af6a154c22eaf4a50af695
Reviewed-on: https://chromium-review.googlesource.com/c/1376795
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Commit-Queue: Yuri Wiitala <miu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616488}
[modify] https://crrev.com/bb7f0d774ec7f6ee47d51e709376e8ebc8686674/skia/public/interfaces/image_info_struct_traits.cc

Status: Fixed (was: Started)

Sign in to add a comment