New issue
Advanced search Search tips

Issue 914231 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 14
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

It's hard to see the FPS counter in small screen resolution

Project Member Reported by gyuyoung...@chromium.org, Dec 12

Issue description

When we need to see the FPS counter on the low-resolution screen, now it is hard because the FPS counter is placed on the top-right side. So embedders have been troubled with the problem when they need to measure rendering performance with the FPS counter. So it would be good if embedder can configure the position of the FPS counter.
 
Owner: gyuyoung...@lge.com
Components: Internals>Compositing
Status: Assigned (was: Untriaged)
These are the screenshots that the FPS counter is not shown on the screen when FPS counter is launched by a remote inspector.
 - Top-right on device: https://drive.google.com/file/d/13cAmUicEsgwgeiZuLTrBOo0QZD6-Q2sT/view?usp=sharing
 
That's why the FPS counter is drawn out of the content.
 - https://drive.google.com/open?id=1MTfgLat1Mzr4yBUFgBLjdP_KZQ7rymSj

If we move the FPS counter to the top-left, we can see the FPS counter on the top-left side.

- Top-left on device: https://drive.google.com/file/d/1UJCOvUaqMO7-W9XxCtREKsHEB4xoFcQU/view?usp=sharing

Project Member

Comment 5 by bugdroid1@chromium.org, Jan 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6381e8bc3256fa765d5824fc231ff6cc45eb9e2a

commit 6381e8bc3256fa765d5824fc231ff6cc45eb9e2a
Author: Gyuyoung Kim <gyuyoung.kim@lge.com>
Date: Tue Jan 08 09:18:48 2019

CC: Move the position of the HUD from the top-right to the top-left

The FPS counter has been helping to debug rendering performance.
Especially, embeddeders also have been using it to measure the performance
of rendering on their devices. However, as we know, embedded devices
have various screen resolutions. In low-resolution devices, it sometimes can
draw the FPS counter on out of the screen when launching the FPS counter by
a remote inspector. To help embedders who want to see the FPS counter in the
small screen resolution, this CL moves the position of the FPS counter to the
top-left side.

Bug:  914231 
Change-Id: I54210347cefb265c3efe6588a2728ddbd6dd0123
Reviewed-on: https://chromium-review.googlesource.com/c/1373254
Reviewed-by: Victor Miura <vmiura@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: Gyuyoung Kim <gyuyoung.kim@lge.com>
Cr-Commit-Position: refs/heads/master@{#620662}
[modify] https://crrev.com/6381e8bc3256fa765d5824fc231ff6cc45eb9e2a/cc/layers/heads_up_display_layer.cc
[modify] https://crrev.com/6381e8bc3256fa765d5824fc231ff6cc45eb9e2a/cc/layers/heads_up_display_layer_impl.cc

Cc: gyuyo...@igalia.com
Status: Fixed (was: Assigned)

Sign in to add a comment