Nocturne: video_PowerConsumption.hw_hangout.vp8 is flaky due to "Running on AC power. Please remove AC power cable" |
|||||||||||
Issue descriptionStainless: https://stainless.corp.google.com/search?view=list&build=R73&test=video_PowerConsumption.hw_hangout.vp8&board=%5Enocturne%24&first_date=2018-11-14&last_date=2018-12-12&status=GOOD&status=WARN&status=FAIL&status=ERROR Failure message: File "/usr/local/autotest/tests/video_HangoutHardwarePerf/video_HangoutHardwarePerf.py", line 282, in run_once with PowerMeasurer() as measurer: File "/usr/local/autotest/tests/video_HangoutHardwarePerf/video_HangoutHardwarePerf.py", line 118, in __enter__ status.assert_battery_state(BATTERY_INITIAL_CHARGED_MIN) File "/usr/local/autotest/cros/power/power_status.py", line 539, in assert_battery_state 'Running on AC power. Please remove AC power cable.') TestError: Running on AC power. Please remove AC power cable. Basically this test will turn off AC power and then examine if AC power is off. However this action seems like not that reliable. Not only for Nocturne, some other boards could also be observed the same issue. Ex. Kevin https://stainless.corp.google.com/search?view=list&first_date=2018-11-14&last_date=2018-12-12&test=video_PowerConsumption.hw_hangout.vp8&build=R73&board=kevin&status=GOOD&status=WARN&status=FAIL&status=ERROR&exclude_cts=false&exclude_not_run=false&exclude_non_release=true&exclude_au=true&exclude_acts=true&exclude_retried=true&exclude_non_production=false
,
Dec 12
This is the known issue before, see https://bugs.chromium.org/p/chromium/issues/detail?id=723968 During that time Kuang-che has modified video_PlaybackPerf.py and video_WebRtcPerf.py to skip the test instead of failing if checking AC power off is failed. video_PowerConsumption.hw_hangout.vp8 is video_HangoutHardwarePerf.py, so I think it makes sense to use the same strategy to avoid failures.
,
Dec 14
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/262e1cec24075f0d720cf26eaafcb20e0b0be1e6 commit 262e1cec24075f0d720cf26eaafcb20e0b0be1e6 Author: Pin-chih Lin <johnylin@google.com> Date: Fri Dec 14 03:28:07 2018 video_HangoutHardwarePerf: skip power test if AC state is unexpected The power test expects DUT is powered by battery now. But this is not always reliable. Skip the test as workaround. BUG= chromium:914211 TEST=run video_HangoutHardwarePerf.power.vp8 on Kevin with AC plugged, the result is skipped by TestNAError instead of failed Change-Id: I5128f6bf858d1c131b32c917b3d7082fe238d3d0 Reviewed-on: https://chromium-review.googlesource.com/1373212 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Tested-by: Pin-chih Lin <johnylin@chromium.org> Reviewed-by: Chih-Yu Huang <akahuang@chromium.org> [modify] https://crrev.com/262e1cec24075f0d720cf26eaafcb20e0b0be1e6/client/site_tests/video_HangoutHardwarePerf/video_HangoutHardwarePerf.py
,
Dec 14
,
Dec 14
This bug requires manual review: M72 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 17
,
Dec 17
Hi djmm@, Here is an autotest fix CL requested to merge to M72. This could reduce the flakiness of video_PowerConsumption.hw_hangout.vp8 on both M73 and M72. https://chromium-review.googlesource.com/c/chromiumos/third_party/autotest/+/1379089 Thanks
,
Dec 18
+ dgagnon@ and cindyb@ since djmm@ is on vacation :)
,
Dec 18
I believe this was missed as it was not tagged with M-72 label. Marking as Merge-Approved-72
,
Dec 19
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/013e5ad6c57d16cebf4199118c506ac7aca4a056 commit 013e5ad6c57d16cebf4199118c506ac7aca4a056 Author: Pin-chih Lin <johnylin@google.com> Date: Wed Dec 19 09:37:26 2018 video_HangoutHardwarePerf: skip power test if AC state is unexpected The power test expects DUT is powered by battery now. But this is not always reliable. Skip the test as workaround. BUG= chromium:914211 TEST=run video_HangoutHardwarePerf.power.vp8 on Kevin with AC plugged, the result is skipped by TestNAError instead of failed Change-Id: I5128f6bf858d1c131b32c917b3d7082fe238d3d0 Reviewed-on: https://chromium-review.googlesource.com/1373212 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Tested-by: Pin-chih Lin <johnylin@chromium.org> Reviewed-by: Chih-Yu Huang <akahuang@chromium.org> (cherry picked from commit 262e1cec24075f0d720cf26eaafcb20e0b0be1e6) Reviewed-on: https://chromium-review.googlesource.com/c/1379089 Commit-Queue: Pin-chih Lin <johnylin@chromium.org> Trybot-Ready: Pin-chih Lin <johnylin@chromium.org> [modify] https://crrev.com/013e5ad6c57d16cebf4199118c506ac7aca4a056/client/site_tests/video_HangoutHardwarePerf/video_HangoutHardwarePerf.py
,
Dec 19
,
Dec 21
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 25
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot |
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by posciak@chromium.org
, Dec 12