|
|
|||||||||
Issue descriptionStarted failing here: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Android%20FYI%20Release%20%28Nexus%205%29/12423 (Run is marked as "Success" despite a pixel test failure. That's been fixed) There's a skia roll which might be responsible: git log 3bdc3f5f9c0b..12659a46b9d9 --date=short --no-merges --format='%ad %ae %s' 2018-12-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 f5c88e7e1c1a..be607ad63609 (1 commits) 2018-12-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader afb8cd307bc5..a233ceaecd85 (1 commits) 2018-12-11 mtklein@google.com Try out clang-tidy, starting with bugprone-use-after-move 2018-12-11 reed@google.com Revert "Treat kWEBP encode with quality=100 as lossless" 2018-12-11 caryclark@skia.org bracket SkPath pathRefIsValid with define 2018-12-11 reed@google.com impl intercepts with fonts 2018-12-11 michaelludwig@google.com Consolidate stroke-rect ops and use GrFillRectOp instead of GrNonAA/AARectOp 2018-12-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 7cfb50cd5f50..afb8cd307bc5 (1 commits) There's also a paint change that I suspect: https://chromium-review.googlesource.com/c/chromium/src/+/1370497 I'm landing a suppression right now. mcasas@ Why is this test running on Android? I thought low latency canvas is only supported on ChromeOS. reed@/michaelludwig@/caryclark@ Please let me know if your skia changes could be responsible.
, Dec 12Project MemberThe following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/336f923ffef90103d3562c8a471c39cf0bf7b111 commit 336f923ffef90103d3562c8a471c39cf0bf7b111 Author: Sunny Sachanandani <sunnyps@chromium.org> Date: Wed Dec 12 04:14:51 2018 Mark low latency canvas2d test failing on Nexus 5 First failing build: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Android%20FYI%20Release%20%28Nexus%205%29/12423 TBR=kbr@chromium.org Bug: 914206 Change-Id: Ia1130a35e1e8ba87e09217367351d08c168dee50 Reviewed-on: https://chromium-review.googlesource.com/c/1372637 Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#615814} [modify] https://crrev.com/336f923ffef90103d3562c8a471c39cf0bf7b111/content/test/gpu/gpu_tests/pixel_expectations.py , Dec 12The paint CL is for a feature that has not been enabled yet. The test seems to just need a rebaseline. , Dec 12I made an update to how rectangles were rendered in Skia, so it is very likely my change that causes this. Looking at the two images, the only difference is in a slight change in coverage along the top and left edges of the outer rectangle, probably from slight differences in how anti-aliasing is computed. It amounts to about a 2% change in intensity for that edge, although it is hard to perceive, and it doesn't change the pixels touched by the rendering. Given all of that, I'd recommend rebaselining the test as well. , Dec 12Project MemberThe following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5879d69c440eabb30e36ce05bdfdf287a73c7a17 commit 5879d69c440eabb30e36ce05bdfdf287a73c7a17 Author: Sunny Sachanandani <sunnyps@chromium.org> Date: Wed Dec 12 21:38:50 2018 Rebaseline low latency canvas2d pixel test A recent Skia roll made changes to rectangle anti-aliasing. Rebaselining per Skia owners recommendation. Will reenable test in followup CL. TBR=kbr@chromium.org Bug: 914206 Change-Id: I22d1982b6a73c79a3f198370c2f25b47e11ed2bc Reviewed-on: https://chromium-review.googlesource.com/c/1374512 Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#616057} [modify] https://crrev.com/5879d69c440eabb30e36ce05bdfdf287a73c7a17/content/test/gpu/gpu_tests/pixel_expectations.py [modify] https://crrev.com/5879d69c440eabb30e36ce05bdfdf287a73c7a17/content/test/gpu/gpu_tests/pixel_test_pages.py , Dec 12
, Dec 13Project MemberThe following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/39dc9694e6f8adc9d5bfbb38f5192a642f6109f4 commit 39dc9694e6f8adc9d5bfbb38f5192a642f6109f4 Author: Sunny Sachanandani <sunnyps@chromium.org> Date: Thu Dec 13 03:09:49 2018 Reenable low latency canvas2d pixel test after rebaselining TBR=kbr@chromium.org Bug: 914206 Change-Id: I9f1e5bbf513640fb9ec17d0b1d1cebe06a02d549 Reviewed-on: https://chromium-review.googlesource.com/c/1374360 Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#616189} [modify] https://crrev.com/39dc9694e6f8adc9d5bfbb38f5192a642f6109f4/content/test/gpu/gpu_tests/pixel_expectations.py , Dec 13
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by sunn...@chromium.org, Dec 12