New issue
Advanced search Search tips

Issue 914201 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Dec 12
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Fuchsia
Pri: 2
Type: Bug



Sign in to add a comment

fuchsia needs toplevel traces for zircon handle watchers

Project Member Reported by spang@chromium.org, Dec 12

Issue description

I/O is not showing up in chrome tracing in Fuchsia.

Fix it by instrumenting MessagePumpFuchsia to create toplevel trace spans when it wakes up from an I/O notification.
 
Labels: M-73
Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/24a358d36c07b62e0037eb130c32518ad1986e5a

commit 24a358d36c07b62e0037eb130c32518ad1986e5a
Author: Michael Spang <spang@chromium.org>
Date: Wed Dec 12 19:55:00 2018

base: fuchsia: Add toplevel trace span for I/O notifications

The message pump is responsible for creating a toplevel span for each time slice
triggered from I/O polling. This type of work is not run in the context of a
a TaskAnnotator, and is completely invisible to tracing without help from the
message pump.

Bug:  914201 
Test: run_content_shell --remote-debugging-port=9222
      ssh root@fuchsia -N -L 9222:localhost:9222
      add localhost to chrome://inspect?tracing & connect

Change-Id: Ib9d248303c1c11d6fd7f616c31e0a76949c14d63
Reviewed-on: https://chromium-review.googlesource.com/c/1373132
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Commit-Queue: Michael Spang <spang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616005}
[modify] https://crrev.com/24a358d36c07b62e0037eb130c32518ad1986e5a/base/message_loop/message_pump_fuchsia.cc

Status: Fixed (was: Started)
Status: Verified (was: Fixed)

Sign in to add a comment