New issue
Advanced search Search tips

Issue 914196 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Dec 13
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task

Blocking:
issue 909848



Sign in to add a comment

Remove buildbot support from kitchen

Project Member Reported by iannu...@google.com, Dec 12

Issue description

This is needed to simplify kitchen before re-complexifying it during the build.proto conversion for recipes.
 
Labels: -Type-Bug Type-Task
Does this mean that parallelism in recipes is blocked on Buildbot turn down in March?
No it's not, just on cleaning up kitchen; this is pretty easy code to remove, but I need to make sure nothing is using it first. Buildbot works fine without kitchen.
(it's not a strict blocker, just will make transitioning a lot easier)
Oh, actually, I realized that buildbot pins a super ancient version of kitchen, so I can just delete stuff without touching buildbot. Yay!

Comment 5 Deleted

Project Member

Comment 6 by bugdroid1@chromium.org, Dec 12

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/d33358177843fbb274d7fec89bfdda7db02c43c6

commit d33358177843fbb274d7fec89bfdda7db02c43c6
Author: Robert Iannucci <iannucci@chromium.org>
Date: Wed Dec 12 22:14:01 2018

[kitchen] Remove all buildbot related logic.

Buildbot uses a very old, pinned, copy of kitchen, and we don't plan to
roll it before we delete buildbot entirely in 2018Q1.

So, we don't need any of the additional complexity in kitchen that its
existance implies.

R=nodir@chromium.org

Bug:  914196 
Change-Id: Ib7d5965473da3523b0a4a764d7901a8aea8e8d09
Reviewed-on: https://chromium-review.googlesource.com/c/1373310
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#19527}
[modify] https://crrev.com/d33358177843fbb274d7fec89bfdda7db02c43c6/go/src/infra/tools/kitchen/cookflags/flags.go
[modify] https://crrev.com/d33358177843fbb274d7fec89bfdda7db02c43c6/go/src/infra/tools/kitchen/cook_test.go
[modify] https://crrev.com/d33358177843fbb274d7fec89bfdda7db02c43c6/go/src/infra/tools/kitchen/cookflags/logdog_flags.go
[modify] https://crrev.com/d33358177843fbb274d7fec89bfdda7db02c43c6/go/src/infra/tools/kitchen/cookflags/flags_test.go
[modify] https://crrev.com/d33358177843fbb274d7fec89bfdda7db02c43c6/go/src/infra/tools/kitchen/auth.go
[modify] https://crrev.com/d33358177843fbb274d7fec89bfdda7db02c43c6/go/src/infra/tools/kitchen/cook.go
[delete] https://crrev.com/3bdb10bc1bf7852f5fc3686269c0e3c1d0b02e52/go/src/infra/tools/kitchen/cook_mode.go
[modify] https://crrev.com/d33358177843fbb274d7fec89bfdda7db02c43c6/go/src/infra/tools/kitchen/cookflags/validate.go
[delete] https://crrev.com/3bdb10bc1bf7852f5fc3686269c0e3c1d0b02e52/go/src/infra/tools/kitchen/cookflags/cookmode.go
[modify] https://crrev.com/d33358177843fbb274d7fec89bfdda7db02c43c6/go/src/infra/tools/kitchen/cook_logdog.go

Project Member

Comment 7 by bugdroid1@chromium.org, Dec 12

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config/+/fc2f53d1b35f2395b184e6f9e57ca79709cffe74

commit fc2f53d1b35f2395b184e6f9e57ca79709cffe74
Author: Robert Iannucci <iannucci@chromium.org>
Date: Wed Dec 12 22:26:46 2018

Project Member

Comment 8 by bugdroid1@chromium.org, Dec 12

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config/+/49e15f9aeb119b624ecb10ba0f73282dd0c8f977

commit 49e15f9aeb119b624ecb10ba0f73282dd0c8f977
Author: Robert Iannucci <iannucci@chromium.org>
Date: Wed Dec 12 22:58:41 2018

Project Member

Comment 9 by bugdroid1@chromium.org, Dec 13

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config/+/daaff082e95b94bec84fa6e440a8b97677d6f76d

commit daaff082e95b94bec84fa6e440a8b97677d6f76d
Author: Robert Iannucci <iannucci@chromium.org>
Date: Thu Dec 13 01:28:08 2018

Status: Fixed (was: Untriaged)
Project Member

Comment 11 by bugdroid1@chromium.org, Dec 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/f423e051f343631f92cd1f261168c5215f6dacf6

commit f423e051f343631f92cd1f261168c5215f6dacf6
Author: Robert Iannucci <iannucci@chromium.org>
Date: Thu Dec 13 19:43:37 2018

[led] Update led to latest version.

This removes the '-mode' flag from the emitted job descriptions.

TBR=nodir@chromium.org

Bug:  914196 , 914926 
Change-Id: I94ab67f0969b198164fa3fc3ef64a649dcf941bd
Reviewed-on: https://chromium-review.googlesource.com/c/1376657
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>

[modify] https://crrev.com/f423e051f343631f92cd1f261168c5215f6dacf6/cipd_manifest.versions
[modify] https://crrev.com/f423e051f343631f92cd1f261168c5215f6dacf6/cipd_manifest.txt

Project Member

Comment 12 by bugdroid1@chromium.org, Dec 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ed7a82d8b37fc44ff066bb8803a2c68a5048c0df

commit ed7a82d8b37fc44ff066bb8803a2c68a5048c0df
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Thu Dec 13 22:35:51 2018

Roll src/third_party/depot_tools 7fa4fbc46829..f423e051f343 (2 commits)

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/7fa4fbc46829..f423e051f343


git log 7fa4fbc46829..f423e051f343 --date=short --no-merges --format='%ad %ae %s'
2018-12-13 iannucci@chromium.org [led] Update led to latest version.
2018-12-13 sergiyb@chromium.org Add a feature to specify branches to be re-based


Created with:
  gclient setdep -r src/third_party/depot_tools@f423e051f343

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG= chromium:914196 , chromium:914926 
TBR=agable@chromium.org

Change-Id: Icfb8fe0b34863b5961a26bee277c9f5c144fa420
Reviewed-on: https://chromium-review.googlesource.com/c/1376872
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#616460}
[modify] https://crrev.com/ed7a82d8b37fc44ff066bb8803a2c68a5048c0df/DEPS

Sign in to add a comment