New issue
Advanced search Search tips
Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 15
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment
link

Issue 914189: Tap the bottom of the display when shelf is auto-hide can still open the corresponding apps.

Reported by minch@chromium.org, Dec 12 Project Member

Issue description

Chrome Version: 73.0.3637.0

What steps will reproduce the problem?
(1) Set shelf to auto-hide and keep at least one window opened.
(2) Make sure shelf is hidden. Tap the bottom of the display.

What is the expected result?
Window of the shelf item in the tap area is opened.

What happens instead?
The app window should not be opened.



Please use labels and text to provide additional information.

If this is a regression (i.e., worked before), please consider using the
bisect tool (https://www.chromium.org/developers/bisect-builds-py) to help
us identify the root cause and more rapidly triage the issue.

For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.
 

Comment 1 by minch@chromium.org, Dec 12

Summary: Tap the bottom of the display when shelf is auto-hide can still open the corresponding apps. (was: Tap the screen button when shelf is auto-hide can still open the corresponding apps.)

Comment 2 by minch@chromium.org, Dec 12

Status: Started (was: Assigned)

Comment 3 by minch@chromium.org, Dec 13

Cc: shibasheikh@chromium.org xiy...@chromium.org
Hi Ben and Shiba, during fixing this issue, I found I need to change the current behavior as following,

If events (e.g, Tap, long press) happened inside the shelf area (including the empty area) when app list is opened, going to dismiss the app list but keep shelf visible. (currently, if we tap the shelf area, whatever empty area or not, it will dismiss the app list and shelf at the same time).

Does the change make sense to you?

After the change, then tap the shelf area will only dismiss the app list but not the shelf. Tap the app list area will dismiss both the app list and shelf(current behavior).
The change will also fixed the issue that long press the item in the auto-hide shelf when app list is opened can work as expected, e.g, dismiss the app list, show the context menu and keep shelf visible, or drag and drop the item after context menu is shown.

Comment 4 by mccanny@chromium.org, Dec 14

Hey Min, I would expect taps in empty areas of the shelf to keep both shelf and app list open. Taps on an app would launch the app and close both. Shiba, thoughts?

Comment 5 by bugdroid1@chromium.org, Dec 15

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ed4ad75877ca2837555e7f5bc0776f23d2a635f7

commit ed4ad75877ca2837555e7f5bc0776f23d2a635f7
Author: Min Chen <minch@google.com>
Date: Sat Dec 15 00:34:38 2018

shelf: Press the shortcut in auto-hide shelf should do nothing.

changes in this cl:
- Do not process the event in ShelfView::ButtonPressed for auto-hide
  shelf. Since for example we don't want to open the app window by tap
  the shortcut in auto-hide shelf.

- Keep auto-hide shelf visible if tap inside the shelf when app list is
  opened. This is used to make sure press the shortcut in the auto-hide
  shelf when app list is opened can still open the corresponding app.
  It works before since we can tap the shortcut in the auto-hide shelf
  to open the app, but we fixed it in this cl.

Bug:  914189 
Change-Id: I5cdc5e0164b8958e3ffdf03c9718ffab0c6a5ab6
Reviewed-on: https://chromium-review.googlesource.com/c/1374147
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Min Chen <minch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616896}
[modify] https://crrev.com/ed4ad75877ca2837555e7f5bc0776f23d2a635f7/ash/app_list/app_list_presenter_delegate_impl.cc
[modify] https://crrev.com/ed4ad75877ca2837555e7f5bc0776f23d2a635f7/ash/app_list/app_list_presenter_delegate_unittest.cc
[modify] https://crrev.com/ed4ad75877ca2837555e7f5bc0776f23d2a635f7/ash/shelf/shelf_layout_manager_unittest.cc
[modify] https://crrev.com/ed4ad75877ca2837555e7f5bc0776f23d2a635f7/ash/shelf/shelf_view.cc

Comment 6 by minch@chromium.org, Dec 15

Status: Fixed (was: Started)

Comment 7 by minch@chromium.org, Dec 17

Cc: minch@chromium.org
 Issue 913976  has been merged into this issue.

Sign in to add a comment